DG4MLK/MeshCore-Evo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Also fix countBefore(0xFFFFFFFF) to return _num

Browse Source 
The signed comparison in countBefore breaks for the max uint32_t value.
Even though callers now use getOutboundTotal(), the function itself
should be correct for all inputs.
This commit is contained in:
Daniel Novak
2026-03-01 07:39:43 +01:00
parent c7568a8db0
commit 0d87dcc989
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/helpers/StaticPoolPacketManager.cpp
View File

@@ -9,6 +9,8 @@ PacketQueue::PacketQueue(int max_entries) {
} }
int PacketQueue::countBefore(uint32_t now) const { int PacketQueue::countBefore(uint32_t now) const {
if (now == 0xFFFFFFFF) return _num; // sentinel: count all entries regardless of schedule
int n = 0; int n = 0;
for (int j = 0; j < _num; j++) { for (int j = 0; j < _num; j++) {
if ((int32_t)(_schedule_table[j] - now) > 0) continue; // scheduled for future... ignore for now if ((int32_t)(_schedule_table[j] - now) > 0) continue; // scheduled for future... ignore for now