mirror of
https://github.com/Akkudoktor-EOS/EOS.git
synced 2026-09-11 10:26:38 +00:00
fix: unify mypy environments for local checks and CI (#1291)
The isolated pre-commit mypy hook previously omitted runtime type information that make mypy used, hiding errors involving dependencies such as Pydantic and Pendulum. Makefile, pre-commit and CI now run the same full-project typing policy in the development environment defined by uv.lock. - Use uv run --locked --exact --extra dev and the same mypy arguments for Makefile and the local hook. Check all of src and tests, including on configuration-only changes. - Pin Python 3.13 for local development and the pre-commit CI job, and install the locked pre-commit version in CI. - Disable incremental analysis because existing Pendulum cache state changes mypy 2.3.1 diagnostics. Document the policy, the performance tradeoff and the existing typing debt. - Add a regression test that exercises Makefile, the hook and the CI command in a temporary project, accepting valid dependency types and detecting deliberate Pydantic/Pendulum assignment errors. Resolve the newly detected mypy diagnostics. - Enable the numpydantic and Pydantic mypy plugins, retaining strict Pydantic constructor typing with init_typed = true. Validate raw/coercible payloads through model_validate. - Propagate concrete record, provider and time-window types through generic collections, factories and lookup methods. Preserve runtime field inspection and generated time-window documentation. - Align Pendulum annotations with actual factory/arithmetic results while retaining Pydantic validation adapters at runtime. Correct optional values, array boundaries, REST handlers and plotting interfaces. - Add pinned scipy-stubs and types-psutil, update uv.lock, and supply the plugins' dependencies. - Add runtime regression coverage for validated path defaults, normalized time-series metadata, generic field inspection, invalid timestamps and unsupported provider imports. Runtime and compatibility details: - Validate path defaults as Path objects while retaining raw string defaults needed by migration serialization with exclude_defaults. - Normalize feed-in tariff lists and default charge rates to NumPy arrays; reject missing timestamps/uninitialized values explicitly. Importing into a provider without import support returns HTTP 400. - Public JSON schemas and OpenAPI structure match main (excluding the generated version). Signed-off-by: dr-dimitry Signed-off-by: dr-dimitry Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com> Co-authored-by: dr-dimitri <87113560+dr-dimitri@users.noreply.github.com> Co-authored-by: Normann <github@koldrack.com>
This commit is contained in:
co-authored by
dr-dimitri
Normann
parent
5b584cbb57
commit
1abdd345c4
+16
-1
@@ -54,7 +54,7 @@ dev = [
|
||||
# - pre-commit-hooks
|
||||
# - isort
|
||||
# - ruff
|
||||
# - mypy (mirrors-mypy) - sync with requirements-dev.txt (if on pypi)
|
||||
# Mypy runs in this development environment, using uv.lock, including from pre-commit.
|
||||
# - pymarkdown
|
||||
# - commitizen - sync with requirements-dev.txt (if on pypi)
|
||||
#
|
||||
@@ -66,6 +66,8 @@ dev = [
|
||||
"tokenize-rt==6.2.0", # for mypy
|
||||
"types-docutils==0.23.0.20260827", # for mypy
|
||||
"types-PyYaml==6.0.12.20260815", # for mypy
|
||||
"scipy-stubs==1.17.1.5", # for mypy
|
||||
"types-psutil==7.2.2.20260906", # for mypy
|
||||
"commitizen==4.18.0",
|
||||
"deprecated==1.3.1", # for commitizen
|
||||
|
||||
@@ -168,12 +170,19 @@ filterwarnings = [
|
||||
]
|
||||
|
||||
[tool.mypy]
|
||||
plugins = ["numpydantic.mypy", "pydantic.mypy"]
|
||||
mypy_path= "src"
|
||||
python_version = "3.13"
|
||||
platform = "linux"
|
||||
files = ["src", "tests"]
|
||||
exclude = "class_soc_calc\\.py$"
|
||||
check_untyped_defs = true
|
||||
warn_unused_ignores = true
|
||||
# Cached Pendulum analysis changes diagnostics between cold and warm runs with mypy 2.3.1.
|
||||
incremental = false
|
||||
|
||||
[tool.pydantic-mypy]
|
||||
init_typed = true
|
||||
|
||||
[[tool.mypy.overrides]]
|
||||
module = "akkudoktoreos.*"
|
||||
@@ -191,6 +200,12 @@ ignore_missing_imports = true
|
||||
module = "xprocess.*"
|
||||
ignore_missing_imports = true
|
||||
|
||||
# These dependencies do not publish complete PEP 561 typing information.
|
||||
# Keep their imports explicit; installed typed libraries and EOS code are checked.
|
||||
[[tool.mypy.overrides]]
|
||||
module = ["cachebox", "fasthtml.*", "monsterui.*", "pvlib.*", "statsmodels.*"]
|
||||
ignore_missing_imports = true
|
||||
|
||||
[tool.commitizen]
|
||||
# Only used as linter
|
||||
name = "cz_conventional_commits"
|
||||
|
||||
Reference in New Issue
Block a user