mirror of
https://github.com/Akkudoktor-EOS/EOS.git
synced 2026-09-11 10:26:38 +00:00
fix: unify mypy environments for local checks and CI (#1291)
The isolated pre-commit mypy hook previously omitted runtime type information that make mypy used, hiding errors involving dependencies such as Pydantic and Pendulum. Makefile, pre-commit and CI now run the same full-project typing policy in the development environment defined by uv.lock. - Use uv run --locked --exact --extra dev and the same mypy arguments for Makefile and the local hook. Check all of src and tests, including on configuration-only changes. - Pin Python 3.13 for local development and the pre-commit CI job, and install the locked pre-commit version in CI. - Disable incremental analysis because existing Pendulum cache state changes mypy 2.3.1 diagnostics. Document the policy, the performance tradeoff and the existing typing debt. - Add a regression test that exercises Makefile, the hook and the CI command in a temporary project, accepting valid dependency types and detecting deliberate Pydantic/Pendulum assignment errors. Resolve the newly detected mypy diagnostics. - Enable the numpydantic and Pydantic mypy plugins, retaining strict Pydantic constructor typing with init_typed = true. Validate raw/coercible payloads through model_validate. - Propagate concrete record, provider and time-window types through generic collections, factories and lookup methods. Preserve runtime field inspection and generated time-window documentation. - Align Pendulum annotations with actual factory/arithmetic results while retaining Pydantic validation adapters at runtime. Correct optional values, array boundaries, REST handlers and plotting interfaces. - Add pinned scipy-stubs and types-psutil, update uv.lock, and supply the plugins' dependencies. - Add runtime regression coverage for validated path defaults, normalized time-series metadata, generic field inspection, invalid timestamps and unsupported provider imports. Runtime and compatibility details: - Validate path defaults as Path objects while retaining raw string defaults needed by migration serialization with exclude_defaults. - Normalize feed-in tariff lists and default charge rates to NumPy arrays; reject missing timestamps/uninitialized values explicitly. Importing into a provider without import support returns HTTP 400. - Public JSON schemas and OpenAPI structure match main (excluding the generated version). Signed-off-by: dr-dimitry Signed-off-by: dr-dimitry Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com> Co-authored-by: dr-dimitri <87113560+dr-dimitri@users.noreply.github.com> Co-authored-by: Normann <github@koldrack.com>
This commit is contained in:
co-authored by
dr-dimitri
Normann
parent
5b584cbb57
commit
1abdd345c4
@@ -18,6 +18,7 @@ from typing import Any, AsyncIterator, Iterator, Literal, Optional, Type, cast
|
||||
import pytest
|
||||
import pytest_asyncio
|
||||
from numpydantic import NDArray, Shape
|
||||
from pendulum import UTC
|
||||
from pydantic import BaseModel, Field
|
||||
|
||||
from akkudoktoreos.core.databaseabc import (
|
||||
@@ -57,7 +58,7 @@ class SampleRecord(BaseModel):
|
||||
return self.value
|
||||
raise KeyError(key)
|
||||
|
||||
def model_dump(self) -> dict:
|
||||
def model_dump(self, **kwargs: Any) -> dict:
|
||||
return {"date_time": self.date_time, "value": self.value}
|
||||
|
||||
|
||||
@@ -303,7 +304,7 @@ class SampleSequence(DatabaseRecordProtocolMixin[SampleRecord]):
|
||||
if end_datetime is not None:
|
||||
resampled = resampled.truncate(after=end_datetime)
|
||||
|
||||
return resampled.values
|
||||
return resampled.to_numpy()
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
@@ -381,7 +382,7 @@ class TestDatabaseRecordProtocolMixin:
|
||||
self, seq, start_str, value_count, interval_seconds
|
||||
):
|
||||
start_dt = to_datetime(start_str, in_timezone="Europe/Berlin")
|
||||
assert start_dt.tz.name == "Europe/Berlin"
|
||||
assert start_dt.timezone_name == "Europe/Berlin"
|
||||
|
||||
db_start = DatabaseTimestamp.from_datetime(start_dt)
|
||||
generated = list(seq.db_generate_timestamps(db_start, value_count))
|
||||
@@ -390,7 +391,7 @@ class TestDatabaseRecordProtocolMixin:
|
||||
|
||||
for db_dt in generated:
|
||||
dt = DatabaseTimestamp.to_datetime(db_dt)
|
||||
assert dt.tz.name == "UTC"
|
||||
assert dt.timezone_name == "UTC"
|
||||
|
||||
assert len(generated) == len(set(generated)), "Duplicate UTC datetimes found"
|
||||
|
||||
@@ -1047,7 +1048,9 @@ class TestCompactDataIntegrity:
|
||||
interval_sec = 15 * 60
|
||||
expected_window_start = DateTime.fromtimestamp(
|
||||
(int(base.timestamp()) // interval_sec) * interval_sec,
|
||||
tz="UTC",
|
||||
tz=UTC,
|
||||
)
|
||||
assert compacted[0].date_time is not None
|
||||
assert compacted[-1].date_time is not None
|
||||
assert compacted[0].date_time >= expected_window_start
|
||||
assert compacted[-1].date_time < cutoff
|
||||
|
||||
Reference in New Issue
Block a user