mirror of
https://github.com/Akkudoktor-EOS/EOS.git
synced 2026-09-11 10:26:38 +00:00
fix: unify mypy environments for local checks and CI (#1291)
The isolated pre-commit mypy hook previously omitted runtime type information that make mypy used, hiding errors involving dependencies such as Pydantic and Pendulum. Makefile, pre-commit and CI now run the same full-project typing policy in the development environment defined by uv.lock. - Use uv run --locked --exact --extra dev and the same mypy arguments for Makefile and the local hook. Check all of src and tests, including on configuration-only changes. - Pin Python 3.13 for local development and the pre-commit CI job, and install the locked pre-commit version in CI. - Disable incremental analysis because existing Pendulum cache state changes mypy 2.3.1 diagnostics. Document the policy, the performance tradeoff and the existing typing debt. - Add a regression test that exercises Makefile, the hook and the CI command in a temporary project, accepting valid dependency types and detecting deliberate Pydantic/Pendulum assignment errors. Resolve the newly detected mypy diagnostics. - Enable the numpydantic and Pydantic mypy plugins, retaining strict Pydantic constructor typing with init_typed = true. Validate raw/coercible payloads through model_validate. - Propagate concrete record, provider and time-window types through generic collections, factories and lookup methods. Preserve runtime field inspection and generated time-window documentation. - Align Pendulum annotations with actual factory/arithmetic results while retaining Pydantic validation adapters at runtime. Correct optional values, array boundaries, REST handlers and plotting interfaces. - Add pinned scipy-stubs and types-psutil, update uv.lock, and supply the plugins' dependencies. - Add runtime regression coverage for validated path defaults, normalized time-series metadata, generic field inspection, invalid timestamps and unsupported provider imports. Runtime and compatibility details: - Validate path defaults as Path objects while retaining raw string defaults needed by migration serialization with exclude_defaults. - Normalize feed-in tariff lists and default charge rates to NumPy arrays; reject missing timestamps/uninitialized values explicitly. Importing into a provider without import support returns HTTP 400. - Public JSON schemas and OpenAPI structure match main (excluding the generated version). Signed-off-by: dr-dimitry Signed-off-by: dr-dimitry Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com> Co-authored-by: dr-dimitri <87113560+dr-dimitri@users.noreply.github.com> Co-authored-by: Normann <github@koldrack.com>
This commit is contained in:
co-authored by
dr-dimitri
Normann
parent
5b584cbb57
commit
1abdd345c4
@@ -18,7 +18,7 @@ def test_genetic0_params_german_input():
|
||||
"preis_euro_pro_wh_akku": 0.0001,
|
||||
"gesamtlast": [500.0, 600.0],
|
||||
}
|
||||
params = Genetic0EnergyManagementParameters(**data_de)
|
||||
params = Genetic0EnergyManagementParameters.model_validate(data_de)
|
||||
assert params.pv_forecast_wh == [100.0, 200.0]
|
||||
print("✅ German input accepted")
|
||||
|
||||
@@ -31,7 +31,7 @@ def test_genetic0_params_english_input():
|
||||
"price_per_wh_battery": 0.0001,
|
||||
"total_load": [500.0, 600.0],
|
||||
}
|
||||
params = Genetic0EnergyManagementParameters(**data_en)
|
||||
params = Genetic0EnergyManagementParameters.model_validate(data_en)
|
||||
assert params.pv_forecast_wh == [100.0, 200.0]
|
||||
print("✅ English input accepted")
|
||||
|
||||
@@ -44,7 +44,7 @@ def test_genetic0_params_english_output():
|
||||
"preis_euro_pro_wh_akku": 0.0001,
|
||||
"gesamtlast": [500.0, 600.0],
|
||||
}
|
||||
params = Genetic0EnergyManagementParameters(**data_de)
|
||||
params = Genetic0EnergyManagementParameters.model_validate(data_de)
|
||||
json_output = json.loads(params.model_dump_json(by_alias=True))
|
||||
|
||||
# English names should be in output
|
||||
@@ -84,7 +84,7 @@ def test_genetic0_simulation_result_translations():
|
||||
"akku_soc_pro_stunde": [80.0, 90.0],
|
||||
"Electricity_price": [0.0003, 0.0003],
|
||||
}
|
||||
result = Genetic0SimulationResult(**data_de)
|
||||
result = Genetic0SimulationResult.model_validate(data_de)
|
||||
json_output = json.loads(result.model_dump_json(by_alias=True))
|
||||
|
||||
# Check English field names in output
|
||||
@@ -140,12 +140,12 @@ def test_genetic0_optimization_parameters_device_translations():
|
||||
"preis_euro_pro_wh_akku": 0.0001,
|
||||
"gesamtlast": [500.0, 600.0],
|
||||
}
|
||||
params = Genetic0OptimizationParameters(
|
||||
params = Genetic0OptimizationParameters.model_validate(dict(
|
||||
ems=ems_de,
|
||||
pv_akku={"device_id": "battery1", "capacity_wh": 8000},
|
||||
inverter=None,
|
||||
eauto={"device_id": "ev1", "capacity_wh": 60000},
|
||||
)
|
||||
))
|
||||
# English attributes are populated from the German input names
|
||||
assert params.pv_battery is not None
|
||||
assert params.pv_battery.capacity_wh == 8000
|
||||
@@ -153,12 +153,12 @@ def test_genetic0_optimization_parameters_device_translations():
|
||||
assert params.ev.capacity_wh == 60000
|
||||
|
||||
# English input names work as well
|
||||
params_en = Genetic0OptimizationParameters(
|
||||
params_en = Genetic0OptimizationParameters.model_validate(dict(
|
||||
ems=ems_de,
|
||||
pv_battery={"device_id": "battery1", "capacity_wh": 8000},
|
||||
inverter=None,
|
||||
ev={"device_id": "ev1", "capacity_wh": 60000},
|
||||
)
|
||||
))
|
||||
assert params_en.pv_battery is not None
|
||||
assert params_en.ev is not None
|
||||
|
||||
|
||||
Reference in New Issue
Block a user