Mirrors/EOS
1
0
Fork 0
mirror of https://github.com/Akkudoktor-EOS/EOS.git synced 2026-10-13 01:21:58 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(dash): use reachable host in footer API docs link (#1354)

Browse Source 
link to EOS API using reachable host
This commit is contained in:
Normann
2026-09-26 16:54:27 +02:00
committed by GitHub
parent efab8cd0a0
commit 3d2daa694b
3 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/akkudoktoreos/server/dash/footer.py
+8 -3
View File
@@ -1,4 +1,5 @@
from typing import Optional, Union
from urllib.parse import urlunsplit
import requests
from loguru import logger
@@ -38,11 +39,15 @@ def get_alive(eos_host: str, eos_port: Union[str, int]) -> str:
return alive
def Footer(eos_host: Optional[str], eos_port: Optional[Union[str, int]]) -> str:
def Footer(eos_host: Optional[str], eos_port: Optional[Union[str, int]], request_host: str) -> str:
if eos_host is None:
eos_host = get_config().server.host
if eos_port is None:
eos_port = get_config().server.port
# A bind address is useful inside the container, but cannot be opened by a browser.
public_host = request_host if eos_host in ("0.0.0.0", "::") else eos_host # noqa: S104
url_host = f"[{public_host}]" if public_host and ":" in public_host else public_host
docs_url = urlunsplit(("http", f"{url_host}:{eos_port}", "/docs", "", ""))
alive_icon = None
if eos_host is None or eos_port is None:
alive = "EOS server not given: {eos_host}:{eos_port}"
@@ -55,7 +60,7 @@ def Footer(eos_host: Optional[str], eos_port: Optional[Union[str, int]]) -> str:
LoadingT.sm,
),
)
alive = f"EOS {eos_host}:{eos_port}"
alive = f"EOS {url_host}:{eos_port}"
if alive_icon:
alive_cls = f"{ButtonT.primary} uk-link rounded-md"
else:
@@ -63,7 +68,7 @@ def Footer(eos_host: Optional[str], eos_port: Optional[Union[str, int]]) -> str:
return DivFullySpaced(
P(
alive_icon,
A(alive, href=f"http://{eos_host}:{eos_port}/docs", target="_blank", cls=alive_cls),
A(alive, href=docs_url, target="_blank", cls=alive_cls),
),
P(
A(
src/akkudoktoreos/server/eosdash.py
+2 -2
View File
@@ -264,7 +264,7 @@ def get_eosdash(request: Request): # type: ignore
"About": "/eosdash/about",
},
About(),
Footer(*eos_server()),
Footer(*eos_server(), request.url.hostname or "localhost"),
"/eosdash/footer",
),
)
@@ -280,7 +280,7 @@ def get_eosdash_footer(request: Request): # type: ignore
Returns:
Footer: The Footer component.
"""
return Footer(*eos_server())
return Footer(*eos_server(), request.url.hostname or "localhost")
@app.get("/eosdash/about")