From 6743d8df4f9a5a0a139f6a848e9bef1d123c8a46 Mon Sep 17 00:00:00 2001 From: Normann Date: Sun, 26 Jan 2025 22:42:54 +0100 Subject: [PATCH] Info text for intentional errors Closes #416 (#422) * info before error * core.logging usage --- tests/test_elecpriceakkudoktor.py | 4 ++++ tests/test_pvforecastakkudoktor.py | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/tests/test_elecpriceakkudoktor.py b/tests/test_elecpriceakkudoktor.py index da4217a..fbbf90d 100644 --- a/tests/test_elecpriceakkudoktor.py +++ b/tests/test_elecpriceakkudoktor.py @@ -7,6 +7,7 @@ import pytest import requests from akkudoktoreos.core.ems import get_ems +from akkudoktoreos.core.logging import get_logger from akkudoktoreos.prediction.elecpriceakkudoktor import ( AkkudoktorElecPrice, AkkudoktorElecPriceValue, @@ -21,6 +22,8 @@ FILE_TESTDATA_ELECPRICEAKKUDOKTOR_1_JSON = DIR_TESTDATA.joinpath( "elecpriceforecast_akkudoktor_1.json" ) +logger = get_logger(__name__) + @pytest.fixture def provider(monkeypatch, config_eos): @@ -145,6 +148,7 @@ def test_update_data_with_incomplete_forecast(mock_get, provider): mock_response.status_code = 200 mock_response.content = json.dumps(incomplete_data) mock_get.return_value = mock_response + logger.info("The following errors are intentional and part of the test.") with pytest.raises(ValueError): provider._update_data(force_update=True) diff --git a/tests/test_pvforecastakkudoktor.py b/tests/test_pvforecastakkudoktor.py index 00956c0..45c3086 100644 --- a/tests/test_pvforecastakkudoktor.py +++ b/tests/test_pvforecastakkudoktor.py @@ -5,6 +5,7 @@ from unittest.mock import Mock, patch import pytest from akkudoktoreos.core.ems import get_ems +from akkudoktoreos.core.logging import get_logger from akkudoktoreos.prediction.prediction import get_prediction from akkudoktoreos.prediction.pvforecastakkudoktor import ( AkkudoktorForecastHorizon, @@ -20,6 +21,8 @@ DIR_TESTDATA = Path(__file__).absolute().parent.joinpath("testdata") FILE_TESTDATA_PV_FORECAST_INPUT_1 = DIR_TESTDATA.joinpath("pv_forecast_input_1.json") FILE_TESTDATA_PV_FORECAST_RESULT_1 = DIR_TESTDATA.joinpath("pv_forecast_result_1.txt") +logger = get_logger(__name__) + @pytest.fixture def sample_settings(config_eos): @@ -223,6 +226,7 @@ def test_pvforecast_akkudoktor_data_record(): def test_pvforecast_akkudoktor_validate_data(provider_empty_instance, sample_forecast_data_raw): """Test validation of PV forecast data on sample data.""" + logger.info("The following errors are intentional and part of the test.") with pytest.raises( ValueError, match="Field: meta\nError: Field required\nType: missing\nField: values\nError: Field required\nType: missing\n",