mirror of
https://github.com/Akkudoktor-EOS/EOS.git
synced 2026-08-31 20:56:41 +00:00
fix: bare except (#1159)
Bare `except:` catches SystemExit and KeyboardInterrupt, which can: - Mask Ctrl+C handling during long optimization runs - Hide critical system signals - Make debugging harder Replacement by `except Exception:` preserves the same error handling while respecting system-level exceptions. Co-authored-by: Milo @KeloYuan Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
This commit is contained in:
co-authored by
Milo @KeloYuan
parent
6933b33542
commit
8bf798daeb
@@ -146,7 +146,7 @@ class HomeAssistantAdapterCommonSettings(SettingsBaseModel):
|
||||
try:
|
||||
adapter_eos = get_adapter()
|
||||
result = adapter_eos.provider_by_id("HomeAssistant").get_homeassistant_entity_ids()
|
||||
except:
|
||||
except Exception:
|
||||
return []
|
||||
return result
|
||||
|
||||
@@ -157,7 +157,7 @@ class HomeAssistantAdapterCommonSettings(SettingsBaseModel):
|
||||
try:
|
||||
adapter_eos = get_adapter()
|
||||
result = adapter_eos.provider_by_id("HomeAssistant").get_eos_solution_entity_ids()
|
||||
except:
|
||||
except Exception:
|
||||
return []
|
||||
return result
|
||||
|
||||
@@ -170,7 +170,7 @@ class HomeAssistantAdapterCommonSettings(SettingsBaseModel):
|
||||
result = adapter_eos.provider_by_id(
|
||||
"HomeAssistant"
|
||||
).get_eos_device_instruction_entity_ids()
|
||||
except:
|
||||
except Exception:
|
||||
return []
|
||||
return result
|
||||
|
||||
@@ -256,7 +256,7 @@ class HomeAssistantAdapter(AdapterProvider):
|
||||
optimization_solution_keys = self.config.optimization.keys
|
||||
for key in sorted(optimization_solution_keys):
|
||||
solution_entity_ids.append(self._entity_id_from_solution_key(key))
|
||||
except:
|
||||
except Exception:
|
||||
solution_entity_ids = []
|
||||
return solution_entity_ids
|
||||
|
||||
|
||||
Reference in New Issue
Block a user