Fix EOSdash startup. (#394)

Revert to EOSdash startup as a sub-process.
Add arguments to control the complete startup of both servers.
Also development reload can now be given as an argument.

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>

src/akkudoktoreos/server/eosdash.py

@@ -1,3 +1,5 @@
+import argparse
+
 import uvicorn
 from fasthtml.common import H1, FastHTML, Table, Td, Th, Thead, Titled, Tr
 
@@ -8,6 +10,8 @@ logger = get_logger(__name__)
 
 config_eos = get_config()
 
+# Command line arguments
+args = None
 
 configs = []
 for field_name in config_eos.model_fields:
@@ -44,15 +48,118 @@ def get():  # type: ignore
     return Titled("EOS Dashboard", H1("Configuration"), config_table())
 
 
-if __name__ == "__main__":
+def run_eosdash(host: str, port: int, log_level: str, access_log: bool, reload: bool) -> None:
+    """Run the EOSdash server with the specified configurations.
+
+    This function starts the EOSdash server using the Uvicorn ASGI server. It accepts
+    arguments for the host, port, log level, access log, and reload options. The
+    log level is converted to lowercase to ensure compatibility with Uvicorn's
+    expected log level format. If an error occurs while attempting to bind the
+    server to the specified host and port, an error message is logged and the
+    application exits.
+
+    Parameters:
+    host (str): The hostname to bind the server to.
+    port (int): The port number to bind the server to.
+    log_level (str): The log level for the server. Options include "critical", "error",
+                     "warning", "info", "debug", and "trace".
+    access_log (bool): Whether to enable or disable the access log. Set to True to enable.
+    reload (bool): Whether to enable or disable auto-reload. Set to True for development.
+
+    Returns:
+    None
+    """
+    # Make hostname human (and Windows) friendly
+    if host == "0.0.0.0":
+        host = "localhost"
     try:
-        logger.info(f"Starting {config_eos.server_eosdash_host}:{config_eos.server_eosdash_port}.")
         uvicorn.run(
-            app, host=str(config_eos.server_eosdash_host), port=config_eos.server_eosdash_port
+            "akkudoktoreos.server.eosdash:app",
+            host=host,
+            port=port,
+            log_level=log_level.lower(),  # Convert log_level to lowercase
+            access_log=access_log,
+            reload=reload,
         )
     except Exception as e:
-        # Error handling for binding issues
-        logger.error(
-            f"Could not bind to host {config_eos.server_eosdash_host}:{config_eos.server_eosdash_port}. Error: {e}"
-        )
+        logger.error(f"Could not bind to host {host}:{port}. Error: {e}")
+        raise e
+
+
+def main() -> None:
+    """Parse command-line arguments and start the EOSdash server with the specified options.
+
+    This function sets up the argument parser to accept command-line arguments for
+    host, port, log_level, access_log, and reload. It uses default values from the
+    config_eos module if arguments are not provided. After parsing the arguments,
+    it starts the EOSdash server with the specified configurations.
+
+    Command-line Arguments:
+    --host (str): Host for the EOSdash server (default: value from config_eos).
+    --port (int): Port for the EOSdash server (default: value from config_eos).
+    --eos-host (str): Host for the EOS server (default: value from config_eos).
+    --eos-port (int): Port for the EOS server (default: value from config_eos).
+    --log_level (str): Log level for the server. Options: "critical", "error", "warning", "info", "debug", "trace" (default: "info").
+    --access_log (bool): Enable or disable access log. Options: True or False (default: False).
+    --reload (bool): Enable or disable auto-reload. Useful for development. Options: True or False (default: False).
+    """
+    parser = argparse.ArgumentParser(description="Start EOSdash server.")
+
+    # Host and port arguments with defaults from config_eos
+    parser.add_argument(
+        "--host",
+        type=str,
+        default=str(config_eos.server_eosdash_host),
+        help="Host for the EOSdash server (default: value from config_eos)",
+    )
+    parser.add_argument(
+        "--port",
+        type=int,
+        default=config_eos.server_eosdash_port,
+        help="Port for the EOSdash server (default: value from config_eos)",
+    )
+
+    # EOS Host and port arguments with defaults from config_eos
+    parser.add_argument(
+        "--eos-host",
+        type=str,
+        default=str(config_eos.server_eos_host),
+        help="Host for the EOS server (default: value from config_eos)",
+    )
+    parser.add_argument(
+        "--eos-port",
+        type=int,
+        default=config_eos.server_eos_port,
+        help="Port for the EOS server (default: value from config_eos)",
+    )
+
+    # Optional arguments for log_level, access_log, and reload
+    parser.add_argument(
+        "--log_level",
+        type=str,
+        default="info",
+        help='Log level for the server. Options: "critical", "error", "warning", "info", "debug", "trace" (default: "info")',
+    )
+    parser.add_argument(
+        "--access_log",
+        type=bool,
+        default=False,
+        help="Enable or disable access log. Options: True or False (default: True)",
+    )
+    parser.add_argument(
+        "--reload",
+        type=bool,
+        default=False,
+        help="Enable or disable auto-reload. Useful for development. Options: True or False (default: False)",
+    )
+
+    args = parser.parse_args()
+
+    try:
+        run_eosdash(args.host, args.port, args.log_level, args.access_log, args.reload)
+    except:
         exit(1)
+
+
+if __name__ == "__main__":
+    main()