mirror of
https://github.com/Akkudoktor-EOS/EOS.git
synced 2026-10-08 23:46:38 +00:00
The optimizer treated the end of `optimization.horizon_hours` as the end of the world: energy left in the battery there was worth a single configured price per kWh, so it either dumped the battery into the last hours or hoarded it, depending on that one number. The horizon is now two spans. `horizon_hours` still receives every control command. The new `optimization.tail_horizon_hours` (default 48 h) is a pure lookahead that never produces a command. In AUTO terminal-value mode a deterministic dynamic program solves that tail backwards on a 101-point SoC grid using the production battery and inverter models - SoC bounds, power caps, conversion losses, configured charge and export rates, direct-marketing permission and LCOS on delivered DC energy - and the existing AUTO proxy supplies the continuation value at the tail end. Genetic fitness reads the resulting curve. `tail_horizon_hours: 0` restores the plain proxy at the control end, FIXED is unchanged. The forecast budget is reported, never enforced by refusal: a tail that does not fit is shortened to what the forecast covers and reported as `effective_tail_hours`, and a control horizon that does not fit is warned about at configuration time and rejected by the optimizer at run time, which knows which series ran out. `prediction.hours` defaults to 72 so the new defaults fit out of the box; existing shorter configurations keep starting. Control arrays and warm-start genomes now begin at the run timestamp rather than midnight, flagged by `controls_start_at_now` so the adapters still read older solutions. `forecast_interval_seconds` declares the resolution of shortened native quarter-hour inputs. Required forecasts are no longer silently replaced by demo providers. A missing PV, price, load, feed-in or weather forecast used to rewrite the configured provider and retry, so a run could quietly optimize against invented data. Missing values now stay missing, and provider values are held only within their own source interval instead of being extended indefinitely. Also fixes a config update that could leave EOS half-updated: the merged candidate is validated before the singleton is reinitialized. Four provider tests that hard-coded the old 48 h prediction default are rewritten to derive their expectations from the configured horizon.
224 lines
7.4 KiB
Python
224 lines
7.4 KiB
Python
import json
|
|
from pathlib import Path
|
|
from unittest.mock import Mock, patch
|
|
|
|
import numpy as np
|
|
import pytest
|
|
import requests
|
|
from loguru import logger
|
|
|
|
from akkudoktoreos.core.cache import CacheFileStore
|
|
from akkudoktoreos.core.coreabc import get_ems
|
|
from akkudoktoreos.prediction.elecpriceakkudoktor import (
|
|
AkkudoktorElecPrice,
|
|
AkkudoktorElecPriceValue,
|
|
ElecPriceAkkudoktor,
|
|
)
|
|
from akkudoktoreos.utils.datetimeutil import to_datetime
|
|
|
|
DIR_TESTDATA = Path(__file__).absolute().parent.joinpath("testdata")
|
|
|
|
FILE_TESTDATA_ELECPRICEAKKUDOKTOR_1_JSON = DIR_TESTDATA.joinpath(
|
|
"elecpriceforecast_akkudoktor_1.json"
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def provider(monkeypatch, config_eos):
|
|
"""Fixture to create a ElecPriceProvider instance."""
|
|
monkeypatch.setenv("EOS_ELECPRICE__ELECPRICE_PROVIDER", "ElecPriceAkkudoktor")
|
|
config_eos.reset_settings()
|
|
return ElecPriceAkkudoktor()
|
|
|
|
|
|
@pytest.fixture
|
|
def sample_akkudoktor_1_json():
|
|
"""Fixture that returns sample forecast data report."""
|
|
with FILE_TESTDATA_ELECPRICEAKKUDOKTOR_1_JSON.open(
|
|
"r", encoding="utf-8", newline=None
|
|
) as f_res:
|
|
input_data = json.load(f_res)
|
|
return input_data
|
|
|
|
|
|
@pytest.fixture
|
|
def cache_store():
|
|
"""A pytest fixture that creates a new CacheFileStore instance for testing."""
|
|
return CacheFileStore()
|
|
|
|
|
|
# ------------------------------------------------
|
|
# General forecast
|
|
# ------------------------------------------------
|
|
|
|
|
|
def test_singleton_instance(provider):
|
|
"""Test that ElecPriceForecast behaves as a singleton."""
|
|
another_instance = ElecPriceAkkudoktor()
|
|
assert provider is another_instance
|
|
|
|
|
|
def test_invalid_provider(provider, monkeypatch):
|
|
"""Test requesting an unsupported provider."""
|
|
monkeypatch.setenv("EOS_ELECPRICE__ELECPRICE_PROVIDER", "<invalid>")
|
|
provider.config.reset_settings()
|
|
assert not provider.enabled()
|
|
|
|
|
|
# ------------------------------------------------
|
|
# Akkudoktor
|
|
# ------------------------------------------------
|
|
|
|
|
|
@patch("akkudoktoreos.prediction.elecpriceakkudoktor.logger.error")
|
|
def test_validate_data_invalid_format(mock_logger, provider):
|
|
"""Test validation for invalid Akkudoktor data."""
|
|
invalid_data = '{"invalid": "data"}'
|
|
with pytest.raises(ValueError):
|
|
provider._validate_data(invalid_data)
|
|
mock_logger.assert_called_once_with(mock_logger.call_args[0][0])
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_request_forecast(mock_get, provider, sample_akkudoktor_1_json):
|
|
"""Test requesting forecast from Akkudoktor."""
|
|
# Mock response object
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
mock_response.content = json.dumps(sample_akkudoktor_1_json)
|
|
mock_get.return_value = mock_response
|
|
|
|
# Test function
|
|
akkudoktor_data = provider._request_forecast()
|
|
|
|
assert isinstance(akkudoktor_data, AkkudoktorElecPrice)
|
|
assert akkudoktor_data.values[0].model_dump() == AkkudoktorElecPriceValue(
|
|
start_timestamp=1733785200000,
|
|
end_timestamp=1733788800000,
|
|
start="2024-12-09T23:00:00.000Z",
|
|
end="2024-12-10T00:00:00.000Z",
|
|
marketprice=92.85,
|
|
unit="Eur/MWh",
|
|
marketpriceEurocentPerKWh=9.29,
|
|
).model_dump()
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_update_data(mock_get, provider, sample_akkudoktor_1_json, cache_store):
|
|
"""Test fetching forecast from Akkudoktor."""
|
|
# Mock response object
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
mock_response.content = json.dumps(sample_akkudoktor_1_json)
|
|
mock_get.return_value = mock_response
|
|
|
|
cache_store.clear(clear_all=True)
|
|
|
|
# Call the method
|
|
ems_eos = get_ems()
|
|
ems_eos.set_start_datetime(to_datetime("2024-12-11 00:00:00", in_timezone="Europe/Berlin"))
|
|
provider.update_data(force_enable=True, force_update=True)
|
|
|
|
# Assert: Verify the result is as expected
|
|
mock_get.assert_called_once()
|
|
# The API response holds 48 datasets, 23 h of which already reach into the
|
|
# future, so the provider forecasts the remaining hours of the horizon itself.
|
|
assert len(provider) == 48 + provider.config.prediction.hours - 23
|
|
|
|
# Assert we get hours prioce values by resampling
|
|
np_price_array = provider.key_to_array(
|
|
key="elecprice_marketprice_wh",
|
|
start_datetime=provider.ems_start_datetime,
|
|
end_datetime=provider.end_datetime,
|
|
)
|
|
assert len(np_price_array) == provider.total_hours
|
|
|
|
# with open(FILE_TESTDATA_ELECPRICEAKKUDOKTOR_2_JSON, "w") as f_out:
|
|
# f_out.write(provider.to_json())
|
|
|
|
|
|
@patch("requests.get")
|
|
def test_update_data_with_incomplete_forecast(mock_get, provider):
|
|
"""Test `_update_data` with incomplete or missing forecast data."""
|
|
incomplete_data: dict = {"meta": {}, "values": []}
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
mock_response.content = json.dumps(incomplete_data)
|
|
mock_get.return_value = mock_response
|
|
logger.info("The following errors are intentional and part of the test.")
|
|
with pytest.raises(ValueError):
|
|
provider._update_data(force_update=True)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"status_code, exception",
|
|
[(400, requests.exceptions.HTTPError), (500, requests.exceptions.HTTPError), (200, None)],
|
|
)
|
|
@patch("requests.get")
|
|
def test_request_forecast_status_codes(
|
|
mock_get, provider, sample_akkudoktor_1_json, status_code, exception
|
|
):
|
|
"""Test handling of various API status codes."""
|
|
mock_response = Mock()
|
|
mock_response.status_code = status_code
|
|
mock_response.content = json.dumps(sample_akkudoktor_1_json)
|
|
mock_response.raise_for_status.side_effect = (
|
|
requests.exceptions.HTTPError if exception else None
|
|
)
|
|
mock_get.return_value = mock_response
|
|
if exception:
|
|
with pytest.raises(exception):
|
|
provider._request_forecast()
|
|
else:
|
|
provider._request_forecast()
|
|
|
|
|
|
@patch("requests.get")
|
|
@patch("akkudoktoreos.core.cache.CacheFileStore")
|
|
def test_cache_integration(mock_cache, mock_get, provider, sample_akkudoktor_1_json):
|
|
"""Test caching of 8-day electricity price data."""
|
|
# Mock response object
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
mock_response.content = json.dumps(sample_akkudoktor_1_json)
|
|
mock_get.return_value = mock_response
|
|
|
|
# Mock cache object
|
|
mock_cache_instance = mock_cache.return_value
|
|
mock_cache_instance.get.return_value = None # Simulate no cache
|
|
|
|
provider._update_data(force_update=True)
|
|
mock_cache_instance.create.assert_called_once()
|
|
mock_cache_instance.get.assert_called_once()
|
|
|
|
|
|
def test_key_to_array_resampling(provider):
|
|
"""Test resampling of forecast data to NumPy array."""
|
|
provider.update_data(force_update=True)
|
|
array = provider.key_to_array(
|
|
key="elecprice_marketprice_wh",
|
|
start_datetime=provider.ems_start_datetime,
|
|
end_datetime=provider.end_datetime,
|
|
)
|
|
assert isinstance(array, np.ndarray)
|
|
assert len(array) == provider.total_hours
|
|
|
|
|
|
# ------------------------------------------------
|
|
# Development Akkudoktor
|
|
# ------------------------------------------------
|
|
|
|
|
|
@pytest.mark.skip(reason="For development only")
|
|
def test_akkudoktor_development_forecast_data(provider):
|
|
"""Fetch data from real Akkudoktor server."""
|
|
# Preset, as this is usually done by update_data()
|
|
provider.ems_start_datetime = to_datetime("2024-10-26 00:00:00")
|
|
|
|
akkudoktor_data = provider._request_forecast()
|
|
|
|
with FILE_TESTDATA_ELECPRICEAKKUDOKTOR_1_JSON.open(
|
|
"w", encoding="utf-8", newline="\n"
|
|
) as f_out:
|
|
json.dump(akkudoktor_data, f_out, indent=4)
|