Mirrors/MeshCore-Solo
1
0
Fork 0
mirror of https://github.com/MarekZegare4/MeshCore-Solo.git synced 2026-11-03 03:11:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(l2): heavy screens build in pieces over several loop passes

Browse Source 
The list fill becomes a small job queue (fill/then/fillStart, fillTick with a
25 ms budget per pass). Settings pages build section by section in
schemaRows, with the trailing extras (melodies, prune, quick messages) queued
after them so the order stays; Radio and Repeater build by group, Admin's
repeater pick like the contact list, Diag's Live tab by section. Rebuilds
that restore the scroll flush the queue first. Screens went from 220-360 ms
to 80-175 ms (build + first frame).

Diag's crash line read the core dump in flash every second (~44 ms each);
it is read once now. The perf run times every page and dismisses the USB
popup, which had covered all earlier measurements.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Jakub
2026-09-30 08:53:15 +02:00
co-authored by Claude Opus 5.5
parent 34f739c45b
commit 039485bf34
8 changed files with 205 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/companion_radio/ui-lvgl/DiagScreen.h
+25 -17
View File
@@ -87,6 +87,7 @@ static void showValue(const char* core, const char* v, char* out, size_t n) {
static void setLive(int i, const diag::Row& r) {
LiveVal& lv = s_vals[i];
if (!lv.in && !lv.val) return; // its section isn't built yet (fill)
if (lv.in) {
const char* slash = strchr(r.value, '/');
char a[12];
@@ -260,25 +261,11 @@ void UITask::buildDiag() {
s_rows = 0;
if (s_tab == TAB_LIVE) {
// Section by section, in ui-core's order within each.
// Section by section, the first at once, the others as the loop goes (fill).
diag::Row rows[diag::MAX_ROWS + EXTRA];
s_rows = allRows(rows, _core->gpsEnabled());
for (uint8_t sec = 0; sec < SEC_COUNT; sec++) {
lv_obj_t* card = nullptr;
for (int i = 0; i < s_rows; i++) {
const Name* nm = nameOf(rows[i].label);
if ((nm ? nm->sec : SEC_DEVICE) != sec) continue;
if (!card) {
sectionTitle(s_list, SEC_TITLE[sec]);
card = infoCard(s_list);
if (sec == SEC_PACKETS) { lv_obj_t *a, *b; pairLine(card, "", &a, &b, true); }
}
s_vals[i] = { nullptr, nullptr, nullptr };
if (nm && nm->pair) pairLine(card, nm->text, &s_vals[i].in, &s_vals[i].out, false);
else s_vals[i].val = infoRow(card, nm ? nm->text : rows[i].label, "");
setLive(i, rows[i]);
}
}
for (int i = 0; i < s_rows; i++) s_vals[i] = { nullptr, nullptr, nullptr };
fillStart(SEC_COUNT, 1, &UITask::diagSection);
return;
}
@@ -351,6 +338,27 @@ void UITask::buildDiag() {
}
// From loop(), once a second: the Live values in place.
// One Live section, in ui-core's order within it.
void UITask::diagSection(int sec) {
using namespace diagview;
diag::Row rows[diag::MAX_ROWS + EXTRA];
int n = allRows(rows, _core->gpsEnabled());
if (n != s_rows) return; // changed meanwhile: refreshDiag() builds it again
lv_obj_t* card = nullptr;
for (int i = 0; i < n; i++) {
const Name* nm = nameOf(rows[i].label);
if ((nm ? nm->sec : SEC_DEVICE) != sec) continue;
if (!card) {
sectionTitle(s_list, SEC_TITLE[sec]);
card = infoCard(s_list);
if (sec == SEC_PACKETS) { lv_obj_t *a, *b; pairLine(card, "", &a, &b, true); }
}
if (nm && nm->pair) pairLine(card, nm->text, &s_vals[i].in, &s_vals[i].out, false);
else s_vals[i].val = infoRow(card, nm ? nm->text : rows[i].label, "");
setLive(i, rows[i]);
}
}
void UITask::refreshDiag() {
using namespace diagview;
if (_screen != SCR_DIAG || s_tab != TAB_LIVE || _nav_overlay) return;