Mirrors/MeshCore-Solo
1
0
Fork 0
mirror of https://github.com/MarekZegare4/MeshCore-Solo.git synced 2026-09-14 15:16:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ui): page the fullscreen message view in reading order

Browse Source 
LEFT went to the newer message and RIGHT to the older one, which reads
backwards against the page metaphor the "<" / ">" markers set up. Swap it:
LEFT turns back to the older message, RIGHT forward to the newer one, and
the markers follow (they were keyed to the opposite flags).

PREV/NEXT are named in message order, not screen order -- MessagesScreen's
_hist_sel counts newest-first, so PREV is the older message -- so only the
key mapping and the two marker conditions change; the caller side is
untouched. Applies to both the DM and channel fullscreen views, which share
handleInput(). AdminScreen's reply view treats every non-NONE result as
"close", so it is unaffected.

Docs and release notes updated to match.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Jakub
2026-08-24 12:13:41 +02:00
co-authored by Claude Opus 5
parent 51c06b78c1
commit 13fb4a189f
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/companion_radio/ui-new/FullscreenMsgView.h
+10 -4
View File
@@ -157,12 +157,14 @@ struct FullscreenMsgView {
display.print(s_wrap_lines[scroll + i]);
}
drawScrollIndicator(display, startY, visible * lineH, lcount, visible, scroll);
// Page markers read like a book: the older message is back to the left,
// the newer one forward to the right (see handleInput).
const int nav_y = display.height() - lineH;
if (has_next) {
if (has_prev) {
display.setCursor(0, nav_y);
display.print("<");
}
if (has_prev) {
if (has_next) {
display.setCursor(display.width() - cw, nav_y);
display.print(">");
}
@@ -172,8 +174,12 @@ struct FullscreenMsgView {
Result handleInput(char c) {
if (c == KEY_UP) { if (scroll > 0) scroll--; return NONE; }
if (c == KEY_DOWN) { if (scroll < _max_scroll) scroll++; return NONE; }
if (keyIsPrev(c)) return NEXT; // page between messages (encoder too)
if (keyIsNext(c)) return PREV;
// Page between messages (encoder too), in reading order: left goes back to
// the older message, right forward to the newer one. PREV/NEXT are named in
// message order, and MessagesScreen's _hist_sel counts newest-first, so PREV
// (older) is what a left press means.
if (keyIsPrev(c)) return PREV;
if (keyIsNext(c)) return NEXT;
if (c == KEY_CONTEXT_MENU) return REPLY;
if (c == KEY_ENTER || c == KEY_CANCEL) return CLOSE;
return NONE;