Mirrors/MeshCore-Solo
1
0
Fork 0
mirror of https://github.com/MarekZegare4/MeshCore-Solo.git synced 2026-08-04 03:06:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(companion): digit-by-digit Freq editor, scroll-indicator halo cleanup, channel-unread fix

Browse Source 
- New DigitEditor.h: standalone, reusable LEFT/RIGHT-cursor + UP/DOWN-spin
  numeric editor. Replaces Freq's fixed ±0.025MHz nudge, which carried each
  preset's own fractional offset forever, landing on a different unpredictable
  grid depending which preset you started from. Every digit (hundreds down to
  thousandths) is now directly addressable. SF/BW/CR are unchanged (small
  discrete sets, plain left/right cycling is fine there).
- icons.h: drop the scroll-indicator's DARK contrast halo. Every caller
  already keeps its selection bar clear of the indicator column (reserve/
  _reserve), so the halo was never actually needed for contrast — and the
  bottom arrow's halo had no clip symmetric to the top one, so it bled 1px
  into the popup's bottom border.
- QuickMsgScreen.h: updateChannelUnread() now marks everything in the
  rendered visible window as read, not just the highlighted row — a taller
  screen that fits more message boxes at once should mark more read up
  front. Also drops a premature call at CHANNEL_HIST entry that ran before
  the channel's own render() had computed _hist_visible, which could ratchet
  _viewing_max_seen past what was actually shown (that field is shared with
  DM_HIST and stale until this channel's first render).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jakub
2026-06-18 20:04:37 +02:00
co-authored by Claude Sonnet 4.6
parent 243a11e6bc
commit 601606faa8
4 changed files with 137 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/companion_radio/ui-new/QuickMsgScreen.h
+12 -3
View File
@@ -778,9 +778,14 @@ public:
}
void updateChannelUnread() {
if (_hist_sel < 0 || _sel_channel_idx < 0 || _sel_channel_idx >= MAX_GROUP_CHANNELS) return;
if (_hist_sel > _viewing_max_seen) _viewing_max_seen = _hist_sel;
if (_sel_channel_idx < 0 || _sel_channel_idx >= MAX_GROUP_CHANNELS) return;
// histEntryForChannel is newest-first: index 0 = newest (unread), higher = older.
// Count everything actually rendered on screen as seen — not just the
// highlighted row — so a taller screen that fits more boxes at once marks
// more read up front, instead of requiring a press per row.
int seen_to = _hist_scroll + _hist_visible - 1;
if (_hist_sel > seen_to) seen_to = _hist_sel;
if (seen_to > _viewing_max_seen) _viewing_max_seen = seen_to;
// Each step down from 0 sees one more message; seen count = max_seen + 1.
int remaining = _unread_at_entry - (_viewing_max_seen + 1);
_ch_unread[_sel_channel_idx] = (uint8_t)(remaining > 0 ? remaining : 0);
@@ -1182,6 +1187,7 @@ public:
}
}
_hist_visible = n_vis;
updateChannelUnread(); // mark everything in the just-computed visible window as seen
for (int i = 0; i < n_vis && (_hist_scroll + i) < ch_hist_count; i++) {
int item = _hist_scroll + i;
@@ -1555,7 +1561,10 @@ public:
_hist_sel = hc > 0 ? 0 : -1;
_viewing_max_seen = _hist_sel >= 0 ? _hist_sel : 0;
_phase = CHANNEL_HIST;
updateChannelUnread();
// Not updateChannelUnread() here: _hist_visible is still whatever this
// channel's first render() hasn't computed yet (stale, shared with
// DM_HIST) — calling it now could ratchet _viewing_max_seen past what's
// actually about to be shown. render() calls it once that's fresh.
if (_share_mode) beginShareCompose(true);
return true;
}