Mirrors/MeshCore-Solo
1
0
Fork 0
mirror of https://github.com/MarekZegare4/MeshCore-Solo.git synced 2026-07-26 14:58:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ui): full e-ink refresh on screen change + prune gone favourites

Browse Source 
Two UI quick wins from the 2026-07-05 review:

- E-ink: force a full (non-partial) refresh on the first frame of a new
  screen. Inter-screen ghosting was the most visible cheap win — the
  N-partials interval alone doesn't catch navigation. New
  DisplayDriver::forceFullRefresh() (no-op on OLED), set in setCurrScreen()
  and consumed by GxEPDDisplay::endFrame().

- Favourites: clear a stale "(gone)" tile at render time so it reverts to an
  empty "+" slot. Happens when prefs outlive the contact list (e.g. a wiped
  /contacts3); onContactRemoved only catches a live delete. Pruned slots are
  persisted once per pass (self-healing — an emptied slot can't re-fire).

Builds green: WioTrackerL1_companion_solo_dual (OLED),
WioTrackerL1Eink_companion_solo_dual (e-ink).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Jakub
2026-07-05 22:40:14 +02:00
parent 4ae3d22654
commit 638eea7bb0
4 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
examples/companion_radio/ui-new/UITask.cpp
View File

@@ -1192,6 +1192,7 @@ public:
if (_fav_sel >= NodePrefs::FAVOURITES_COUNT) _fav_sel = 0;
bool fav_changed = false; // a stale (gone) slot was pruned this pass → persist once after the loop
for (uint8_t i = 0; i < NodePrefs::FAVOURITES_COUNT; i++) {
int row = i / cols;
int col = i % cols;
@@ -1218,9 +1219,21 @@ public:
ci = c; found = true; break;
}
}
if (!found) {
// Pinned contact is gone — prefs outlived the contact list (e.g. a
// wiped /contacts3; onContactRemoved only catches a live delete).
// Clear the stale slot at render time so it reverts to an empty "+"
// tile instead of showing "(gone)". Persisted once after the loop.
if (_node_prefs)
memset(_node_prefs->favourite_contacts[i], 0, NodePrefs::FAVOURITE_PREFIX_LEN);
fav_changed = true;
int plus_y = cy + (cell_h - line_h) / 2;
display.drawTextCentered(cx + cell_w / 2, plus_y, "+");
if (sel) display.setColor(DisplayDriver::LIGHT);
continue;
}
char name[24];
if (found) display.translateUTF8ToBlocks(name, ci.name, sizeof(name));
else strncpy(name, "(gone)", sizeof(name) - 1), name[sizeof(name) - 1] = '\0';
display.translateUTF8ToBlocks(name, ci.name, sizeof(name));
// Reserve space for the unread badge so the name's ellipsis lands
// before it instead of underneath. Badge and name share one baseline.
@@ -1247,6 +1260,10 @@ public:
}
if (sel) display.setColor(DisplayDriver::LIGHT);
}
// Persist any pruned slots once, outside the loop — a render pass can clear
// several gone tiles but only one flash write is needed. Self-healing: once
// cleared, the slot is empty next frame so this can't re-fire per frame.
if (fav_changed) the_mesh.savePrefs();
if (_pin_menu.active) _pin_menu.render(display);
} else if (_page == HomePage::SHUTDOWN) {
display.setColor(DisplayDriver::LIGHT);
@@ -1910,6 +1927,10 @@ void UITask::setCurrScreen(UIScreen* c) {
// that mistake is an inert no-op instead of a null deref in render()/poll().
if (!c) return;
curr = c;
// E-ink: force a full refresh on the first frame of the new screen so leftover
// ghosting from the previous screen is cleared (the N-partials interval alone
// doesn't catch navigation). No-op on OLED.
if (_display) _display->forceFullRefresh();
c->onShow(); // central per-visit reset hook (see UIScreen::onShow)
_next_refresh = 100;
}