354 lines
9.8 KiB
Bash
Raw Normal View History

2025-04-03 14:39:33 +02:00
#!/bin/bash
# ==========================================================
# ProxMenu - A menu-driven script for Proxmox VE management
# ==========================================================
# Author : MacRimi
# Copyright : (c) 2024 MacRimi
# License : MIT (https://raw.githubusercontent.com/MacRimi/ProxMenux/main/LICENSE)
# Version : 1.0
# Last Updated: 28/01/2025
# ==========================================================
# Description:
# This script allows users to assign physical disks to existing
# Proxmox virtual machines (VMs) through an interactive menu.
# - Detects the system disk and excludes it from selection.
# - Lists all available VMs for the user to choose from.
# - Identifies and displays unassigned physical disks.
# - Allows the user to select multiple disks and attach them to a VM.
# - Supports interface types: SATA, SCSI, VirtIO, and IDE.
# - Ensures that disks are not already assigned to active VMs.
# - Warns about disk sharing between multiple VMs to avoid data corruption.
# - Configures the selected disks for the VM and verifies the assignment.
#
# The goal of this script is to simplify the process of assigning
# physical disks to Proxmox VMs, reducing manual configurations
# and preventing potential errors.
# ==========================================================
# Configuration ============================================
REPO_URL="https://raw.githubusercontent.com/MacRimi/ProxMenux/main"
BASE_DIR="/usr/local/share/proxmenux"
UTILS_FILE="$BASE_DIR/utils.sh"
VENV_PATH="/opt/googletrans-env"
if [[ -f "$UTILS_FILE" ]]; then
source "$UTILS_FILE"
fi
load_language
initialize_cache
# ==========================================================
# Function to get detailed disk information
get_disk_info() {
local disk=$1
MODEL=$(lsblk -dn -o MODEL "$disk" | xargs)
SIZE=$(lsblk -dn -o SIZE "$disk" | xargs)
echo "$MODEL" "$SIZE"
}
# Display list of available VMs
VM_LIST=$(qm list | awk 'NR>1 {print $1, $2}')
if [ -z "$VM_LIST" ]; then
whiptail --title "$(translate "Error")" --msgbox "$(translate "No VMs available in the system.")" 8 40
exit 1
fi
# Select VM
VMID=$(whiptail --title "$(translate "Select VM")" --menu "$(translate "Select the VM to which you want to add disks:")" 15 60 8 $VM_LIST 3>&1 1>&2 2>&3)
if [ -z "$VMID" ]; then
whiptail --title "$(translate "Error")" --msgbox "$(translate "No VM was selected.")" 8 40
exit 1
fi
VMID=$(echo "$VMID" | tr -d '"')
2025-04-03 19:43:56 +02:00
#clear
2025-04-03 14:39:33 +02:00
msg_ok "$(translate "VM selected successfully.")"
VM_STATUS=$(qm status "$VMID" | awk '{print $2}')
if [ "$VM_STATUS" == "running" ]; then
whiptail --title "$(translate "Warning")" --msgbox "$(translate "The VM is powered on. Turn it off before adding disks.")" 12 60
exit 1
fi
##########################################
msg_info "$(translate "Detecting available disks...")"
USED_DISKS=$(lsblk -n -o PKNAME,TYPE | grep 'lvm' | awk '{print "/dev/" $1}')
MOUNTED_DISKS=$(lsblk -ln -o NAME,MOUNTPOINT | awk '$2!="" {print "/dev/" $1}')
ZFS_DISKS=""
ZFS_RAW=$(zpool list -v -H 2>/dev/null | awk '{print $1}' | grep -v '^NAME$' | grep -v '^-' | grep -v '^mirror')
for entry in $ZFS_RAW; do
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
path=""
if [[ "$entry" == wwn-* || "$entry" == ata-* ]]; then
if [ -e "/dev/disk/by-id/$entry" ]; then
path=$(readlink -f "/dev/disk/by-id/$entry")
fi
elif [[ "$entry" == /dev/* ]]; then
path="$entry"
fi
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
if [ -n "$path" ]; then
base_disk=$(lsblk -no PKNAME "$path" 2>/dev/null)
if [ -n "$base_disk" ]; then
ZFS_DISKS+="/dev/$base_disk"$'\n'
fi
fi
done
ZFS_DISKS=$(echo "$ZFS_DISKS" | sort -u)
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
is_disk_in_use() {
local disk="$1"
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
while read -r part fstype; do
case "$fstype" in
zfs_member|linux_raid_member)
return 0 ;;
esac
if echo "$MOUNTED_DISKS" | grep -q "/dev/$part"; then
return 0
fi
done < <(lsblk -ln -o NAME,FSTYPE "$disk" | tail -n +2)
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
if echo "$USED_DISKS" | grep -q "$disk" || echo "$ZFS_DISKS" | grep -q "$disk"; then
return 0
fi
return 1
}
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
FREE_DISKS=()
2025-04-03 19:43:56 +02:00
ACTIVE_MD_DEVICES=$(awk '/^md/ {for (i=4; i<=NF; i++) print $i}' /proc/mdstat)
LVM_DEVICES=$(pvs --noheadings -o pv_name | xargs -n1 readlink -f | sed 's/ *$//' | sort -u)
2025-04-03 14:39:33 +02:00
while read -r DISK; do
2025-04-03 20:17:36 +02:00
# Ocultar discos virtuales (como ZVOLs) y LVM completos
2025-04-03 19:43:56 +02:00
if echo "$LVM_DEVICES" | grep -Fxq "$DISK"; then
continue
2025-04-03 14:39:33 +02:00
fi
2025-04-03 19:43:56 +02:00
IS_MOUNTED=false
IS_RAID=false
IS_RAID_ACTIVE=false
IS_ZFS=false
TAG=""
2025-04-03 20:17:36 +02:00
# Verificar si ya está en la VM seleccionada
if qm config "$VMID" | grep -q "$DISK"; then
continue
fi
2025-04-03 19:43:56 +02:00
while read -r part fstype; do
full_path="/dev/$part"
real_path=$(readlink -f "$full_path")
2025-04-03 20:17:36 +02:00
# Si está montado
2025-04-03 19:43:56 +02:00
if echo "$MOUNTED_DISKS" | grep -q "$full_path"; then
IS_MOUNTED=true
fi
2025-04-03 20:17:36 +02:00
# Si está en LVM (volumen lógico)
2025-04-03 19:43:56 +02:00
if echo "$LVM_DEVICES" | grep -Fxq "$real_path"; then
IS_MOUNTED=true
fi
case "$fstype" in
linux_raid_member)
IS_RAID=true
if echo "$ACTIVE_MD_DEVICES" | grep -q "$part"; then
IS_RAID_ACTIVE=true
fi
;;
zfs_member)
IS_ZFS=true
;;
esac
done < <(lsblk -ln -o NAME,FSTYPE "$DISK" | tail -n +2)
2025-04-03 20:17:36 +02:00
# Si está montado, lo descartamos
2025-04-03 19:43:56 +02:00
if $IS_MOUNTED; then
continue
fi
2025-04-03 20:17:36 +02:00
# Obtener info para mostrar en el menú
2025-04-03 19:43:56 +02:00
INFO=($(get_disk_info "$DISK"))
MODEL="${INFO[@]::${#INFO[@]}-1}"
SIZE="${INFO[-1]}"
2025-04-03 20:17:36 +02:00
# Etiqueta RAID/ZFS
2025-04-03 19:43:56 +02:00
if $IS_RAID; then
TAG=" ⚠ RAID"
2025-04-03 20:17:36 +02:00
$IS_RAID_ACTIVE && TAG=" ⚠ RAID (activo)"
2025-04-03 19:43:56 +02:00
elif $IS_ZFS; then
TAG=" ⚠ ZFS"
fi
DESCRIPTION=$(printf "%-30s %10s%s" "$MODEL" "$SIZE" "$TAG")
FREE_DISKS+=("$DISK" "$DESCRIPTION" "OFF")
2025-04-03 20:17:36 +02:00
done < <(lsblk -dn -o PATH,TYPE | awk '$2 == "disk" {print $1}')
2025-04-03 14:39:33 +02:00
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
if [ "${#FREE_DISKS[@]}" -eq 0 ]; then
2025-04-03 20:24:17 +02:00
cleanup
2025-04-03 14:39:33 +02:00
whiptail --title "$(translate "Error")" --msgbox "$(translate "No disks available for this VM.")" 8 40
2025-04-03 20:28:16 +02:00
clear
exit 1
2025-04-03 14:39:33 +02:00
fi
2025-04-03 19:43:56 +02:00
msg_ok "$(translate "Available disks detected.")"
2025-04-03 14:39:33 +02:00
######################################################
MAX_WIDTH=$(printf "%s\n" "${FREE_DISKS[@]}" | awk '{print length}' | sort -nr | head -n1)
TOTAL_WIDTH=$((MAX_WIDTH + 20))
if [ $TOTAL_WIDTH -lt 70 ]; then
TOTAL_WIDTH=70
fi
SELECTED=$(whiptail --title "$(translate "Select Disks")" --checklist \
"$(translate "Select the disks you want to add:")" 20 $TOTAL_WIDTH 10 "${FREE_DISKS[@]}" 3>&1 1>&2 2>&3)
if [ -z "$SELECTED" ]; then
whiptail --title "$(translate "Error")" --msgbox "$(translate "No disks were selected.")" 10 $TOTAL_WIDTH
clear
exit 1
fi
msg_ok "$(translate "Disks selected successfully.")"
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
INTERFACE=$(whiptail --title "$(translate "Interface Type")" --menu "$(translate "Select the interface type for all disks:")" 15 40 4 \
"sata" "$(translate "Add as SATA")" \
"scsi" "$(translate "Add as SCSI")" \
"virtio" "$(translate "Add as VirtIO")" \
"ide" "$(translate "Add as IDE")" 3>&1 1>&2 2>&3)
if [ -z "$INTERFACE" ]; then
whiptail --title "$(translate "Error")" --msgbox "$(translate "No interface type was selected for the disks.")" 8 40
clear
exit 1
fi
msg_ok "$(translate "Interface type selected: $INTERFACE")"
DISKS_ADDED=0
ERROR_MESSAGES=""
SUCCESS_MESSAGES=""
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
msg_info "$(translate "Processing selected disks...")"
for DISK in $SELECTED; do
DISK=$(echo "$DISK" | tr -d '"')
DISK_INFO=$(get_disk_info "$DISK")
ASSIGNED_TO=""
2025-04-03 19:43:56 +02:00
RUNNING_VMS=""
2025-04-03 14:39:33 +02:00
2025-04-03 19:43:56 +02:00
while read -r VM_ID VM_NAME; do
if [[ "$VM_ID" =~ ^[0-9]+$ ]] && qm config "$VM_ID" | grep -q "$DISK"; then
ASSIGNED_TO+="$VM_ID $VM_NAME\n"
VM_STATUS=$(qm status "$VM_ID" | awk '{print $2}')
if [ "$VM_STATUS" == "running" ]; then
RUNNING_VMS+="$VM_ID $VM_NAME\n"
2025-04-03 14:39:33 +02:00
fi
2025-04-03 19:43:56 +02:00
fi
2025-04-03 14:39:33 +02:00
done < <(qm list | awk 'NR>1 {print $1, $2}')
2025-04-03 19:43:56 +02:00
if [ -n "$RUNNING_VMS" ]; then
ERROR_MESSAGES+="$(translate "The disk") $DISK_INFO $(translate "is in use by the following running VM(s):")\\n$RUNNING_VMS\\n\\n"
continue
fi
2025-04-03 14:39:33 +02:00
2025-04-03 19:43:56 +02:00
if [ -n "$ASSIGNED_TO" ]; then
cleanup
whiptail --title "$(translate "Disk Already Assigned")" --yesno "$(translate "The disk") $DISK_INFO $(translate "is already assigned to the following VM(s):")\\n$ASSIGNED_TO\\n\\n$(translate "Do you want to continue anyway?")" 15 70
if [ $? -ne 0 ]; then
sleep 1
exec "$0"
2025-04-03 14:39:33 +02:00
fi
fi
2025-04-03 19:43:56 +02:00
INDEX=0
while qm config "$VMID" | grep -q "${INTERFACE}${INDEX}"; do
((INDEX++))
done
2025-04-03 14:39:33 +02:00
2025-04-03 19:43:56 +02:00
RESULT=$(qm set "$VMID" -${INTERFACE}${INDEX} "$DISK" 2>&1)
if [ $? -eq 0 ]; then
MESSAGE="$(translate "The disk") $DISK_INFO $(translate "has been successfully added to VM") $VMID."
if [ -n "$ASSIGNED_TO" ]; then
MESSAGE+="\\n\\n$(translate "WARNING: This disk is also assigned to the following VM(s):")\\n$ASSIGNED_TO"
MESSAGE+="\\n$(translate "Make sure not to start VMs that share this disk at the same time to avoid data corruption.")"
2025-04-03 14:39:33 +02:00
fi
2025-04-03 19:43:56 +02:00
SUCCESS_MESSAGES+="$MESSAGE\\n\\n"
((DISKS_ADDED++))
else
ERROR_MESSAGES+="$(translate "Could not add disk") $DISK_INFO $(translate "to VM") $VMID.\\n$(translate "Error:") $RESULT\\n\\n"
2025-04-03 14:39:33 +02:00
fi
done
msg_ok "$(translate "Disk processing completed.")"
2025-04-03 19:43:56 +02:00
2025-04-03 14:39:33 +02:00
if [ -n "$SUCCESS_MESSAGES" ]; then
MSG_LINES=$(echo "$SUCCESS_MESSAGES" | wc -l)
whiptail --title "$(translate "Successful Operations")" --msgbox "$SUCCESS_MESSAGES" 16 70
fi
if [ -n "$ERROR_MESSAGES" ]; then
whiptail --title "$(translate "Warnings and Errors")" --msgbox "$ERROR_MESSAGES" 16 70
fi
exit 0