Mirrors/ProxMenux
1
0
Fork 0
mirror of https://github.com/MacRimi/ProxMenux.git synced 2026-10-17 11:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(oci): distinguish clean removal from incomplete cleanup

Browse Source
This commit is contained in:
martino
2026-09-28 19:48:34 +02:00
parent 0c754bda60
commit 118a757ac7
4 changed files with 190 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
oci/src/proxmenux_oci/management.py
+4 -3
View File
@@ -318,7 +318,8 @@ def _removal_summary(project, vmid):
translate('Container data targeted for deletion:'), *volumes]
if bridge:
text += ['', f"{translate('Private network targeted for release if no other guest uses it:')} {bridge}"]
text += ['', translate('A matching managed host firewall rule may also be removed.')]
if (primary.get('deployment') or {}).get('host_firewall'):
text += ['', translate('A matching managed host firewall rule may also be removed.')]
if kept:
text += ['', translate('Host paths found in container configs or saved records (not targeted for removal):'),
*[f' {path}' for path in kept]]
@@ -334,8 +335,8 @@ def _remove(project, ui, vmid):
ui.message(f"{translate('The removal could not be prepared:')} {error}", translate('Remove OCI'))
return False
if not ui.review(summary, translate('Remove OCI'),
question=translate('Remove the application? Its container disks are targeted for deletion; '
'recovery from backups is not checked here.'),
question=translate('Remove the application? Its container disks are deleted, '
'and only a backup can bring them back.'),
default=False):
return False
return _run_lifecycle([sys.executable, str(project / 'remote/oci_remove.py'), str(vmid)],