fix(notifications): restore AI suggestions and explain backup failures

AppImage/scripts/notification_manager.py

@@ -42,7 +42,7 @@ from notification_channels import create_channel, CHANNEL_TYPES
 from notification_templates import (
     render_template, format_with_ai, format_with_ai_full, enrich_with_emojis, TEMPLATES,
     EVENT_GROUPS, CATEGORY_EMOJI, EVENT_EMOJI, get_event_types_by_group,
-    get_default_enabled_events, runtime_message,
+    get_default_enabled_events, runtime_message, format_backup_diagnostics_with_ai,
 )
 from notification_events import (
     JournalWatcher, TaskWatcher, PollingCollector, NotificationEvent,
@@ -68,6 +68,13 @@ ALLOWED_AI_LANGUAGES = (
     'ja', 'zh', 'ko', 'pl', 'nl', 'tr', 'ar',
 )
 _AI_BYPASS_EVENTS = frozenset({'backup_complete', 'backup_fail'})
+_AI_NO_SUGGESTION_EVENTS = frozenset({
+    'update_available', 'update_summary', 'pve_update',
+    'proxmenux_update', 'post_install_update', 'apt_listchanges',
+    'lxc_updates_available', 'secure_gateway_update_available',
+    'nvidia_driver_update_available', 'coral_driver_update_available',
+    'app_update_available', 'docker_stack_update_available',
+})
 
 
 def _should_bypass_ai(event_type: str) -> bool:
@@ -828,6 +835,13 @@ def _format_with_ai_bounded(format_fn, *args, timeout=AI_REWRITE_TIMEOUT_SECONDS
 
 # ─── Notification Manager ─────────────────────────────────────────
 
+def _format_backup_with_ai_bounded(*args, **kwargs):
+    result = _format_with_ai_bounded(format_backup_diagnostics_with_ai, *args, **kwargs)
+    if result is not None:
+        return result
+    return format_backup_diagnostics_with_ai(*args, **kwargs, fallback_only=True)
+
+
 class NotificationManager:
     """Central notification orchestrator.
     
@@ -1016,6 +1030,7 @@ class NotificationManager:
             'ai_openai_base_url': self._config.get('ai_openai_base_url', ''),
             'ai_prompt_mode': self._config.get('ai_prompt_mode', 'default'),
             'ai_custom_prompt': self._config.get('ai_custom_prompt', ''),
+            'ai_allow_suggestions': self._config.get('ai_allow_suggestions', 'false'),
         }
     
     def _rebuild_channels(self):
@@ -1328,6 +1343,8 @@ class NotificationManager:
             enriched_data['_body_html'] = rendered.get('body_html', '')
             enriched_data['_event_type'] = event.event_type
             enriched_data['_group'] = TEMPLATES.get(event.event_type, {}).get('group', 'other')
+            if rendered.get('backup_analysis'):
+                enriched_data['_backup_analysis'] = rendered['backup_analysis']
 
             if '_journal_context' in event.data:
                 enriched_data['_journal_context'] = event.data['_journal_context']
@@ -1454,14 +1471,7 @@ class NotificationManager:
                 # diagnostic alerts, update announcements must only translate
                 # and format the versions/actions already supplied by the
                 # deterministic template.
-                if event_type in {
-                    'update_available', 'update_summary', 'pve_update',
-                    'proxmenux_update', 'post_install_update', 'apt_listchanges',
-                    'lxc_updates_available', 'secure_gateway_update_available',
-                    'nvidia_driver_update_available',
-                    'coral_driver_update_available', 'app_update_available',
-                    'docker_stack_update_available',
-                }:
+                if event_type in _AI_NO_SUGGESTION_EVENTS:
                     channel_ai_config['ai_allow_suggestions'] = False
 
                 # Isolate the AI/enrich block in its own try so a failure
@@ -1471,11 +1481,16 @@ class NotificationManager:
                 # raw template-formatted notification. Audit Tier 6 —
                 # `_dispatch_to_channels`: AI failure dropped the notification.
                 try:
-                    # Backup reports are authoritative inventories. A model can
-                    # neither be trusted to avoid repeating all guest rows nor to
-                    # preserve every value, so these two events bypass AI entirely.
+                    # Keep backup inventories deterministic. Suggestions may
+                    # explain their diagnostic section without rewriting rows.
                     ai_result = None
-                    if not _should_bypass_ai(event_type):
+                    if _should_bypass_ai(event_type):
+                        ai_result = _format_backup_with_ai_bounded(
+                            ch_title, ch_body, severity, channel_ai_config,
+                            event_type=event_type, data=data,
+                            detail_level=detail_level, use_emojis=use_rich_format,
+                        )
+                    else:
                         enriched_context = enrich_context_for_ai(
                             title=ch_title,
                             body=ch_body,
@@ -2543,6 +2558,8 @@ class NotificationManager:
             title = title or rendered['title']
             message = rendered['body']
             severity = severity or rendered['severity']
+            if rendered.get('backup_analysis'):
+                runtime_data['_backup_analysis'] = rendered['backup_analysis']
 
         data = runtime_data
         
@@ -2567,8 +2584,16 @@ class NotificationManager:
                 
                 # Pass channel_type so AI knows whether to append original (email only)
                 channel_ai_config = {**ai_config, 'channel_type': ch_name}
+                if event_type in _AI_NO_SUGGESTION_EVENTS:
+                    channel_ai_config['ai_allow_suggestions'] = False
                 if _should_bypass_ai(event_type):
-                    ch_title, ch_message = title, message
+                    ai_result = _format_backup_with_ai_bounded(
+                        title, message, severity, channel_ai_config,
+                        event_type=event_type, data=data,
+                        detail_level=detail_level, use_emojis=use_rich_format,
+                    )
+                    ch_title = title
+                    ch_message = ai_result.get('body', message) if ai_result else message
                 else:
                     ai_result = format_with_ai_full(
                         title, message, severity, channel_ai_config,