From e7bb51182143e93847952e6692d09143e8f7d2f2 Mon Sep 17 00:00:00 2001
From: Vaso73 <50487331+Vaso73@users.noreply.github.com>
Date: Wed, 19 Aug 2026 07:13:58 +0200
Subject: [PATCH] fix: report Proxmox update failures correctly

---
 scripts/global/update-pve-safe.sh   | 30 ++++++++++++++---------------
 scripts/utilities/proxmox_update.sh | 11 ++++++++---
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/scripts/global/update-pve-safe.sh b/scripts/global/update-pve-safe.sh
index 28cb4a71..12d985e7 100644
--- a/scripts/global/update-pve-safe.sh
+++ b/scripts/global/update-pve-safe.sh
@@ -104,26 +104,26 @@ update_pve_safe() {
         return 1
     fi
 
-    # Reachability check: HEAD https://download.proxmox.com over the same
-    # transport apt-get update will use (HTTPS 443). Previously a single
-    # ICMP ping — hosts behind firewalls that filter ICMP but allow 443
-    # (typical corporate / cloud-provider setups) hit a false negative
-    # and the update aborted even though the repository was reachable.
-    # Two attempts with a short pause absorb transient network glitches
-    # without adding perceptible latency when the network is healthy.
+    # Reachability check: probe the public Proxmox repository over the
+    # transport apt is most likely to use. Many PVE installs use the
+    # official HTTP apt URI, while HTTPS may fail before apt ever runs
+    # if the CDN presents a certificate for another Proxmox hostname.
+    # Accept either transport and let apt-get update report repo-specific
+    # errors in the next step.
     _repo_reachable() {
-        local url="https://download.proxmox.com/"
-        local attempt
-        for attempt in 1 2; do
-            if curl -sfI --connect-timeout 5 --max-time 10 -o /dev/null "$url"; then
-                return 0
-            fi
-            [[ $attempt -eq 1 ]] && sleep 1
+        local url attempt
+        for url in "http://download.proxmox.com/" "https://download.proxmox.com/"; do
+            for attempt in 1 2; do
+                if curl -sfI --connect-timeout 5 --max-time 10 -o /dev/null "$url"; then
+                    return 0
+                fi
+                [[ $attempt -eq 1 ]] && sleep 1
+            done
         done
         return 1
     }
     if ! _repo_reachable; then
-        msg_error "$(translate "Cannot reach https://download.proxmox.com (HTTPS 443). Check network, proxy or DNS.")"
+        msg_error "$(translate "Cannot reach download.proxmox.com. Check network, proxy or DNS.")"
         echo -e
         msg_success "$(translate "Press Enter to return to menu...")"
         read -r
diff --git a/scripts/utilities/proxmox_update.sh b/scripts/utilities/proxmox_update.sh
index 855bd46e..a8784ea5 100644
--- a/scripts/utilities/proxmox_update.sh
+++ b/scripts/utilities/proxmox_update.sh
@@ -86,6 +86,8 @@ apt_upgrade() {
     # Single worker for both PVE 8 and 9 — it detects the version itself
     # and only performs operations safe on a production host.
     bash "$LOCAL_SCRIPTS/global/update-pve-safe.sh"
+    local worker_rc=$?
+    return "$worker_rc"
 
 
 }
@@ -162,11 +164,14 @@ check_reboot() {
 
 
 apt_upgrade
-check_reboot
+update_rc=$?
+if [[ "$update_rc" -eq 0 ]]; then
+    check_reboot
+else
+    exit "$update_rc"
+fi
 
     
 
 
 
-
-