Mirrors/ProxMenux
1
0
Fork 0
mirror of https://github.com/MacRimi/ProxMenux.git synced 2026-10-09 06:56:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(monitor): honour storage exclusions in the PVE storage capacity alert

Browse Source
This commit is contained in:
MacRimi
2026-09-29 20:56:02 +02:00
parent 438cb935d0
commit f421ac1cb1
3 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AppImage/scripts/tests/test_benign_disk_notices.py
+22
View File
@@ -45,6 +45,7 @@ class StorageUsageDetail(unittest.TestCase):
persistence = health_monitor.health_persistence
with patch.dict(sys.modules, {'proxmox_storage_monitor': module}), \
patch.object(health_monitor, 'PROXMOX_STORAGE_AVAILABLE', True), \
patch.object(persistence, 'get_excluded_storage_names', return_value=set()), \
patch.object(persistence, 'is_error_acknowledged', return_value=False), \
patch.object(persistence, 'record_error'), \
patch.object(persistence, 'get_active_errors', return_value=[]):
@@ -52,6 +53,27 @@ class StorageUsageDetail(unittest.TestCase):
entry = result['checks']['PBS-Cloud (pbs)']
self.assertEqual((entry['status'], entry['detail']), ('WARNING', '92.4% used'))
def test_a_storage_excluded_from_health_is_not_checked(self):
# Excluded in Health -> Exclusions, it raises nothing and its earlier
# error is cleared on the next cycle.
monitor = health_monitor.HealthMonitor.__new__(health_monitor.HealthMonitor)
monitor._read_capacity_thresholds = lambda section: (85, 95)
status = {'available': [{'name': 'Pluton', 'type': 'pbs', 'total': 1000, 'used': 860}]}
module = MagicMock()
module.proxmox_storage_monitor.get_storage_status.return_value = status
persistence = health_monitor.health_persistence
with patch.dict(sys.modules, {'proxmox_storage_monitor': module}), \
patch.object(health_monitor, 'PROXMOX_STORAGE_AVAILABLE', True), \
patch.object(persistence, 'get_excluded_storage_names', return_value={'Pluton'}), \
patch.object(persistence, 'record_error') as record, \
patch.object(persistence, 'clear_error') as clear, \
patch.object(persistence, 'get_active_errors',
return_value=[{'error_key': 'pve_storage_full_Pluton'}]):
result = monitor._check_pve_storage_capacity()
self.assertIsNone(result)
record.assert_not_called()
clear.assert_called_once_with('pve_storage_full_Pluton')
class FstrimUnsupportedDevices(unittest.TestCase):
def run_with(self, journal):