Commit Graph

1483 Commits

Author SHA1 Message Date
MacRimi
2fdf94f322 hotfix: prompt PBS encryption in attached-mode scheduled jobs + reorder backend menu
Two changes, both scoped to scripts/backup_restore/backup_scheduler.sh, worth
shipping to main ahead of the full v1.2.3 release PR:

1. Attached-mode PBS jobs never asked about encryption. `_create_job_attached`
   ran `hb_select_pbs_repository` and jumped straight to writing the .env with
   PBS_REPOSITORY / PBS_PASSWORD / PBS_BACKUP_ID — no `hb_ask_pbs_encryption`
   call, no PBS_KEYFILE / PBS_ENCRYPTION_PASSWORD emitted. The runner then
   invoked `proxmox-backup-client backup` without `--keyfile`, so every
   attached-mode backup landed on PBS unencrypted regardless of what the
   operator would have picked. Confirmed via `git show` on eight historical
   commits back to 61ff665c (beta 1.2.2.2) — the encryption call has NEVER
   been in the attached branch; the standalone `_create_job_new` branch had
   it since day one, they just diverged silently.

   Fix mirrors `_create_job_new` exactly (lines 413-443):
     hb_ask_pbs_encryption || return 1               # abort on cancel
     local pbs_kf_val=""
     [[ -n "${HB_PBS_KEYFILE_OPT:-}" ]] && pbs_kf_val="$HB_STATE_DIR/pbs-key.conf"
     lines+=(... "PBS_KEYFILE=${pbs_kf_val}" "PBS_ENCRYPTION_PASSWORD=${HB_PBS_ENC_PASS:-}")

   The Monitor Web path (flask_server.py::api_host_backups_job_create)
   already accepted pbs_encrypt_mode for both modes and passed it through
   correctly, so the fix is confined to the CLI wizard.

2. Backend selection menu reordered from `local | borg | pbs` to
   `pbs (recommended) | borg | local` so the recommended default sits at the
   top of the list. PBS gets the "(recommended)" suffix in its label.

Deployed and verified on the four test hosts (.50, .55, .89, .1.10) —
attached-mode wizard now shows the encryption dialog immediately after the
PBS job picker, and the .env carries PBS_KEYFILE + PBS_ENCRYPTION_PASSWORD
when the operator opts in.
2026-07-15 23:44:16 +02:00
MacRimi
8060f59d69 Update version 1.2.3 2026-07-14 19:22:33 +02:00
MacRimi
362409e654 update menus 2026-07-13 21:43:48 +02:00
MacRimi
a1167dad4b Update hw_grafics_menu.sh 2026-07-13 21:10:17 +02:00
MacRimi
63a6378f2d Update menus 2026-07-13 20:47:14 +02:00
MacRimi
f5c72f19b8 update 1.2.2.3 beta 2026-07-12 12:52:16 +02:00
MacRimi
71780fccf4 Update backup_host.sh 2026-07-08 18:02:26 +02:00
MacRimi
1f5fc9ad88 Update backup_host.sh 2026-07-08 17:50:14 +02:00
MacRimi
5e368cd8b3 Update vzdump-hook.sh 2026-07-08 15:46:12 +02:00
MacRimi
1b6776a53f Update lib_host_backup_common.sh 2026-07-08 15:36:55 +02:00
MacRimi
cc71d14dfa Update lib_host_backup_common.sh 2026-07-08 15:30:53 +02:00
MacRimi
8b6fdcf9e1 update 1.2.2.3 beta 2026-07-08 15:20:38 +02:00
MacRimi
341681a3dc Update 1.2.2.3 beta 2026-07-08 12:18:52 +02:00
MacRimi
6f0fc68c3d Update 1.2.2.3 beta 2026-07-06 17:15:22 +02:00
MacRimi
a037cd15af Update community scripts to use sourced utils 2026-07-06 08:41:20 +02:00
MacRimi
9c90722ef9 update 1.2.2.3 beta 2026-07-06 00:59:50 +02:00
MacRimi
7156af1965 update 1.2.2.3 beta 2026-07-06 00:39:43 +02:00
MacRimi
8df8a77bf1 update 1.2.2.3 beta 2026-07-06 00:30:47 +02:00
MacRimi
487ab04a14 update 1.2.2.3 beta 2026-07-05 23:58:58 +02:00
MacRimi
fd1aeb1ead Update run_scheduled_backup.sh 2026-07-05 23:38:12 +02:00
MacRimi
5b22039600 Update 1.2.2.3 beta 2026-07-05 17:23:00 +02:00
MacRimi
8bcfcd6059 update 1.2.2.3 beta 2026-07-05 16:58:27 +02:00
MacRimi
7fc7125c71 create 1.2.2.3 beta 2026-07-05 16:50:06 +02:00
MacRimi
29bca610a0 update 1.2.2.2 beta 2026-07-05 09:30:13 +02:00
MacRimi
877f7a3d81 update 1.2.2.2 beta 2026-07-04 22:58:07 +02:00
MacRimi
66dd3ec014 update 1.2.2.2 beta 2026-07-04 21:37:39 +02:00
MacRimi
17de0a5a77 Update 1.2.2.2 beta 2026-07-03 21:27:33 +02:00
MacRimi
9a81c631fa Update backup_host.sh 2026-07-03 19:28:28 +02:00
MacRimi
c25441cca2 Update backup_host.sh 2026-07-03 19:17:03 +02:00
MacRimi
35cb10ff44 update 1.2.2.2 beta 2026-07-03 18:59:45 +02:00
MacRimi
c455d66b91 update 1.2.2.2 beta 2026-07-02 23:52:04 +02:00
MacRimi
153aae659c Update lib_host_backup_common.sh 2026-07-02 22:23:21 +02:00
MacRimi
a00a6e5f2b Update backup_host.sh 2026-07-02 21:50:48 +02:00
MacRimi
ce3ad61f8f Update lib_host_backup_common.sh 2026-07-02 21:14:17 +02:00
MacRimi
0ad84572a7 Update lib_host_backup_common.sh 2026-07-02 21:11:54 +02:00
MacRimi
003ae3d31a Update lib_host_backup_common.sh 2026-07-02 21:03:54 +02:00
MacRimi
827c88d24f update 1.2.2.2 beta 2026-07-02 20:57:11 +02:00
MacRimi
357b2e8ac0 update 1.2.2.2 beta 2026-07-02 20:07:05 +02:00
MacRimi
bc3c771137 update 1.2.2.2 beta 2026-07-02 18:12:13 +02:00
MacRimi
6b173c42b6 Update 1.2.2.2 beta 2026-07-01 20:13:59 +02:00
MacRimi
51b9285980 update 1.2.2.2 beta 2026-06-28 13:06:40 +02:00
MacRimi
b7380fd582 Update lib_host_backup_common.sh 2026-06-24 16:14:33 +02:00
MacRimi
cfdd78244d Update 1.2.2.2 beta 2026-06-22 17:52:20 +02:00
MacRimi
194523c13a Update backup_host.sh 2026-06-22 17:41:34 +02:00
MacRimi
beb3e7e0c4 Update 1.2.2.2 beta 2026-06-22 17:08:31 +02:00
MacRimi
3b365f8ad5 Update proxmenux_debug.sh 2026-06-22 12:55:42 +02:00
MacRimi
b8038f4d41 Update proxmenux_debug.sh 2026-06-22 12:25:49 +02:00
MacRimi
68c8c03642 update 1.2.2.2 pre-beta 2026-06-22 11:38:06 +02:00
MacRimi
f50265a212 Update backup_host.sh 2026-06-22 00:44:02 +02:00
MacRimi
a9661a71ff update 1.2.2.2 beta 2026-06-21 23:49:41 +02:00