From bcf44718f1b95526acec0712f11296840506a2ff Mon Sep 17 00:00:00 2001 From: Jeffrey <9938813+Raphire@users.noreply.github.com> Date: Sat, 17 Oct 2026 00:46:35 +0200 Subject: [PATCH] fix: change verbose message to error for WinGet uninstall timeout --- Scripts/AppRemoval/Remove-SelectedApps.ps1 | 2 +- Tests/Remove-SelectedApps.Tests.ps1 | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Scripts/AppRemoval/Remove-SelectedApps.ps1 b/Scripts/AppRemoval/Remove-SelectedApps.ps1 index cca53f2..7ed5b7d 100644 --- a/Scripts/AppRemoval/Remove-SelectedApps.ps1 +++ b/Scripts/AppRemoval/Remove-SelectedApps.ps1 @@ -196,7 +196,7 @@ function Remove-WinGetApp { catch { $uninstallCommandSucceeded = $false if ($_.Exception.Message -like 'Operation timed out after *') { - Write-Verbose "WinGet uninstall for $app did not complete within $TimeoutSeconds seconds: $_" + Write-Error "WinGet uninstall for $app did not complete within $TimeoutSeconds seconds: $_" } else { Write-Verbose "WinGet uninstall for $app failed: $_" diff --git a/Tests/Remove-SelectedApps.Tests.ps1 b/Tests/Remove-SelectedApps.Tests.ps1 index 0107e5c..25a7692 100644 --- a/Tests/Remove-SelectedApps.Tests.ps1 +++ b/Tests/Remove-SelectedApps.Tests.ps1 @@ -255,12 +255,11 @@ Describe 'Remove-WinGetApp' { It 'reports a timed-out winget uninstall and continues' { $script:Params = @{ User = 'Alice' } Mock Invoke-NonBlocking { throw 'Operation timed out after 120 seconds' } - Mock Write-Verbose {} - { Remove-WinGetApp -app 'One.App' } | Should -Not -Throw + Remove-WinGetApp -app 'One.App' | Should -BeFalse Should -Invoke Set-RunOnceWingetTask -Times 1 -Exactly - Should -Invoke Write-Verbose -Times 1 -Exactly -ParameterFilter { - $Message -like '*did not complete within 120 seconds*' + Should -Invoke Write-Error -Times 1 -Exactly -ParameterFilter { + $Message -like 'WinGet uninstall for One.App did not complete within 120 seconds:*Operation timed out after 120 seconds*' } }