Refactor: Cleanup app removal, remove legacy app list generator and CustomAppsList file support (#662)

* remove support for uninstalling old sunset apps

* Add color legend on app removal screen

* Remove legacy app list generator and custom apps file support
Replaced by GUI config export/import, dynamic RemovalMethod, and
CLI app removal settings saved to LastUsedSettings.json.

* Verify app removal by checking actual installation state instead of trusting winget output

Scripts/FileIO/LoadAppsDetailsFromJson.ps1

@@ -2,7 +2,7 @@
 function LoadAppsDetailsFromJson {
     param (
         [switch]$OnlyInstalled,
-        [string]$InstalledList = "",
+        [object[]]$InstalledList = $null,
         [switch]$InitialCheckedFromJson
     )
 
@@ -24,22 +24,19 @@ function LoadAppsDetailsFromJson {
         if ($OnlyInstalled) {
             $isInstalled = $false
             foreach ($appId in $appIdArray) {
-                if (($InstalledList -like ("*$appId*")) -or (Get-AppxPackage -Name $appId)) {
+                # Check Get-AppxPackage first (fast, no process launch)
+                if (Get-AppxPackage -Name $appId) {
                     $isInstalled = $true
                     break
                 }
-                if (($appId -eq "Microsoft.Edge") -and ($InstalledList -like "* Microsoft.Edge *")) {
-                    $isInstalled = $true
-                    break
-                }
-                if (($appId -eq "Microsoft.OneDrive") -and (
-                        (Test-Path "$env:ProgramFiles\Microsoft OneDrive\OneDrive.exe") -or
-                        (Test-Path "$env:LOCALAPPDATA\Microsoft\OneDrive\OneDrive.exe")
-                    )) {
+
+                # Then check the pre-fetched winget list
+                if ($InstalledList -and (Test-AppInWingetList -appId $appId -InstalledList $InstalledList)) {
                     $isInstalled = $true
                     break
                 }
             }
+
             if (-not $isInstalled) { continue }
         }
 
@@ -59,6 +56,7 @@ function LoadAppsDetailsFromJson {
             Description = $appData.Description
             SelectedByDefault = $appData.SelectedByDefault
             Recommendation = $appData.Recommendation
+            RemovalMethod = if ($appData.RemovalMethod -and $appData.RemovalMethod -eq 'WinGet') { 'WinGet' } else { 'Appx' }
         }
     }