Refactor: Cleanup app removal, remove legacy app list generator and CustomAppsList file support (#662)

* remove support for uninstalling old sunset apps

* Add color legend on app removal screen

* Remove legacy app list generator and custom apps file support
Replaced by GUI config export/import, dynamic RemovalMethod, and
CLI app removal settings saved to LastUsedSettings.json.

* Verify app removal by checking actual installation state instead of trusting winget output

Scripts/GUI/MainWindow-AppSelection.ps1

@@ -311,12 +311,13 @@ function Load-AppsWithList {
         [System.Windows.Controls.CheckBox]$OnlyInstalledAppsBox,
         [System.Windows.Controls.Border]$LoadingAppsIndicator,
         [System.Windows.Controls.MenuItem]$ImportConfigBtn,
-        [string]$ListOfApps
+        [object[]]$ListOfApps
     )
 
     $script:MainWindowLastSelectedCheckbox = $null
 
     $loaderScriptPath = $script:LoadAppsDetailsScriptPath
+    $helperScriptPath = $script:TestAppInWingetListScriptPath
     $appsFilePath = $script:AppsListFilePath
     $onlyInstalled = [bool]$OnlyInstalledAppsBox.IsChecked
 
@@ -326,13 +327,16 @@ function Load-AppsWithList {
         $script:PreloadedAppData = $null
     }
     else {
-        # Load apps details in a background job to keep the UI responsive
+        # Load apps details in a background job to keep the UI responsive.
+        # The helper is dot-sourced inside the job because the runspace
+        # does not inherit the parent scope's dot-sourced functions.
         $rawAppData = Invoke-NonBlocking -ScriptBlock {
-            param($loaderScript, $appsListFilePath, $installedList, $onlyInstalled)
+            param($loaderScript, $helperScript, $appsListFilePath, $installedList, $onlyInstalled)
             $script:AppsListFilePath = $appsListFilePath
+            . $helperScript
             . $loaderScript
             LoadAppsDetailsFromJson -OnlyInstalled:$onlyInstalled -InstalledList $installedList -InitialCheckedFromJson:$false
-        } -ArgumentList $loaderScriptPath, $appsFilePath, $ListOfApps, $onlyInstalled
+        } -ArgumentList $loaderScriptPath, $helperScriptPath, $appsFilePath, $ListOfApps, $onlyInstalled
     }
 
     $appsToAdd = @($rawAppData | Where-Object { $_ -and ($_.AppId -or $_.FriendlyName) } | Sort-Object -Property FriendlyName)
@@ -348,10 +352,9 @@ function Load-AppsWithList {
         return
     }
 
-    $brushSafe = [System.Windows.Media.BrushConverter]::new().ConvertFromString('#4CAF50')
-    $brushUnsafe = [System.Windows.Media.BrushConverter]::new().ConvertFromString('#F44336')
-    $brushDefault = [System.Windows.Media.BrushConverter]::new().ConvertFromString('#FFC107')
-    $brushSafe.Freeze(); $brushUnsafe.Freeze(); $brushDefault.Freeze()
+    $brushSafe    = $Window.Resources['AppRecommendationSafeColor']
+    $brushDefault = $Window.Resources['AppRecommendationOptionalColor']
+    $brushUnsafe  = $Window.Resources['AppRecommendationUnsafeColor']
 
     # Create WPF controls; pump the Dispatcher every batch so the spinner keeps animating.
     $batchSize = 20
@@ -381,7 +384,7 @@ function Load-AppsWithList {
         $dot.ToolTip = switch ($app.Recommendation) {
             'safe'   { '[Recommended] Safe to remove for most users' }
             'unsafe' { '[Not Recommended] Only remove if you know what you are doing' }
-            default  { "[Optional] Remove if you don't need this app" }
+            default  { "[Optional] Can be safely removed if you don't need this app" }
         }
         [System.Windows.Controls.Grid]::SetColumn($dot, 0)
 
@@ -512,7 +515,7 @@ function Load-AppsIntoMainUI {
     $Window.Dispatcher.Invoke([System.Windows.Threading.DispatcherPriority]::Render, [action] {})
     $Window.Dispatcher.BeginInvoke([System.Windows.Threading.DispatcherPriority]::Background, [action] {
             try {
-                $listOfApps = ""
+                $listOfApps = $null
 
                 if ($OnlyInstalledAppsBox.IsChecked -and ($script:WingetInstalled -eq $true)) {
                     Write-Host "Retrieving installed apps via winget..."

Scripts/GUI/Show-AppSelectionWindow.ps1

@@ -53,12 +53,12 @@ function Show-AppSelectionWindow {
         $window.Dispatcher.Invoke([System.Windows.Threading.DispatcherPriority]::Background, [action]{})
 
         $appsPanel.Children.Clear()
-        $listOfApps = ""
+        $listOfApps = $null
 
         if ($onlyInstalledBox.IsChecked -and ($script:WingetInstalled -eq $true)) {
             # Attempt to get a list of installed apps via WinGet, times out after 10 seconds
-            $listOfApps = GetInstalledAppsViaWinget -TimeOut 10
-            if (-not $listOfApps) {
+            $listOfApps = GetInstalledAppsViaWinget -TimeOut 10 -NonBlocking
+            if ($null -eq $listOfApps) {
                 # Show error that the script was unable to get list of apps from WinGet
                 Show-MessageBox -Message 'Unable to load list of installed apps via WinGet.' -Title 'Error' -Button 'OK' -Icon 'Error' -Owner $window | Out-Null
                 $onlyInstalledBox.IsChecked = $false
@@ -134,7 +134,7 @@ function Show-AppSelectionWindow {
             return
         }
 
-        SaveCustomAppsListToFile -appsList $selectedApps
+        $script:SelectedApps = $selectedApps
 
         $window.DialogResult = $true
     })

Scripts/GUI/Show-MainWindow.ps1

@@ -940,7 +940,7 @@
 
     # ---- Preload app data ----
     try {
-        $script:PreloadedAppData = LoadAppsDetailsFromJson -OnlyInstalled:$false -InstalledList '' -InitialCheckedFromJson:$false
+        $script:PreloadedAppData = LoadAppsDetailsFromJson -OnlyInstalled:$false -InstalledList $null -InitialCheckedFromJson:$false
     }
     catch {
         Write-Warning "Failed to preload apps list: $_"