Mirrors/meshcore_py
1
0
Fork 0
mirror of https://github.com/meshcore-dev/meshcore_py.git synced 2026-06-11 03:56:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #73 from mwolter805/fix/test-timeout-waste

Browse Source 
test: resolve mock_dispatcher futures to drop suite runtime from ~8 min to <1s
This commit is contained in:
fdlamotte
2026-04-25 14:53:27 +02:00
committed by GitHub
parent ac7b035b9e 75c4a58841
commit ba6dcd459e
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/test_commands.py
View File

@@ -28,6 +28,10 @@ def mock_dispatcher():
sub.unsubscribe = MagicMock() sub.unsubscribe = MagicMock()
dispatcher._last_subscribe_handler = handler dispatcher._last_subscribe_handler = handler
dispatcher._last_subscribe_event_type = event_type dispatcher._last_subscribe_event_type = event_type
# Immediately resolve the future so send() doesn't block
asyncio.get_event_loop().call_soon(
handler, Event(event_type, {})
)
return sub return sub
dispatcher.subscribe = MagicMock(side_effect=fake_subscribe) dispatcher.subscribe = MagicMock(side_effect=fake_subscribe)
@@ -80,6 +84,13 @@ async def test_send_with_event(command_handler, mock_connection, mock_dispatcher
async def test_send_timeout(command_handler, mock_connection, mock_dispatcher): async def test_send_timeout(command_handler, mock_connection, mock_dispatcher):
# Override to NOT resolve events, so we can test the timeout path
def non_resolving_subscribe(event_type, handler, attribute_filters=None):
sub = MagicMock(spec=Subscription)
sub.unsubscribe = MagicMock()
return sub
mock_dispatcher.subscribe = MagicMock(side_effect=non_resolving_subscribe)
result = await command_handler.send(b"test_command", [EventType.OK], timeout=0.1) result = await command_handler.send(b"test_command", [EventType.OK], timeout=0.1)
assert result.type == EventType.ERROR assert result.type == EventType.ERROR
assert result.payload == {"reason": "no_event_received"} assert result.payload == {"reason": "no_event_received"}