fix contact retreival issue (CONTACTS event was doing a timeout)

src/meshcore/commands/contact.py

@@ -18,60 +18,39 @@ class ContactCommands(CommandHandlerBase):
         await self.send(data)
 
     async def get_contacts(self, lastmod=0, timeout=5) -> Event:
-        await self.get_contacts_async(lastmod)
+        loop = asyncio.get_running_loop()
+        result = loop.create_future()
+        state = {"activity": False}
+    
+        def on_next(event):
+            state["activity"] = True
+    
+        def on_end(event):
+            if not result.done():
+                result.set_result(event)
+    
+        subs = [
+            self.dispatcher.subscribe(EventType.NEXT_CONTACT, on_next),
+            self.dispatcher.subscribe(EventType.CONTACTS, on_end),
+            self.dispatcher.subscribe(EventType.ERROR, on_end),
+        ]
     
-        # Inline wait for events to continue waiting for CONTACTS event 
-        # while receiving NEXT_CONTACTs (or it might be missed over serial)
         try:
-            # Create futures for all expected events
+            await self.get_contacts_async(lastmod)
-            futures = []
-            for event_type in [EventType.ERROR, EventType.NEXT_CONTACT, EventType.CONTACTS] :
-                future = asyncio.create_task(
-                    self.dispatcher.wait_for_event(event_type, {}, timeout=timeout)
-                )
-                futures.append(future)
     
             while True:
-    
+                state["activity"] = False
-                # Wait for the first event to complete or all to timeout
+                try:
-                done, pending = await asyncio.wait(
+                    # shield so the timeout doesn't cancel the future itself
-                    futures, timeout=timeout, return_when=asyncio.FIRST_COMPLETED
+                    return await asyncio.wait_for(asyncio.shield(result), timeout)
-                )
+                except asyncio.TimeoutError:
-    
+                    if state["activity"]:
-                # Check if any future completed successfully
+                        continue  # still receiving contacts, keep waiting
-                if len(done) == 0:
                     logger.debug("Timeout while getting contacts")
-                    for future in pending: # cancel all futures
-                        future.cancel()
                     return Event(EventType.ERROR, {"reason": "timeout waiting for contacts"})
-
+        finally:
-                for future in done:
+            for s in subs:
-                    event = await future
+                s.unsubscribe()
-                    if event is None:
-                        for f in pending:
-                            f.cancel()
-                        return Event(EventType.ERROR, {"reason": "no event received during contacts retrieval"})
-                    if event.type != EventType.NEXT_CONTACT:
-                        for f in pending:
-                            f.cancel()
-                        return event
-
-                futures = []
-
-                for future in pending: # put back pending
-                    futures.append(future)
-
-                future = asyncio.create_task( # and recreate NEXT_CONTACT
-                        self.dispatcher.wait_for_event(EventType.NEXT_CONTACT, {}, timeout)
-                    )
-                futures.append(future)
-    
-        except asyncio.TimeoutError:
-            logger.debug(f"Timeout receiving contacts")
-            return Event(EventType.ERROR, {"reason": "asyncio timeout receiving contacts"})
-        except Exception as e:
-            logger.debug(f"Command error: {e}")
-            return Event(EventType.ERROR, {"error": str(e)})
 
     async def reset_path(self, key: DestinationType) -> Event:
         key_bytes = _validate_destination(key, prefix_length=32)