feat(api): crud for interface backend settings and create default peer flag (#765)
Docker / Build and Push (push) Canceled after 0s
github-pages / deploy (push) Canceled after 0s
Test / make test (push) Canceled after 0s
Docker / release (push) Canceled after 0s

This commit is contained in:
Christoph
2026-11-09 23:26:10 +01:00
parent 8bd9b6192e
commit 61c8ceaab8
6 changed files with 127 additions and 11 deletions
@@ -3,6 +3,7 @@ package backend
import (
"context"
"fmt"
"slices"
"github.com/h44z/wg-portal/internal/config"
"github.com/h44z/wg-portal/internal/domain"
@@ -79,6 +80,10 @@ func (s InterfaceService) Create(ctx context.Context, iface *domain.Interface) (
return nil, err
}
if err := s.validateBackend(iface.Backend); err != nil {
return nil, err
}
createdInterface, err := s.interfaces.CreateInterface(ctx, iface)
if err != nil {
return nil, err
@@ -101,6 +106,19 @@ func (s InterfaceService) Update(ctx context.Context, id domain.InterfaceIdentif
iface.Identifier, id, domain.ErrInvalidData)
}
existingInterface, _, err := s.interfaces.GetInterfaceAndPeers(ctx, id)
if err != nil {
return nil, nil, err
}
if err := s.validateBackend(iface.Backend); err != nil {
return nil, nil, err
}
// These fields are managed by the server and cannot be changed through v1.
iface.IsDynamic = existingInterface.IsDynamic
iface.DriverType = existingInterface.DriverType
iface.LdapAllowedUsers = existingInterface.LdapAllowedUsers
updatedInterface, updatedPeers, err := s.interfaces.UpdateInterface(ctx, iface)
if err != nil {
return nil, nil, err
@@ -109,6 +127,22 @@ func (s InterfaceService) Update(ctx context.Context, id domain.InterfaceIdentif
return updatedInterface, updatedPeers, nil
}
// validateBackend validates against configured IDs so a typo cannot silently use
// the controller manager's fallback to the local backend.
func (s InterfaceService) validateBackend(backend domain.InterfaceBackend) error {
id := string(backend)
// Empty is the legacy representation of the local backend in domain objects.
if id == "" || id == config.LocalBackendName ||
slices.ContainsFunc(s.cfg.Backend.Mikrotik, func(b config.BackendMikrotik) bool { return b.Id == id }) ||
slices.ContainsFunc(s.cfg.Backend.Pfsense, func(b config.BackendPfsense) bool { return b.Id == id }) ||
slices.ContainsFunc(s.cfg.Backend.Opnsense, func(b config.BackendOpnsense) bool { return b.Id == id }) {
return nil
}
return fmt.Errorf("unknown interface backend %q: %w", id, domain.ErrInvalidData)
}
func (s InterfaceService) Delete(ctx context.Context, id domain.InterfaceIdentifier) error {
if err := domain.ValidateAdminAccessRights(ctx); err != nil {
return err