feat(backend): add OPNsense backend (#743)
Docker / Build and Push (push) Canceled after 0s
github-pages / deploy (push) Canceled after 0s
Test / make test (push) Canceled after 0s
Docker / release (push) Canceled after 0s

Manages interfaces and peers on OPNsense through the WireGuard API in
OPNsense core, so a stock appliance needs nothing installed. OPNsense
calls a tunnel a "server" and a peer on it a "client"; those map to
PhysicalInterface and PhysicalPeer.

Reads go through searchXxx because getXxx returns select fields as
{value, selected} maps that cannot be posted back to a write. Validation
failures arrive as HTTP 200 with a "result": "failed" body, so the body
is checked and not the status code.

Firewall rules are not managed, matching the pfSense backend: a new
tunnel handshakes but carries no traffic until a pass rule exists.

Alpha, and documented as such.

Signed-off-by: clark-ja <37738506+clark-ja@users.noreply.github.com>
This commit is contained in:
Jacopo Clark
2026-09-10 22:27:17 +02:00
committed by GitHub
parent 32ef6048fb
commit 7f5786f40f
14 changed files with 2855 additions and 14 deletions
@@ -44,6 +44,9 @@ func (c *ControllerManager) init() error {
return err
}
if err := c.registerOpnsenseControllers(); err != nil {
return err
}
if err := c.registerPfsenseControllers(); err != nil {
return err
}
@@ -113,6 +116,26 @@ func (c *ControllerManager) registerPfsenseControllers() error {
return nil
}
func (c *ControllerManager) registerOpnsenseControllers() error {
for _, backendConfig := range c.cfg.Backend.Opnsense {
if backendConfig.Id == config.LocalBackendName {
slog.Warn("skipping registration of OPNsense controller with reserved ID", "id", config.LocalBackendName)
continue
}
controller, err := wgcontroller.NewOpnsenseController(c.cfg, &backendConfig)
if err != nil {
return fmt.Errorf("failed to create OPNsense controller for backend %s: %w", backendConfig.Id, err)
}
c.controllers[domain.InterfaceBackend(backendConfig.Id)] = backendInstance{
Config: backendConfig.BackendBase,
Implementation: controller,
}
}
return nil
}
func (c *ControllerManager) logRegisteredControllers() {
for backend, controller := range c.controllers {
slog.Debug("backend controller registered",
@@ -0,0 +1,95 @@
package wireguard
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/h44z/wg-portal/internal/config"
"github.com/h44z/wg-portal/internal/domain"
)
// newBareControllerManager builds a manager without running init(), which would
// try to register the local controller and needs privileges this test lacks.
func newBareControllerManager(cfg *config.Config) *ControllerManager {
return &ControllerManager{
cfg: cfg,
controllers: make(map[domain.InterfaceBackend]backendInstance),
}
}
func TestRegisterOpnsenseControllers(t *testing.T) {
cfg := &config.Config{}
cfg.Backend.Opnsense = []config.BackendOpnsense{
{
BackendBase: config.BackendBase{Id: "opn1", DisplayName: "Edge firewall"},
ApiUrl: "https://127.0.0.1",
ApiKey: "key",
ApiSecret: "secret",
},
}
manager := newBareControllerManager(cfg)
require.NoError(t, manager.registerOpnsenseControllers())
instance, ok := manager.controllers["opn1"]
require.True(t, ok, "the opnsense backend should be registered under its configured id")
assert.Equal(t, "Edge firewall", instance.Config.GetDisplayName())
require.NotNil(t, instance.Implementation)
assert.Equal(t, domain.InterfaceBackend("opn1"), instance.Implementation.GetId())
// The controller must also satisfy the wg-quick and routing contracts, which
// the wireguard manager relies on when an interface is brought up or down.
_, isWgQuick := instance.Implementation.(WgQuickController)
assert.True(t, isWgQuick, "controller must implement WgQuickController")
}
// A backend that claims the reserved "local" id must be skipped rather than
// shadowing the built-in local controller.
func TestRegisterOpnsenseControllersSkipsReservedId(t *testing.T) {
cfg := &config.Config{}
cfg.Backend.Opnsense = []config.BackendOpnsense{
{
BackendBase: config.BackendBase{Id: config.LocalBackendName},
ApiUrl: "https://127.0.0.1",
ApiKey: "key",
ApiSecret: "secret",
},
}
manager := newBareControllerManager(cfg)
require.NoError(t, manager.registerOpnsenseControllers())
assert.Empty(t, manager.controllers, "the reserved id must not be registered")
}
// Missing credentials must fail loudly at startup rather than producing a
// controller that 401s on every call once the portal is running.
func TestRegisterOpnsenseControllersRequiresCredentials(t *testing.T) {
tests := map[string]config.BackendOpnsense{
"no url": {
BackendBase: config.BackendBase{Id: "opn1"},
ApiKey: "key", ApiSecret: "secret",
},
"no key": {
BackendBase: config.BackendBase{Id: "opn1"},
ApiUrl: "https://127.0.0.1", ApiSecret: "secret",
},
"no secret": {
BackendBase: config.BackendBase{Id: "opn1"},
ApiUrl: "https://127.0.0.1", ApiKey: "key",
},
}
for name, backendConfig := range tests {
t.Run(name, func(t *testing.T) {
cfg := &config.Config{}
cfg.Backend.Opnsense = []config.BackendOpnsense{backendConfig}
manager := newBareControllerManager(cfg)
err := manager.registerOpnsenseControllers()
require.Error(t, err)
assert.Contains(t, err.Error(), "opn1")
})
}
}