mirror of
https://github.com/h44z/wg-portal.git
synced 2026-05-28 08:56:17 +00:00
feat: sanitize external identity provider user data (#681)
* feat: sanitize external user data * remove config option to disable Sanitization: sanitize_external_user_data * cleanup --------- Co-authored-by: Christoph Haas <christoph.h@sprinternet.at>
This commit is contained in:
@@ -1,5 +1,10 @@
|
||||
package domain
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"strings"
|
||||
)
|
||||
|
||||
type LoginProvider string
|
||||
|
||||
type LoginProviderInfo struct {
|
||||
@@ -20,3 +25,52 @@ type AuthenticatorUserInfo struct {
|
||||
IsAdmin bool
|
||||
AdminInfoAvailable bool // true if the IsAdmin flag is valid
|
||||
}
|
||||
|
||||
// Sanitize sanitizes all external identity provider fields in place.
|
||||
// Returns ErrInvalidData if the identifier becomes empty after sanitization.
|
||||
func (u *AuthenticatorUserInfo) Sanitize(providerType, providerName string) error {
|
||||
identifier := string(u.Identifier)
|
||||
LogSanitizeChange(providerType, providerName, "identifier", identifier,
|
||||
func() string { return SanitizeIdentifier(identifier, 256) }, &identifier)
|
||||
u.Identifier = UserIdentifier(identifier)
|
||||
|
||||
email := u.Email
|
||||
LogSanitizeChange(providerType, providerName, "email", email,
|
||||
func() string { return SanitizeEmail(email, 254) }, &u.Email)
|
||||
LogSanitizeChange(providerType, providerName, "firstname", u.Firstname,
|
||||
func() string { return SanitizeString(u.Firstname, 128) }, &u.Firstname)
|
||||
LogSanitizeChange(providerType, providerName, "lastname", u.Lastname,
|
||||
func() string { return SanitizeString(u.Lastname, 128) }, &u.Lastname)
|
||||
LogSanitizeChange(providerType, providerName, "phone", u.Phone,
|
||||
func() string { return SanitizePhone(u.Phone, 50) }, &u.Phone)
|
||||
LogSanitizeChange(providerType, providerName, "department", u.Department,
|
||||
func() string { return SanitizeString(u.Department, 128) }, &u.Department)
|
||||
|
||||
u.UserGroups = sanitizeGroups(providerType, providerName, u.UserGroups)
|
||||
|
||||
if u.Identifier == "" {
|
||||
return fmt.Errorf("empty user identifier: %w", ErrInvalidData)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
// sanitizeGroups sanitizes group names, dropping any that were modified by sanitization.
|
||||
func sanitizeGroups(providerType, providerName string, rawGroups []string) []string {
|
||||
if len(rawGroups) == 0 {
|
||||
return rawGroups
|
||||
}
|
||||
|
||||
groups := make([]string, 0, len(rawGroups))
|
||||
for _, rawGroup := range rawGroups {
|
||||
sanitized := rawGroup
|
||||
LogSanitizeChange(providerType, providerName, "user_group", rawGroup,
|
||||
func() string { return SanitizeString(rawGroup, 256) }, &sanitized)
|
||||
if sanitized == "" || sanitized != strings.TrimSpace(rawGroup) {
|
||||
continue
|
||||
}
|
||||
groups = append(groups, sanitized)
|
||||
}
|
||||
|
||||
return groups
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user