diff --git a/scheduler/tests.py b/scheduler/tests.py index a39b155..384e35e 100644 --- a/scheduler/tests.py +++ b/scheduler/tests.py @@ -1 +1,66 @@ -# Create your tests here. +import datetime + +from django.contrib.auth.models import User +from django.test import TestCase +from django.urls import reverse + +from scheduler.models import ScheduleProfile, ScheduleSlot +from user_manager.models import UserAcl + + +class SchedulerAccessControlTests(TestCase): + def setUp(self): + self.profile = ScheduleProfile.objects.create(name='Business Hours') + self.slot = ScheduleSlot.objects.create( + profile=self.profile, start_weekday=0, end_weekday=0, + start_time=datetime.time(8, 0), end_time=datetime.time(18, 0), + ) + + def _login_with_level(self, user_level): + user = User.objects.create_user(username=f'user{user_level}', password='fixture-password') + UserAcl.objects.create(user=user, user_level=user_level) + self.client.force_login(user) + + def test_low_levels_cannot_change_profiles_or_slots(self): + for user_level in (10, 20): + with self.subTest(user_level=user_level): + self._login_with_level(user_level) + + requests = ( + (reverse('manage_scheduler_profile'), {'name': 'Changed', 'active': 'on'}), + (f"{reverse('manage_scheduler_profile')}?uuid={self.profile.uuid}", {'name': 'Changed'}), + (f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}", {}), + (f"{reverse('manage_scheduler_slot')}?profile_uuid={self.profile.uuid}", { + 'start_weekday': 1, 'end_weekday': 1, 'start_time': '00:00', 'end_time': '23:59', + }), + (f"{reverse('delete_scheduler_slot')}?uuid={self.slot.uuid}", {}), + ) + for url, data in requests: + response = self.client.post(url, data) + self.assertEqual(response.status_code, 200) + self.assertTemplateUsed(response, 'access_denied.html') + + self.assertEqual(ScheduleProfile.objects.count(), 1) + self.assertEqual(ScheduleProfile.objects.get(uuid=self.profile.uuid).name, 'Business Hours') + self.assertEqual(ScheduleSlot.objects.count(), 1) + + def test_peer_manager_can_delete_slot_and_profile(self): + self._login_with_level(30) + + response = self.client.post(f"{reverse('delete_scheduler_slot')}?uuid={self.slot.uuid}") + self.assertEqual(response.status_code, 302) + self.assertFalse(ScheduleSlot.objects.exists()) + + response = self.client.post(f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}") + self.assertEqual(response.status_code, 302) + self.assertFalse(ScheduleProfile.objects.exists()) + + def test_profile_list_disables_crud_buttons_for_low_levels(self): + self._login_with_level(20) + + response = self.client.get(reverse('scheduler_profile_list')) + self.assertEqual(response.status_code, 200) + self.assertContains(response, 'Business Hours') + self.assertNotContains(response, f"{reverse('manage_scheduler_profile')}?uuid={self.profile.uuid}") + self.assertNotContains(response, f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}") + self.assertContains(response, 'btn btn-primary disabled') diff --git a/scheduler/views.py b/scheduler/views.py index de0ff82..d60176e 100644 --- a/scheduler/views.py +++ b/scheduler/views.py @@ -8,6 +8,7 @@ from django.utils.translation import gettext as _ from scheduler.forms import ScheduleProfileForm from scheduler.forms import ScheduleSlotForm from scheduler.models import ScheduleProfile, ScheduleSlot, PeerScheduling +from user_manager.models import UserAcl @login_required @@ -21,6 +22,9 @@ def view_scheduler_profile_list(request): @login_required def view_manage_scheduler_profile(request): + if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists(): + return render(request, 'access_denied.html', {'page_title': 'Access Denied'}) + profile_uuid = request.GET.get('uuid') if profile_uuid: profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid) @@ -60,6 +64,9 @@ def view_manage_scheduler_profile(request): @login_required def view_delete_scheduler_profile(request): + if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists(): + return render(request, 'access_denied.html', {'page_title': 'Access Denied'}) + profile_uuid = request.GET.get('uuid') profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid) @@ -79,6 +86,9 @@ def view_delete_scheduler_profile(request): @login_required def view_manage_scheduler_slot(request): + if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists(): + return render(request, 'access_denied.html', {'page_title': 'Access Denied'}) + slot_uuid = request.GET.get('uuid') profile_uuid = request.GET.get('profile_uuid') @@ -115,6 +125,9 @@ def view_manage_scheduler_slot(request): @login_required def view_delete_scheduler_slot(request): + if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists(): + return render(request, 'access_denied.html', {'page_title': 'Access Denied'}) + slot_uuid = request.GET.get('uuid') slot = get_object_or_404(ScheduleSlot, uuid=slot_uuid) profile = slot.profile diff --git a/templates/scheduler/scheduleprofile_list.html b/templates/scheduler/scheduleprofile_list.html index 7fdfaba..baaf2d0 100644 --- a/templates/scheduler/scheduleprofile_list.html +++ b/templates/scheduler/scheduleprofile_list.html @@ -21,12 +21,22 @@