Integration of upstrem PR #1297

0 = forwarding flood adverts off
1 = forwarding flood adverts on (unrestricted)
0.308 (default) = prob. forwarding according to #1338

.devcontainer/devcontainer.json

@@ -10,12 +10,11 @@
 	},
 	"runArgs": [
 		"--privileged",
-		"--network=host",
-		"--volume=/dev/bus/usb:/dev/bus/usb:ro",
 		// arch tty* is owned by uucp (986)
-		// debian tty* is owned by dialout (20)
-		"--group-add=20",
-		"--group-add=986"
+		// debian tty* is owned by uucp (20) - no change needed
+		"--group-add=986",
+		"--network=host",
+		"--volume=/dev/bus/usb:/dev/bus/usb:ro"
 	],
 	"postCreateCommand": {
 		"platformio": "pipx install platformio"

README.md

@@ -39,11 +39,9 @@ For developers;
 - Clone and open the MeshCore repository in Visual Studio Code.
 - See the example applications you can modify and run:
   - [Companion Radio](./examples/companion_radio) - For use with an external chat app, over BLE, USB or WiFi.
-  - [KISS Modem](./examples/kiss_modem) - Serial KISS protocol bridge for host applications. ([protocol docs](./docs/kiss_modem_protocol.md))
   - [Simple Repeater](./examples/simple_repeater) - Extends network coverage by relaying messages.
   - [Simple Room Server](./examples/simple_room_server) - A simple BBS server for shared Posts.
   - [Simple Secure Chat](./examples/simple_secure_chat) - Secure terminal based text communication between devices.
-  - [Simple Sensor](./examples/simple_sensor) - Remote sensor node with telemetry and alerting.
 
 The Simple Secure Chat example can be interacted with through the Serial Monitor in Visual Studio Code, or with a Serial USB Terminal on Android.
 

boards/meshtiny.json

@@ -1,74 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DARDUINO_NRF52840_FEATHER -DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [
-      [
-        "0x239A",
-        "0x8029"
-      ],
-      [
-        "0x239A",
-        "0x0029"
-      ],
-      [
-        "0x239A",
-        "0x002A"
-      ],
-      [
-        "0x239A",
-        "0x802A"
-      ]
-    ],
-    "usb_product": "Meshtiny",
-    "mcu": "nrf52840",
-    "variant": "meshtiny",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": [
-    "bluetooth"
-  ],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "svd_path": "nrf52840.svd",
-    "openocd_target": "nrf52840-mdk-rs"
-  },
-  "frameworks": [
-    "arduino",
-    "freertos"
-  ],
-  "name": "Meshtiny",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": [
-      "jlink",
-      "nrfjprog",
-      "nrfutil",
-      "stlink"
-    ],
-    "use_1200bps_touch": true,
-    "require_upload_port": true,
-    "wait_for_upload_port": true
-  },
-  "url": "https://shop.mtoolstec.com/product/meshtiny",
-  "vendor": "MTools Tec"
-}

boards/rak3401.json

@@ -1,72 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DARDUINO_NRF52840_FEATHER -DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [
-      [
-        "0x239A",
-        "0x8029"
-      ],
-      [
-        "0x239A",
-        "0x0029"
-      ],
-      [
-        "0x239A",
-        "0x002A"
-      ],
-      [
-        "0x239A",
-        "0x802A"
-      ]
-    ],
-    "usb_product": "WisCore RAK3401 Board",
-    "mcu": "nrf52840",
-    "variant": "WisCore_RAK3401_Board",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": [
-    "bluetooth"
-  ],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "svd_path": "nrf52840.svd"
-  },
-  "frameworks": [
-    "arduino"
-  ],
-  "name": "WisCore RAK3401 Board",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": [
-      "jlink",
-      "nrfjprog",
-      "nrfutil",
-      "stlink"
-    ],
-    "use_1200bps_touch": true,
-    "require_upload_port": true,
-    "wait_for_upload_port": true
-  },
-  "url": "https://www.rakwireless.com",
-  "vendor": "RAKwireless"
-}

boards/t_beam_1w.json

@@ -1,50 +0,0 @@
-{
-    "build": {
-        "arduino": {
-            "ldscript": "esp32s3_out.ld",
-            "memory_type": "qio_opi"
-        },
-        "core": "esp32",
-        "extra_flags": [
-            "-DBOARD_HAS_PSRAM",
-            "-DLILYGO_TBEAM_1W",
-            "-DARDUINO_USB_CDC_ON_BOOT=1",
-            "-DARDUINO_USB_MODE=0",
-            "-DARDUINO_RUNNING_CORE=1",
-            "-DARDUINO_EVENT_RUNNING_CORE=1"
-        ],
-        "f_cpu": "240000000L",
-        "f_flash": "80000000L",
-        "flash_mode": "qio",
-        "psram_type": "opi",
-        "hwids": [
-            [
-                "0x303A",
-                "0x1001"
-            ]
-        ],
-        "mcu": "esp32s3",
-        "variant": "lilygo_tbeam_1w"
-    },
-    "connectivity": [
-        "wifi",
-        "bluetooth",
-        "lora"
-    ],
-    "debug": {
-        "openocd_target": "esp32s3.cfg"
-    },
-    "frameworks": [
-        "arduino"
-    ],
-    "name": "LilyGo TBeam-1W",
-    "upload": {
-        "flash_size": "16MB",
-        "maximum_ram_size": 327680,
-        "maximum_size": 16777216,
-        "require_upload_port": true,
-        "speed": 921600
-    },
-    "url": "http://www.lilygo.cn/",
-    "vendor": "LilyGo"
-}

build.sh

@@ -7,7 +7,6 @@ sh build.sh <command> [target]
 
 Commands:
   help|usage|-h|--help: Shows this message.
-  list|-l: List firmwares available to build.
   build-firmware <target>: Build the firmware for the given build target.
   build-firmwares: Build all firmwares for all targets.
   build-matching-firmwares <build-match-spec>: Build all firmwares for build targets containing the string given for <build-match-spec>.
@@ -30,41 +29,23 @@ $ sh build.sh build-repeater-firmwares
 
 Build all chat room server firmwares
 $ sh build.sh build-room-server-firmwares
-
-Environment Variables:
-  DISABLE_DEBUG=1: Disables all debug logging flags (MESH_DEBUG, MESH_PACKET_LOGGING, etc.)
-                   If not set, debug flags from variant platformio.ini files are used.
-
-Examples:
-Build without debug logging:
-$ export FIRMWARE_VERSION=v1.0.0
-$ export DISABLE_DEBUG=1
-$ sh build.sh build-firmware RAK_4631_repeater
-
-Build with debug logging (default, uses flags from variant files):
-$ export FIRMWARE_VERSION=v1.0.0
-$ sh build.sh build-firmware RAK_4631_repeater
 EOF
 }
 
-# get a list of pio env names that start with "env:"
-get_pio_envs() {
-  pio project config | grep 'env:' | sed 's/env://'
-}
-
 # Catch cries for help before doing anything else.
 case $1 in
   help|usage|-h|--help)
     global_usage
     exit 1
     ;;
-  list|-l)
-    get_pio_envs
-    exit 0
-    ;;
 esac
 
 
+# get a list of pio env names that start with "env:"
+get_pio_envs() {
+  echo $(pio project config | grep 'env:' | sed 's/env://')
+}
+
 # $1 should be the string to find (case insensitive)
 get_pio_envs_containing_string() {
   shopt -s nocasematch
@@ -87,13 +68,6 @@ get_pio_envs_ending_with_string() {
   done
 }
 
-# disable all debug logging flags if DISABLE_DEBUG=1 is set
-disable_debug_flags() {
-  if [ "$DISABLE_DEBUG" == "1" ]; then
-    export PLATFORMIO_BUILD_FLAGS="${PLATFORMIO_BUILD_FLAGS} -UMESH_DEBUG -UBLE_DEBUG_LOGGING -UWIFI_DEBUG_LOGGING -UBRIDGE_DEBUG -UGPS_NMEA_DEBUG -UCORE_DEBUG_LEVEL -UESPNOW_DEBUG_LOGGING -UDEBUG_RP2040_WIRE -UDEBUG_RP2040_SPI -UDEBUG_RP2040_CORE -UDEBUG_RP2040_PORT -URADIOLIB_DEBUG_SPI -UCFG_DEBUG -URADIOLIB_DEBUG_BASIC -URADIOLIB_DEBUG_PROTOCOL"
-  fi
-}
-
 # build firmware for the provided pio env in $1
 build_firmware() {
 
@@ -120,9 +94,6 @@ build_firmware() {
   # add firmware version info to end of existing platformio build flags in environment vars
   export PLATFORMIO_BUILD_FLAGS="${PLATFORMIO_BUILD_FLAGS} -DFIRMWARE_BUILD_DATE='\"${FIRMWARE_BUILD_DATE}\"' -DFIRMWARE_VERSION='\"${FIRMWARE_VERSION_STRING}\"'"
 
-  # disable debug flags if requested
-  disable_debug_flags
-
   # build firmware target
   pio run -e $1
 

docs/cli_commands.md

@@ -1,881 +0,0 @@
-# MeshCore Repeater & Room Server CLI Commands
-
-## Navigation
-
-- [Operational](#operational)
-- [Neighbors](#neighbors-repeater-only)
-- [Statistics](#statistics)
-- [Logging](#logging)
-- [Information](#info)
-- [Configuration](#configuration)
-  - [Radio](#radio)
-  - [System](#system)
-  - [Routing](#routing)
-  - [ACL](#acl)
-  - [Region Management](#region-management-v110)
-    - [Region Examples](#region-examples)
-  - [GPS](#gps-when-gps-support-is-compiled-in)
-  - [Sensors](#sensors-when-sensor-support-is-compiled-in)
-  - [Bridge](#bridge-when-bridge-support-is-compiled-in)
-
----
-
-## Operational
-
-### Reboot the node
-**Usage:** 
-- `reboot`
-
----
-
-### Reset the clock and reboot
-**Usage:**
-- `clkreboot`
-
----
-
-### Sync the clock with the remote device
-**Usage:** 
-- `clock sync`
-
----
-
-### Display current time in UTC
-**Usage:**
-- `clock`
-
----
-
-### Set the time to a specific timestamp
-**Usage:** 
-- `time <epoch_seconds>`
-
-**Parameters:**
-- `epoc_seconds`: Unix epoc time
-
----
-
-### Send a flood advert
-**Usage:** 
-- `advert`
-
----
-
-### Start an Over-The-Air (OTA) firmware update
-**Usage:**
-- `start ota`
-
----
-
-### Erase/Factory Reset
-**Usage:**
-- `erase`
-
-**Serial Only:** Yes
-
-**Warning:** _**This is destructive!**_
-
----
-
-## Neighbors (Repeater Only)
-
-### List nearby neighbors
-**Usage:** 
-- `neighbors`
-
-**Note:** The output of this command is limited to the 8 most recent adverts.
-
-**Note:** Each line is encoded as `{pubkey-prefix}:{timestamp}:{snr*4}`
-
----
-
-### Remove a neighbor
-**Usage:** 
-- `neighbor.remove <pubkey_prefix>`
-
-**Parameters:** 
-- `pubkey_prefix`: The public key of the node to remove from the neighbors list
-
----
-
-## Statistics
-
-### Clear Stats
-**Usage:** `clear stats`
-
----
-
-### System Stats - Battery, Uptime, Queue Length and Debug Flags
-**Usage:** 
-- `stats-core`
-
-**Serial Only:** Yes
-
----
-
-### Radio Stats - Noise floor, Last RSSI/SNR, Airtime, Receive errors
-**Usage:** `stats-radio`
-
-**Serial Only:** Yes
-
----
-
-### Packet stats - Packet counters: Received, Sent
-**Usage:** `stats-packets`
-
-**Serial Only:** Yes
-
----
-
-## Logging
-
-### Begin capture of rx log to node storage
-**Usage:** `log start`
-
----
-
-### End capture of rx log to node sotrage
-**Usage:** `log stop`
-
----
-
-### Erase captured log
-**Usage:** `log erase`
-
----
-
-### Print the captured log to the serial terminal
-**Usage:** `log`
-
-**Serial Only:** Yes
-
----
-
-## Info
-
-### Get the Version
-**Usage:** `ver`
-
----
-
-### Show the hardware name
-**Usage:** `board`
-
----
-
-## Configuration
-
-### Radio
-
-#### View or change this node's radio parameters
-**Usage:**
-- `get radio`
-- `set radio <freq>,<bw>,<sf>,<cr>`
-
-**Parameters:**
-- `freq`: Frequency in MHz
-- `bw`: Bandwidth in kHz
-- `sf`: Spreading factor (5-12)
-- `cr`: Coding rate (5-8)
-
-**Set by build flag:** `LORA_FREQ`, `LORA_BW`, `LORA_SF`, `LORA_CR`
-
-**Default:** `869.525,250,11,5`
-
-**Note:** Requires reboot to apply
-
----
-
-#### View or change this node's transmit power
-**Usage:**
-- `get tx`
-- `set tx <dbm>`
-
-**Parameters:**
-- `dbm`: Power level in dBm (1-22)
-
-**Set by build flag:** `LORA_TX_POWER`
-
-**Default:** Varies by board
-
-**Notes:** This setting only controls the power level of the LoRa chip. Some nodes have an additional power amplifier stage which increases the total output. Referr to the node's manual for the correct setting to use. **Setting a value too high may violate the laws in your country.**
-
----
-
-#### Change the radio parameters for a set duration
-**Usage:** 
-- `tempradio <freq>,<bw>,<sf>,<cr>,<timeout_mins>`
-
-**Parameters:**
-- `freq`: Frequency in MHz (300-2500)
-- `bw`: Bandwidth in kHz (7.8-500)
-- `sf`: Spreading factor (5-12)
-- `cr`: Coding rate (5-8)
-- `timeout_mins`: Duration in minutes (must be > 0)
-
-**Note:** This is not saved to preferences and will clear on reboot
-
----
-
-#### View or change this node's frequency
-**Usage:**
-- `get freq`
-- `set freq <frequency>`
-
-**Parameters:**
-- `frequency`: Frequency in MHz
-
-**Default:** `869.525`
-
-**Note:** Requires reboot to apply
-
-### System
-
-#### View or change this node's name
-**Usage:**
-- `get name`
-- `set name <name>`
-
-**Parameters:**
-- `name`: Node name
-
-**Set by build flag:** `ADVERT_NAME`
-
-**Default:** Varies by board
-
-**Note:** Max length varies. If a location is set, the max length is 24 bytes; 32 otherwise. Emoji and unicode characters may take more than one byte.
-
----
-
-#### View or change this node's latitude
-**Usage:**
-- `get lat`
-- `set lat <degrees>`
-
-**Set by build flag:** `ADVERT_LAT`
-
-**Default:** `0`
-
-**Parameters:**
-- `degrees`: Latitude in degrees
-
----
-
-#### View or change this node's longitude
-**Usage:**
-- `get lon`
-- `set lon <degrees>`
-
-**Set by build flag:** `ADVERT_LON`
-
-**Default:** `0`
-
-**Parameters:**
-- `degrees`: Longitude in degrees
-
----
-
-#### View or change this node's identity (Private Key)
-**Usage:**
-- `get prv.key`
-- `set prv.key <private_key>`
-
-**Parameters:**
-- `private_key`: Private key in hex format (64 hex characters)
-
-**Serial Only:**
-- `get prv.key`: Yes
-- `set prv.key`: No
-
-**Note:** Requires reboot to take effect after setting
-
----
-
-#### View or change this node's admin password
-**Usage:**
-- `get password`
-- `set password <password>`
-
-**Parameters:**
-- `password`: Admin password
-
-**Set by build flag:** `ADMIN_PASSWORD`
-
-**Default:** `password`
-
-**Note:** Echoed back for confirmation
-
-**Note:** Any node using this password will be added to the admin ACL list.
-
----
-
-#### View or change this node's guest password
-**Usage:**
-- `get guest.password`
-- `set guest.password <password>`
-
-**Parameters:**
-- `password`: Guest password
-
-**Set by build flag:** `ROOM_PASSWORD` (Room Server only)
-
-**Default:** `<blank>`
-
----
-
-#### View or change this node's owner info
-**Usage:**
-- `get owner.info`
-- `set owner.info <text>`
-
-**Parameters:**
-- `text`: Owner information text
-
-**Default:** `<blank>`
-
-**Note:** `|` characters are translated to newlines
-
-**Note:** Requires firmware 1.12.+
-
----
-
-#### Fine-tune the battery reading
-**Usage:**
-- `get adc.multiplier`
-- `set adc.multiplier <value>`
-
-**Parameters:**
-- `value`: ADC multiplier (0.0-10.0)
-
-**Default:** `0.0` (value defined by board)
-
-**Note:** Returns "Error: unsupported by this board" if hardware doesn't support it
-
----
-
-#### View or change this node's power saving flag (Repeater Only)
-**Usage:**
-- `powersaving <state>`
-- `powersaving`
-
-**Parameters:** 
-- `state`: `on`|`off` 
-
-**Default:** `on`
-
-**Note:** When enabled, device enters sleep mode between radio transmissions
-
----
-
-### Routing
-
-#### View or change this node's repeat flag
-**Usage:**
-- `get repeat`
-- `set repeat <state>`
-
-**Parameters:**
-  - `state`: `on`|`off`
-
-**Default:** `on`
-
----
-
-#### View or change the retransmit delay factor for flood traffic
-**Usage:**
-- `get txdelay`
-- `set txdelay <value>`
-
-**Parameters:**
-- `value`: Transmit delay factor (0-2)
-
-**Default:** `0.5`
-
----
-
-#### View or change the retransmit delay factor for direct traffic
-**Usage:**
-- `get direct.txdelay`
-- `set direct.txdelay <value>`
-
-**Parameters:**
-- `value`: Direct transmit delay factor (0-2)
-
-**Default:** `0.2`
-
----
-
-#### [Experimental] View or change the processing delay for received traffic
-**Usage:**
-- `get rxdelay`
-- `set rxdelay <value>`
-
-**Parameters:**
-- `value`: Receive delay base (0-20)
-
-**Default:** `0.0`
-
----
-
-#### View or change the airtime factor (duty cycle limit)
-**Usage:**
-- `get af`
-- `set af <value>`
-
-**Parameters:**
-- `value`: Airtime factor (0-9)
-
-**Default:** `1.0`
-
----
-
-#### View or change the local interference threshold
-**Usage:**
-- `get int.thresh`
-- `set int.thresh <value>`
-
-**Parameters:**
-- `value`: Interference threshold value
-
-**Default:** `0.0`
-
----
-
-#### View or change the AGC Reset Interval
-**Usage:**
-- `get agc.reset.interval`
-- `set agc.reset.interval <value>`
-
-**Parameters:**
-- `value`: Interval in seconds rounded down to a multiple of 4 (17 becomes 16)
-
-**Default:** `0.0`
-
----
-
-#### Enable or disable Multi-Acks support
-**Usage:**
-- `get multi.acks`
-- `set multi.acks <state>`
-
-**Parameters:**
-- `state`: `0` (disable) or `1` (enable)
-
-**Default:** `0`
-
----
-
-#### View or change the flood advert interval
-**Usage:**
-- `get flood.advert.interval`
-- `set flood.advert.interval <hours>`
-
-**Parameters:**
-- `hours`: Interval in hours (3-168)
-
-**Default:** `12` (Repeater) - `0` (Sensor)
-
----
-
-#### View or change the zero-hop advert interval
-**Usage:**
-- `get advert.interval`
-- `set advert.interval <minutes>`
-
-**Parameters:**
-- `minutes`: Interval in minutes rounded down to the nearest multiple of 2 (61 becomes 60) (60-240)
-
-**Default:** `0`
-
----
-
-#### Limit the number of hops for a flood message
-**Usage:**
-- `get flood.max`
-- `set flood.max <value>`
-
-**Parameters:**
-- `value`: Maximum flood hop count (0-64)
-
-**Default:** `64`
-
----
-
-### ACL
-
-#### Add, update or remove permissions for a companion
-**Usage:** 
-- `setperm <pubkey> <permissions>`
-
-**Parameters:**
-- `pubkey`: Companion public key
-- `permissions`: 
-  - `0`: Guest
-  - `1`: Read-only
-  - `2`: Read-write
-  - `3`: Admin
-
-**Note:** Removes the entry when `permissions` is omitted
-
----
-
-#### View the current ACL
-**Usage:** 
-- `get acl`
-
-**Serial Only:** Yes
-
----
-
-#### View or change this room server's 'read-only' flag
-**Usage:**
-- `get allow.read.only`
-- `set allow.read.only <state>`
-
-**Parameters:**
-- `state`: `on` (enable) or `off` (disable)
-
-**Default:** `off`
-
----
-
-### Region Management (v1.10.+)
-
-#### Bulk-load region lists
-**Usage:** 
-- `region load`
-- `region load <name> [flood_flag]`
-
-**Parameters:**
-- `name`: A name of a region. `*` represents the wildcard region
-
-**Note:** `flood_flag`: Optional `F` to allow flooding
-
-**Note:** Indentation creates parent-child relationships (max 8 levels)
-
-**Note:** `region load` with an empty name will not work remotely (it's interactive)
-
----
-
-#### Save any changes to regions made since reboot
-**Usage:** 
-- `region save`
-
----
-
-#### Allow a region
-**Usage:** 
-- `region allowf <name>`
-
-**Parameters:** 
-- `name`: Region name (or `*` for wildcard)
-
-**Note:** Setting on wildcard `*` allows packets without region transport codes
-
----
-
-#### Block a region
-**Usage:** 
-- `region denyf <name>`
-
-**Parameters:** 
-- `name`: Region name (or `*` for wildcard)
-
-**Note:** Setting on wildcard `*` drops packets without region transport codes
-
----
-
-#### Show information for a region
-**Usage:** 
-- `region get <name>`
-
-**Parameters:**
-- `name`: Region name (or `*` for wildcard)
-
----
-
-#### View or change the home region for this node
-**Usage:** 
-- `region home`
-- `region home <name>`
-
-**Parameters:**
-- `name`: Region name
-
----
-
-#### Create a new region
-**Usage:** 
-- `region put <name> [parent_name]`
-
-**Parameters:**
-- `name`: Region name
-- `parent_name`: Parent region name (optional, defaults to wildcard)
-
----
-
-#### Remove a region
-**Usage:** 
-- `region remove <name>`
-
-**Parameters:**
-- `name`: Region name
-
-**Note:** Must remove all child regions before the region can be removed 
-
----
-
-#### View all regions
-**Usage:** 
-- `region list <filter>`
-
-**Serial Only:** Yes
-
-**Parameters:**
-- `filter`: `allowed`|`denied`
-
-**Note:** Requires firmware 1.12.+
-
----
-
-#### Dump all defined regions and flood permissions
-**Usage:** 
-- `region`
-
-**Serial Only:** Yes
-
----
-
-### Region Examples
-
-**Example 1: Using F Flag with Named Public Region**
-```
-region load
-#Europe F
-<blank line to end region load>
-region save
-```
-
-**Explanation:**
-- Creates a region named `#Europe` with flooding enabled
-- Packets from this region will be flooded to other nodes
-
----
-
-**Example 2: Using Wildcard with F Flag**
-```
-region load 
-* F
-<blank line to end region load>
-region save
-```
-
-**Explanation:**
-- Creates a wildcard region `*` with flooding enabled
-- Enables flooding for all regions automatically
-- Applies only to packets without transport codes
-
----
-
-**Example 3: Using Wildcard Without F Flag**
-```
-region load 
-*
-<blank line to end region load>
-region save
-```
-**Explanation:**
-- Creates a wildcard region `*` without flooding
-- This region exists but doesn't affect packet distribution
-- Used as a default/empty region
-
----
-
-**Example 4: Nested Public Region with F Flag**
-```
-region load 
-#Europe F
-  #UK
-    #London
-    #Manchester
-  #France
-    #Paris
-    #Lyon
-<blank line to end region load>
-region save
-```
-
-**Explanation:**
-- Creates `#Europe` region with flooding enabled
-- Adds nested child regions (`#UK`, `#France`)
-- All nested regions inherit the flooding flag from parent
-
----
-
-**Example 5: Wildcard with Nested Public Regions**
-```
-region load 
-* F
-  #NorthAmerica
-    #USA
-      #NewYork
-      #California
-    #Canada
-      #Ontario
-      #Quebec
-<blank line to end region load>
-region save
-```
-
-**Explanation:**
-- Creates wildcard region `*` with flooding enabled
-- Adds nested `#NorthAmerica` hierarchy
-- Enables flooding for all child regions automatically
-- Useful for global networks with specific regional rules
-
----
-### GPS (When GPS support is compiled in)
-
-#### View or change GPS state
-**Usage:**
-- `gps`
-- `gps <state>`
-
-**Parameters:**
-- `state`: `on`|`off`
-
-**Default:** `off`
-
-**Note:** Output format: `{status}, {fix}, {sat count}` (when enabled)
-
----
-
-#### Sync this node's clock with GPS time
-**Usage:** 
-- `gps sync`
-
----
-
-#### Set this node's location based on the GPS coordinates
-**Usage:** 
-- `gps setloc`
-
----
-
-#### View or change the GPS advert policy
-**Usage:**
-- `gps advert`
-- `gps advert <policy>`
-
-**Parameters:** 
-- `policy`: `none`|`shared`|`prefs` 
-  - `none`: don't include location in adverts
-  - `share`: share gps location (from SensorManager)
-  - `prefs`: location stored in node's lat and lon settings
-
-**Default:** `prefs`
-
----
-
-### Sensors (When sensor support is compiled in)
-
-#### View the list of sensors on this node
-**Usage:** `sensor list [start]`
-
-**Parameters:**
-- `start`: Optional starting index (defaults to 0)
-
-**Note:** Output format: `<var_name>=<value>\n`
-
----
-
-#### View or change thevalue of a sensor
-**Usage:** 
-- `sensor get <key>`
-- `sensor set <key> <value>`
-
-**Parameters:**
-- `key`: Sensor setting name
-- `value`: The value to set the sensor to
-
----
-
-### Bridge (When bridge support is compiled in)
-
-#### View or change the bridge enabled flag
-**Usage:**
-- `get bridge.enabled`
-- `set bridge.enabled <state>`
-
-**Parameters:**
-- `state`: `on`|`off`
-
-**Default:** `off`
-
----
-
-#### View the bridge source
-**Usage:**
-- `get bridge.source`
-
----
-
-#### Add a delay to packets routed through this bridge
-**Usage:**
-- `get bridge.delay`
-- `set bridge.delay <ms>`
-
-**Parameters:**
-- `ms`: Delay in milliseconds (0-10000)
-
-**Default:** `500`
-
----
-
-#### View or change the source of packets bridged to the external interface
-**Usage:**
-- `get bridge.source`
-- `set bridge.source <source>`
-
-**Parameters:**
-- `source`: 
-  - `rx`: bridges received packets
-  - `tx`: bridges transmitted packets
-
-**Default:** `tx`
-
----
-
-#### View or change the speed of the bridge (RS-232 only)
-**Usage:**
-- `get bridge.baud`
-- `set bridge.baud <rate>`
-
-**Parameters:**
-- `rate`: Baud rate (`9600`, `19200`, `38400`, `57600`, or `115200`)
-
-**Default:** `115200`
-
----
-
-#### View or change the channel used for bridging (ESPNow only)
-**Usage:**
-- `get bridge.channel`
-- `set bridge.channel <channel>`
-
-**Parameters:**
-- `channel`: Channel number (1-14)
-
----
-
-#### Set the ESP-Now secret
-**Usage:** 
-- `get bridge.secret`
-- `set bridge.secret <secret>`
-
-**Parameters:**
-- `secret`: 16-character encryption secret
-
-**Default:** Varies by board
-
----

docs/kiss_modem_protocol.md

@@ -1,282 +0,0 @@
-# MeshCore KISS Modem Protocol
-
-Standard KISS TNC firmware for MeshCore LoRa radios. Compatible with any KISS client (Direwolf, APRSdroid, YAAC, etc.) for sending and receiving raw packets. MeshCore-specific extensions (cryptography, radio configuration, telemetry) are available through the standard SetHardware (0x06) command.
-
-## Serial Configuration
-
-115200 baud, 8N1, no flow control.
-
-## Frame Format
-
-Standard KISS framing per the KA9Q/K3MC specification.
-
-| Byte | Name | Description |
-|------|------|-------------|
-| `0xC0` | FEND | Frame delimiter |
-| `0xDB` | FESC | Escape character |
-| `0xDC` | TFEND | Escaped FEND (FESC + TFEND = 0xC0) |
-| `0xDD` | TFESC | Escaped FESC (FESC + TFESC = 0xDB) |
-
-```
-┌──────┬───────────┬──────────────┬──────┐
-│ FEND │ Type Byte │ Data (escaped)│ FEND │
-│ 0xC0 │  1 byte   │ 0-510 bytes  │ 0xC0 │
-└──────┴───────────┴──────────────┴──────┘
-```
-
-### Type Byte
-
-The type byte is split into two nibbles:
-
-| Bits | Field | Description |
-|------|-------|-------------|
-| 7-4 | Port | Port number (0 for single-port TNC) |
-| 3-0 | Command | Command number |
-
-Maximum unescaped frame size: 512 bytes.
-
-## Standard KISS Commands
-
-### Host to TNC
-
-| Command | Value | Data | Description |
-|---------|-------|------|-------------|
-| Data | `0x00` | Raw packet | Queue packet for transmission |
-| TXDELAY | `0x01` | Delay (1 byte) | Transmitter keyup delay in 10ms units (default: 50 = 500ms) |
-| Persistence | `0x02` | P (1 byte) | CSMA persistence parameter 0-255 (default: 63) |
-| SlotTime | `0x03` | Interval (1 byte) | CSMA slot interval in 10ms units (default: 10 = 100ms) |
-| TXtail | `0x04` | Delay (1 byte) | Post-TX hold time in 10ms units (default: 0) |
-| FullDuplex | `0x05` | Mode (1 byte) | 0 = half duplex, nonzero = full duplex (default: 0) |
-| SetHardware | `0x06` | Sub-command + data | MeshCore extensions (see below) |
-| Return | `0xFF` | - | Exit KISS mode (no-op) |
-
-### TNC to Host
-
-| Type | Value | Data | Description |
-|------|-------|------|-------------|
-| Data | `0x00` | Raw packet | Received packet from radio |
-
-Data frames carry raw packet data only, with no metadata prepended. The Data command payload is limited to 255 bytes to match the MeshCore maximum transmission unit (MAX_TRANS_UNIT); frames larger than 255 bytes are silently dropped. The KISS specification recommends at least 1024 bytes for general-purpose TNCs; this modem is intended for MeshCore packets only, whose protocol MTU is 255 bytes.
-
-### CSMA Behavior
-
-The TNC implements p-persistent CSMA for half-duplex operation:
-
-1. When a packet is queued, monitor carrier detect
-2. When the channel clears, generate a random value 0-255
-3. If the value is less than or equal to P (Persistence), wait TXDELAY then transmit
-4. Otherwise, wait SlotTime and repeat from step 1
-
-In full-duplex mode, CSMA is bypassed and packets transmit after TXDELAY.
-
-## SetHardware Extensions (0x06)
-
-MeshCore-specific functionality uses the standard KISS SetHardware command. The first byte of SetHardware data is a sub-command. Standard KISS clients ignore these frames.
-
-### Frame Format
-
-```
-┌──────┬──────┬─────────────┬──────────────┬──────┐
-│ FEND │ 0x06 │ Sub-command  │ Data (escaped)│ FEND │
-│ 0xC0 │      │   1 byte    │   variable   │ 0xC0 │
-└──────┴──────┴─────────────┴──────────────┴──────┘
-```
-
-### Request Sub-commands (Host to TNC)
-
-| Sub-command | Value | Data |
-|-------------|-------|------|
-| GetIdentity | `0x01` | - |
-| GetRandom | `0x02` | Length (1 byte, 1-64) |
-| VerifySignature | `0x03` | PubKey (32) + Signature (64) + Data |
-| SignData | `0x04` | Data to sign |
-| EncryptData | `0x05` | Key (32) + Plaintext |
-| DecryptData | `0x06` | Key (32) + MAC (2) + Ciphertext |
-| KeyExchange | `0x07` | Remote PubKey (32) |
-| Hash | `0x08` | Data to hash |
-| SetRadio | `0x09` | Freq (4) + BW (4) + SF (1) + CR (1) |
-| SetTxPower | `0x0A` | Power dBm (1) |
-| GetRadio | `0x0B` | - |
-| GetTxPower | `0x0C` | - |
-| GetCurrentRssi | `0x0D` | - |
-| IsChannelBusy | `0x0E` | - |
-| GetAirtime | `0x0F` | Packet length (1) |
-| GetNoiseFloor | `0x10` | - |
-| GetVersion | `0x11` | - |
-| GetStats | `0x12` | - |
-| GetBattery | `0x13` | - |
-| GetMCUTemp | `0x14` | - |
-| GetSensors | `0x15` | Permissions (1) |
-| GetDeviceName | `0x16` | - |
-| Ping | `0x17` | - |
-| Reboot | `0x18` | - |
-| SetSignalReport | `0x19` | Enable (1): 0x00=disable, nonzero=enable |
-| GetSignalReport | `0x1A` | - |
-
-### Response Sub-commands (TNC to Host)
-
-Response codes use the high-bit convention: `response = command | 0x80`. Generic and unsolicited responses use the `0xF0`+ range.
-
-| Sub-command | Value | Data |
-|-------------|-------|------|
-| Identity | `0x81` | PubKey (32) |
-| Random | `0x82` | Random bytes (1-64) |
-| Verify | `0x83` | Result (1): 0x00=invalid, 0x01=valid |
-| Signature | `0x84` | Signature (64) |
-| Encrypted | `0x85` | MAC (2) + Ciphertext |
-| Decrypted | `0x86` | Plaintext |
-| SharedSecret | `0x87` | Shared secret (32) |
-| Hash | `0x88` | SHA-256 hash (32) |
-| Radio | `0x8B` | Freq (4) + BW (4) + SF (1) + CR (1) |
-| TxPower | `0x8C` | Power dBm (1) |
-| CurrentRssi | `0x8D` | RSSI dBm (1, signed) |
-| ChannelBusy | `0x8E` | Result (1): 0x00=clear, 0x01=busy |
-| Airtime | `0x8F` | Milliseconds (4) |
-| NoiseFloor | `0x90` | dBm (2, signed) |
-| Version | `0x91` | Version (1) + Reserved (1) |
-| Stats | `0x92` | RX (4) + TX (4) + Errors (4) |
-| Battery | `0x93` | Millivolts (2) |
-| MCUTemp | `0x94` | Temperature (2, signed) |
-| Sensors | `0x95` | CayenneLPP payload |
-| DeviceName | `0x96` | Name (variable, UTF-8) |
-| Pong | `0x97` | - |
-| SignalReport | `0x9A` | Status (1): 0x00=disabled, 0x01=enabled |
-| OK | `0xF0` | - |
-| Error | `0xF1` | Error code (1) |
-| TxDone | `0xF8` | Result (1): 0x00=failed, 0x01=success |
-| RxMeta | `0xF9` | SNR (1) + RSSI (1) |
-
-### Error Codes
-
-| Code | Value | Description |
-|------|-------|-------------|
-| InvalidLength | `0x01` | Request data too short |
-| InvalidParam | `0x02` | Invalid parameter value |
-| NoCallback | `0x03` | Feature not available |
-| MacFailed | `0x04` | MAC verification failed |
-| UnknownCmd | `0x05` | Unknown sub-command |
-| EncryptFailed | `0x06` | Encryption failed |
-
-### Unsolicited Events
-
-The TNC sends these SetHardware frames without a preceding request:
-
-**TxDone (0xF8)**: Sent after a packet has been transmitted. Contains a single byte: 0x01 for success, 0x00 for failure.
-
-**RxMeta (0xF9)**: Sent immediately after each standard data frame (type 0x00) with metadata for the received packet. Contains SNR (1 byte, signed, value x4 for 0.25 dB precision) followed by RSSI (1 byte, signed, dBm). Enabled by default; can be toggled with SetSignalReport. Standard KISS clients ignore this frame.
-
-## Data Formats
-
-### Radio Parameters (SetRadio / Radio response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Frequency | 4 bytes | Hz (e.g., 869618000) |
-| Bandwidth | 4 bytes | Hz (e.g., 62500) |
-| SF | 1 byte | Spreading factor (5-12) |
-| CR | 1 byte | Coding rate (5-8) |
-
-### Version (Version response)
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Version | 1 byte | Firmware version |
-| Reserved | 1 byte | Always 0 |
-
-### Encrypted (Encrypted response)
-
-| Field | Size | Description |
-|-------|------|-------------|
-| MAC | 2 bytes | HMAC-SHA256 truncated to 2 bytes |
-| Ciphertext | variable | AES-128-CBC encrypted data |
-
-### Airtime (Airtime response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Airtime | 4 bytes | uint32_t, estimated air time in milliseconds |
-
-### Noise Floor (NoiseFloor response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Noise floor | 2 bytes | int16_t, dBm (signed) |
-
-The modem recalibrates the noise floor every 2 seconds with an AGC reset every 30 seconds.
-
-### Stats (Stats response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| RX | 4 bytes | Packets received |
-| TX | 4 bytes | Packets transmitted |
-| Errors | 4 bytes | Receive errors |
-
-### Battery (Battery response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Millivolts | 2 bytes | uint16_t, battery voltage in mV |
-
-### MCU Temperature (MCUTemp response)
-
-All values little-endian.
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Temperature | 2 bytes | int16_t, tenths of °C (e.g., 253 = 25.3°C) |
-
-Returns `NoCallback` error if the board does not support temperature readings.
-
-### Device Name (DeviceName response)
-
-| Field | Size | Description |
-|-------|------|-------------|
-| Name | variable | UTF-8 string, no null terminator |
-
-### Reboot
-
-Sends an `OK` response, flushes serial, then reboots the device. The host should expect the connection to drop.
-
-### Sensor Permissions (GetSensors)
-
-| Bit | Value | Description |
-|-----|-------|-------------|
-| 0 | `0x01` | Base (battery) |
-| 1 | `0x02` | Location (GPS) |
-| 2 | `0x04` | Environment (temp, humidity, pressure) |
-
-Use `0x07` for all permissions.
-
-### Sensor Data (Sensors response)
-
-Data returned in CayenneLPP format. See [CayenneLPP documentation](https://docs.mydevices.com/docs/lorawan/cayenne-lpp) for parsing.
-
-## Cryptographic Algorithms
-
-| Operation | Algorithm |
-|-----------|-----------|
-| Identity / Signing / Verification | Ed25519 |
-| Key Exchange | X25519 (ECDH) |
-| Encryption | AES-128-CBC + HMAC-SHA256 (MAC truncated to 2 bytes) |
-| Hashing | SHA-256 |
-
-## Notes
-
-- Data payload limit (255 bytes) matches MeshCore MAX_TRANS_UNIT; no change needed for KISS “1024+ recommended” (that applies to general TNCs, not MeshCore)
-- Modem generates identity on first boot (stored in flash)
-- All multi-byte values are little-endian unless stated otherwise
-- SNR values in RxMeta are multiplied by 4 for 0.25 dB precision
-- TxDone is sent as a SetHardware event after each transmission
-- Standard KISS clients receive only type 0x00 data frames and can safely ignore all SetHardware (0x06) frames
-- See [packet_structure.md](./packet_structure.md) for packet format

docs/nrf52_power_management.md

@@ -1,213 +0,0 @@
-# nRF52 Power Management
-
-## Overview
-
-The nRF52 Power Management module provides battery protection features to prevent over-discharge, minimise likelihood of brownout and flash corruption conditions existing, and enable safe voltage-based recovery.
-
-## Features
-
-### Boot Voltage Protection
-- Checks battery voltage immediately after boot and before mesh operations commence
-- If voltage is below a configurable threshold (e.g., 3300mV), the device configures voltage wake (LPCOMP + VBUS) and enters protective shutdown (SYSTEMOFF)
-- Prevents boot loops when battery is critically low
-- Skipped when external power (USB VBUS) is detected
-
-### Voltage Wake (LPCOMP + VBUS)
-- Configures the nRF52's Low Power Comparator (LPCOMP) before entering SYSTEMOFF
-- Enables USB VBUS detection so external power can wake the device
-- Device automatically wakes when battery voltage rises above recovery threshold or when VBUS is detected
-
-### Early Boot Register Capture
-- Captures RESETREAS (reset reason) and GPREGRET2 (shutdown reason) before SystemInit() clears them
-- Allows firmware to determine why it booted (cold boot, watchdog, LPCOMP wake, etc.)
-- Allows firmware to determine why it last shut down (user request, low voltage, boot protection)
-
-### Shutdown Reason Tracking
-Shutdown reason codes (stored in GPREGRET2):
-| Code | Name | Description |
-|------|------|-------------|
-| 0x00 | NONE | Normal boot / no previous shutdown |
-| 0x4C | LOW_VOLTAGE | Runtime low voltage threshold reached |
-| 0x55 | USER | User requested powerOff() |
-| 0x42 | BOOT_PROTECT | Boot voltage protection triggered |
-
-## Supported Boards
-
-| Board | Implemented | LPCOMP wake | VBUS wake |
-|-------|-------------|-------------|-----------|
-| Seeed Studio XIAO nRF52840 (`xiao_nrf52`) | Yes | Yes | Yes |
-| RAK4631 (`rak4631`) | Yes | Yes | Yes |
-| Heltec T114 (`heltec_t114`) | Yes | Yes | Yes |
-| Promicro nRF52840 | No | No | No |
-| RAK WisMesh Tag | No | No | No |
-| Heltec Mesh Solar | No | No | No |
-| LilyGo T-Echo / T-Echo Lite | No | No | No |
-| SenseCAP Solar | No | No | No |
-| WIO Tracker L1 / L1 E-Ink | No | No | No |
-| WIO WM1110 | No | No | No |
-| Mesh Pocket | No | No | No |
-| Nano G2 Ultra | No | No | No |
-| ThinkNode M1/M3/M6 | No | No | No |
-| T1000-E | No | No | No |
-| Ikoka Nano/Stick/Handheld (nRF) | No | No | No |
-| Keepteen LT1 | No | No | No |
-| Minewsemi ME25LS01 | No | No | No |
-
-Notes:
-- "Implemented" reflects Phase 1 (boot lockout + shutdown reason capture).
-- User power-off on Heltec T114 does not enable LPCOMP wake.
-- VBUS detection is used to skip boot lockout on external power, and VBUS wake is configured alongside LPCOMP when supported hardware exposes VBUS to the nRF52.
-
-## Technical Details
-
-### Architecture
-
-The power management functionality is integrated into the `NRF52Board` base class in `src/helpers/NRF52Board.cpp`. Board variants provide hardware-specific configuration via a `PowerMgtConfig` struct and override `initiateShutdown(uint8_t reason)` to perform board-specific power-down work and conditionally enable voltage wake (LPCOMP + VBUS).
-
-### Early Boot Capture
-
-A static constructor with priority 101 in `NRF52Board.cpp` captures the RESETREAS and GPREGRET2 registers before:
-- SystemInit() (priority 102) - which clears RESETREAS
-- Static C++ constructors (default priority 65535)
-
-This ensures we capture the true reset reason before any initialisation code runs.
-
-### Board Implementation
-
-To enable power management on a board variant:
-
-1. **Enable in platformio.ini**:
-   ```ini
-   -D NRF52_POWER_MANAGEMENT
-   ```
-
-2. **Define configuration in variant.h**:
-   ```c
-   #define PWRMGT_VOLTAGE_BOOTLOCK    3300   // Won't boot below this voltage (mV)
-   #define PWRMGT_LPCOMP_AIN          7      // AIN channel for voltage sensing
-   #define PWRMGT_LPCOMP_REFSEL       2      // REFSEL (0-6=1/8..7/8, 7=ARef, 8-15=1/16..15/16)
-   ```
-
-3. **Implement in board .cpp file**:
-   ```cpp
-   #ifdef NRF52_POWER_MANAGEMENT
-   const PowerMgtConfig power_config = {
-     .lpcomp_ain_channel = PWRMGT_LPCOMP_AIN,
-     .lpcomp_refsel = PWRMGT_LPCOMP_REFSEL,
-     .voltage_bootlock = PWRMGT_VOLTAGE_BOOTLOCK
-   };
-
-   void MyBoard::initiateShutdown(uint8_t reason) {
-     // Board-specific shutdown preparation (e.g., disable peripherals)
-     bool enable_lpcomp = (reason == SHUTDOWN_REASON_LOW_VOLTAGE ||
-                           reason == SHUTDOWN_REASON_BOOT_PROTECT);
-
-     if (enable_lpcomp) {
-       configureVoltageWake(power_config.lpcomp_ain_channel, power_config.lpcomp_refsel);
-     }
-
-     enterSystemOff(reason);
-   }
-   #endif
-
-   void MyBoard::begin() {
-     NRF52Board::begin();  // or NRF52BoardDCDC::begin()
-     // ... board setup ...
-
-   #ifdef NRF52_POWER_MANAGEMENT
-     checkBootVoltage(&power_config);
-   #endif
-   }
-   ```
-
-   For user-initiated shutdowns, `powerOff()` remains board-specific. Power management only arms LPCOMP for automated shutdown reasons (boot protection/low voltage).
-
-4. **Declare override in board .h file**:
-   ```cpp
-   #ifdef NRF52_POWER_MANAGEMENT
-     void initiateShutdown(uint8_t reason) override;
-   #endif
-   ```
-
-### Voltage Wake Configuration
-
-The LPCOMP (Low Power Comparator) is configured to:
-- Monitor the specified AIN channel (0-7 corresponding to P0.02-P0.05, P0.28-P0.31)
-- Compare against VDD fraction reference (REFSEL: 0-6=1/8..7/8, 7=ARef, 8-15=1/16..15/16)
-- Detect UP events (voltage rising above threshold)
-- Use 50mV hysteresis for noise immunity
-- Wake the device from SYSTEMOFF when triggered
-
-VBUS wake is enabled via the POWER peripheral USBDETECTED event whenever `configureVoltageWake()` is used. This requires USB VBUS to be routed to the nRF52 (typical on nRF52840 boards with native USB).
-
-**LPCOMP Reference Selection (PWRMGT_LPCOMP_REFSEL)**:
-| REFSEL | Fraction | VBAT @ 1M/1M divider (VDD=3.0-3.3) | VBAT @ 1.5M/1M divider (VDD=3.0-3.3) |
-|--------|----------|------------------------------------|--------------------------------------|
-| 0 | 1/8 | 0.75-0.82 V | 0.94-1.03 V |
-| 1 | 2/8 | 1.50-1.65 V | 1.88-2.06 V |
-| 2 | 3/8 | 2.25-2.47 V | 2.81-3.09 V |
-| 3 | 4/8 | 3.00-3.30 V | 3.75-4.12 V |
-| 4 | 5/8 | 3.75-4.12 V | 4.69-5.16 V |
-| 5 | 6/8 | 4.50-4.95 V | 5.62-6.19 V |
-| 6 | 7/8 | 5.25-5.77 V | 6.56-7.22 V |
-| 7 | ARef | - | - |
-| 8 | 1/16 | 0.38-0.41 V | 0.47-0.52 V |
-| 9 | 3/16 | 1.12-1.24 V | 1.41-1.55 V |
-| 10 | 5/16 | 1.88-2.06 V | 2.34-2.58 V |
-| 11 | 7/16 | 2.62-2.89 V | 3.28-3.61 V |
-| 12 | 9/16 | 3.38-3.71 V | 4.22-4.64 V |
-| 13 | 11/16 | 4.12-4.54 V | 5.16-5.67 V |
-| 14 | 13/16 | 4.88-5.36 V | 6.09-6.70 V |
-| 15 | 15/16 | 5.62-6.19 V | 7.03-7.73 V |
-
-**Important**: For boards with a voltage divider on the battery sense pin, LPCOMP measures the divided voltage. Use:
-`VBAT_threshold ≈ (VDD * fraction) * divider_scale`, where `divider_scale = (Rtop + Rbottom) / Rbottom` (e.g., 2.0 for 1M/1M, 2.5 for 1.5M/1M, 3.0 for XIAO).
-
-### SoftDevice Compatibility
-
-The power management code checks whether SoftDevice is enabled and uses the appropriate API:
-- When SD enabled: `sd_power_*` functions
-- When SD disabled: Direct register access (NRF_POWER->*)
-
-This ensures compatibility regardless of BLE stack state.
-
-## CLI Commands
-
-Power management status can be queried via the CLI:
-
-| Command | Description |
-|---------|-------------|
-| `get pwrmgt.support` | Returns "supported" or "unsupported" |
-| `get pwrmgt.source` | Returns current power source - "battery" or "external" (5V/USB power) |
-| `get pwrmgt.bootreason` | Returns reset and shutdown reason strings |
-| `get pwrmgt.bootmv` | Returns boot voltage in millivolts |
-
-On boards without power management enabled, all commands except `get pwrmgt.support` return:
-```
-ERROR: Power management not supported
-```
-
-## Debug Output
-
-When `MESH_DEBUG=1` is enabled, the power management module outputs:
-```
-DEBUG: PWRMGT: Reset = Wake from LPCOMP (0x20000); Shutdown = Low Voltage (0x4C)
-DEBUG: PWRMGT: Boot voltage = 3450 mV (threshold = 3300 mV)
-DEBUG: PWRMGT: LPCOMP wake configured (AIN7, ref=3/8 VDD)
-```
-
-## Phase 2 (Planned)
-
-- Runtime voltage monitoring
-- Voltage state machine (Normal -> Warning -> Critical -> Shutdown)
-- Configurable thresholds
-- Load shedding callbacks for power reduction
-- Deep sleep integration
-- Scheduled wake-up
-- Extended sleep with periodic monitoring
-
-## References
-
-- [nRF52840 Product Specification - POWER](https://infocenter.nordicsemi.com/topic/ps_nrf52840/power.html)
-- [nRF52840 Product Specification - LPCOMP](https://infocenter.nordicsemi.com/topic/ps_nrf52840/lpcomp.html)
-- [SoftDevice S140 API - Power Management](https://infocenter.nordicsemi.com/topic/sdk_nrf5_v17.1.0/group__nrf__sdm__api.html)

docs/stats_binary_frames.md

@@ -94,7 +94,7 @@ struct StatsRadio {
 
 ## RESP_CODE_STATS + STATS_TYPE_PACKETS (24, 2)
 
-**Total Frame Size:** 26 bytes (legacy) or 30 bytes (includes `recv_errors`)
+**Total Frame Size:** 26 bytes
 
 | Offset | Size | Type | Field Name | Description | Range/Notes |
 |--------|------|------|------------|-------------|-------------|
@@ -106,14 +106,12 @@ struct StatsRadio {
 | 14 | 4 | uint32_t | direct_tx | Packets sent via direct routing | 0 - 4,294,967,295 |
 | 18 | 4 | uint32_t | flood_rx | Packets received via flood routing | 0 - 4,294,967,295 |
 | 22 | 4 | uint32_t | direct_rx | Packets received via direct routing | 0 - 4,294,967,295 |
-| 26 | 4 | uint32_t | recv_errors | Receive/CRC errors (RadioLib); present only in 30-byte frame | 0 - 4,294,967,295 |
 
 ### Notes
 
 - Counters are cumulative from boot and may wrap.
 - `recv = flood_rx + direct_rx`
 - `sent = flood_tx + direct_tx`
-- Clients should accept frame length ≥ 26; if length ≥ 30, parse `recv_errors` at offset 26.
 
 ### Example Structure (C/C++)
 
@@ -127,7 +125,6 @@ struct StatsPackets {
     uint32_t direct_tx;
     uint32_t flood_rx;
     uint32_t direct_rx;
-    uint32_t recv_errors;    // present when frame size is 30
 } __attribute__((packed));
 ```
 
@@ -186,12 +183,11 @@ def parse_stats_radio(frame):
     }
 
 def parse_stats_packets(frame):
-    """Parse RESP_CODE_STATS + STATS_TYPE_PACKETS frame (26 or 30 bytes)"""
-    assert len(frame) >= 26, "STATS_TYPE_PACKETS frame too short"
+    """Parse RESP_CODE_STATS + STATS_TYPE_PACKETS frame (26 bytes)"""
     response_code, stats_type, recv, sent, flood_tx, direct_tx, flood_rx, direct_rx = \
-        struct.unpack('<B B I I I I I I', frame[:26])
+        struct.unpack('<B B I I I I I I', frame)
     assert response_code == 24 and stats_type == 2, "Invalid response type"
-    result = {
+    return {
         'recv': recv,
         'sent': sent,
         'flood_tx': flood_tx,
@@ -199,10 +195,6 @@ def parse_stats_packets(frame):
         'flood_rx': flood_rx,
         'direct_rx': direct_rx
     }
-    if len(frame) >= 30:
-        (recv_errors,) = struct.unpack('<I', frame[26:30])
-        result['recv_errors'] = recv_errors
-    return result
 ```
 
 ---
@@ -259,7 +251,6 @@ interface StatsPackets {
     direct_tx: number;
     flood_rx: number;
     direct_rx: number;
-    recv_errors?: number;  // present when frame is 30 bytes
 }
 
 function parseStatsCore(buffer: ArrayBuffer): StatsCore {
@@ -295,15 +286,12 @@ function parseStatsRadio(buffer: ArrayBuffer): StatsRadio {
 
 function parseStatsPackets(buffer: ArrayBuffer): StatsPackets {
     const view = new DataView(buffer);
-    if (buffer.byteLength < 26) {
-        throw new Error('STATS_TYPE_PACKETS frame too short');
-    }
     const response_code = view.getUint8(0);
     const stats_type = view.getUint8(1);
     if (response_code !== 24 || stats_type !== 2) {
         throw new Error('Invalid response type');
     }
-    const result: StatsPackets = {
+    return {
         recv: view.getUint32(2, true),
         sent: view.getUint32(6, true),
         flood_tx: view.getUint32(10, true),
@@ -311,10 +299,6 @@ function parseStatsPackets(buffer: ArrayBuffer): StatsPackets {
         flood_rx: view.getUint32(18, true),
         direct_rx: view.getUint32(22, true)
     };
-    if (buffer.byteLength >= 30) {
-        result.recv_errors = view.getUint32(26, true);
-    }
-    return result;
 }
 ```
 

examples/companion_radio/DataStore.cpp

@@ -227,7 +227,6 @@ void DataStore::loadPrefsInt(const char *filename, NodePrefs& _prefs, double& no
     file.read((uint8_t *)&_prefs.buzzer_quiet, sizeof(_prefs.buzzer_quiet));               // 84
     file.read((uint8_t *)&_prefs.gps_enabled, sizeof(_prefs.gps_enabled));                 // 85
     file.read((uint8_t *)&_prefs.gps_interval, sizeof(_prefs.gps_interval));               // 86
-    file.read((uint8_t *)&_prefs.autoadd_config, sizeof(_prefs.autoadd_config));           // 87
 
     file.close();
   }
@@ -262,7 +261,6 @@ void DataStore::savePrefs(const NodePrefs& _prefs, double node_lat, double node_
     file.write((uint8_t *)&_prefs.buzzer_quiet, sizeof(_prefs.buzzer_quiet));               // 84
     file.write((uint8_t *)&_prefs.gps_enabled, sizeof(_prefs.gps_enabled));                 // 85
     file.write((uint8_t *)&_prefs.gps_interval, sizeof(_prefs.gps_interval));               // 86
-    file.write((uint8_t *)&_prefs.autoadd_config, sizeof(_prefs.autoadd_config));           // 87
 
     file.close();
   }
@@ -560,20 +558,14 @@ bool DataStore::putBlobByKey(const uint8_t key[], int key_len, const uint8_t src
   }
   return false; // error
 }
-bool DataStore::deleteBlobByKey(const uint8_t key[], int key_len) {
-  return true; // this is just a stub on NRF52/STM32 platforms
-}
 #else
-inline void makeBlobPath(const uint8_t key[], int key_len, char* path, size_t path_size) {
+uint8_t DataStore::getBlobByKey(const uint8_t key[], int key_len, uint8_t dest_buf[]) {
+  char path[64];
   char fname[18];
+
   if (key_len > 8) key_len = 8; // just use first 8 bytes (prefix)
   mesh::Utils::toHex(fname, key, key_len);
   sprintf(path, "/bl/%s", fname);
-}
-
-uint8_t DataStore::getBlobByKey(const uint8_t key[], int key_len, uint8_t dest_buf[]) {
-  char path[64];
-  makeBlobPath(key, key_len, path, sizeof(path));
 
   if (_fs->exists(path)) {
     File f = openRead(_fs, path);
@@ -588,7 +580,11 @@ uint8_t DataStore::getBlobByKey(const uint8_t key[], int key_len, uint8_t dest_b
 
 bool DataStore::putBlobByKey(const uint8_t key[], int key_len, const uint8_t src_buf[], uint8_t len) {
   char path[64];
-  makeBlobPath(key, key_len, path, sizeof(path));
+  char fname[18];
+
+  if (key_len > 8) key_len = 8; // just use first 8 bytes (prefix)
+  mesh::Utils::toHex(fname, key, key_len);
+  sprintf(path, "/bl/%s", fname);
 
   File f = openWrite(_fs, path);
   if (f) {
@@ -600,13 +596,4 @@ bool DataStore::putBlobByKey(const uint8_t key[], int key_len, const uint8_t src
   }
   return false; // error
 }
-
-bool DataStore::deleteBlobByKey(const uint8_t key[], int key_len) {
-  char path[64];
-  makeBlobPath(key, key_len, path, sizeof(path));
-
-  _fs->remove(path);
-  
-  return true; // return true even if file did not exist
-}
 #endif

examples/companion_radio/DataStore.h

@@ -42,7 +42,6 @@ public:
   void migrateToSecondaryFS();
   uint8_t getBlobByKey(const uint8_t key[], int key_len, uint8_t dest_buf[]);
   bool putBlobByKey(const uint8_t key[], int key_len, const uint8_t src_buf[], uint8_t len);
-  bool deleteBlobByKey(const uint8_t key[], int key_len);
   File openRead(const char* filename);
   File openRead(FILESYSTEM* fs, const char* filename);
   bool removeFile(const char* filename);

examples/companion_radio/MyMesh.cpp

@@ -54,8 +54,6 @@
 #define CMD_SEND_CONTROL_DATA         55   // v8+
 #define CMD_GET_STATS                 56   // v8+, second byte is stats type
 #define CMD_SEND_ANON_REQ             57
-#define CMD_SET_AUTOADD_CONFIG        58
-#define CMD_GET_AUTOADD_CONFIG        59
 
 // Stats sub-types for CMD_GET_STATS
 #define STATS_TYPE_CORE               0
@@ -87,7 +85,6 @@
 #define RESP_CODE_ADVERT_PATH         22
 #define RESP_CODE_TUNING_PARAMS       23
 #define RESP_CODE_STATS               24   // v8+, second byte is stats type
-#define RESP_CODE_AUTOADD_CONFIG      25
 
 #define SEND_TIMEOUT_BASE_MILLIS        500
 #define FLOOD_SEND_TIMEOUT_FACTOR       16.0f
@@ -113,8 +110,6 @@
 #define PUSH_CODE_BINARY_RESPONSE       0x8C
 #define PUSH_CODE_PATH_DISCOVERY_RESPONSE 0x8D
 #define PUSH_CODE_CONTROL_DATA          0x8E   // v8+
-#define PUSH_CODE_CONTACT_DELETED       0x8F // used to notify client app of deleted contact when overwriting oldest
-#define PUSH_CODE_CONTACTS_FULL         0x90 // used to notify client app that contacts storage is full
 
 #define ERR_CODE_UNSUPPORTED_CMD        1
 #define ERR_CODE_NOT_FOUND              2
@@ -125,15 +120,6 @@
 
 #define MAX_SIGN_DATA_LEN               (8 * 1024) // 8K
 
-// Auto-add config bitmask
-// Bit 0: If set, overwrite oldest non-favourite contact when contacts file is full
-// Bits 1-4: these indicate which contact types to auto-add when manual_contact_mode = 0x01
-#define AUTO_ADD_OVERWRITE_OLDEST (1 << 0)  // 0x01 - overwrite oldest non-favourite when full
-#define AUTO_ADD_CHAT             (1 << 1)  // 0x02 - auto-add Chat (Companion) (ADV_TYPE_CHAT)
-#define AUTO_ADD_REPEATER         (1 << 2)  // 0x04 - auto-add Repeater (ADV_TYPE_REPEATER)
-#define AUTO_ADD_ROOM_SERVER      (1 << 3)  // 0x08 - auto-add Room Server (ADV_TYPE_ROOM)
-#define AUTO_ADD_SENSOR           (1 << 4)  // 0x10 - auto-add Sensor (ADV_TYPE_SENSOR)
-
 void MyMesh::writeOKFrame() {
   uint8_t buf[1];
   buf[0] = RESP_CODE_OK;
@@ -276,55 +262,9 @@ bool MyMesh::isAutoAddEnabled() const {
   return (_prefs.manual_add_contacts & 1) == 0;
 }
 
-bool MyMesh::shouldAutoAddContactType(uint8_t contact_type) const {
-  if ((_prefs.manual_add_contacts & 1) == 0) {
-    return true;
-  }
-  
-  uint8_t type_bit = 0;
-  switch (contact_type) {
-    case ADV_TYPE_CHAT:
-      type_bit = AUTO_ADD_CHAT;
-      break;
-    case ADV_TYPE_REPEATER:
-      type_bit = AUTO_ADD_REPEATER;
-      break;
-    case ADV_TYPE_ROOM:
-      type_bit = AUTO_ADD_ROOM_SERVER;
-      break;
-    case ADV_TYPE_SENSOR:
-      type_bit = AUTO_ADD_SENSOR;
-      break;
-    default:
-      return false;  // Unknown type, don't auto-add
-  }
-  
-  return (_prefs.autoadd_config & type_bit) != 0;
-}
-
-bool MyMesh::shouldOverwriteWhenFull() const {
-  return (_prefs.autoadd_config & AUTO_ADD_OVERWRITE_OLDEST) != 0;
-}
-
-void MyMesh::onContactOverwrite(const uint8_t* pub_key) {
-    _store->deleteBlobByKey(pub_key, PUB_KEY_SIZE); // delete from storage
-  if (_serial->isConnected()) {
-    out_frame[0] = PUSH_CODE_CONTACT_DELETED;
-    memcpy(&out_frame[1], pub_key, PUB_KEY_SIZE);
-    _serial->writeFrame(out_frame, 1 + PUB_KEY_SIZE);
-  }
-}
-
-void MyMesh::onContactsFull() {
-  if (_serial->isConnected()) {
-    out_frame[0] = PUSH_CODE_CONTACTS_FULL;
-    _serial->writeFrame(out_frame, 1);
-  }
-}
-
 void MyMesh::onDiscoveredContact(ContactInfo &contact, bool is_new, uint8_t path_len, const uint8_t* path) {
   if (_serial->isConnected()) {
-    if (is_new) {
+    if (!isAutoAddEnabled() && is_new) {
       writeContactRespFrame(PUSH_CODE_NEW_ADVERT, contact);
     } else {
       out_frame[0] = PUSH_CODE_ADVERT;
@@ -359,7 +299,7 @@ void MyMesh::onDiscoveredContact(ContactInfo &contact, bool is_new, uint8_t path
     memcpy(p->path, path, p->path_len);
   }
 
-  if (!is_new) dirty_contacts_expiry = futureMillis(LAZY_CONTACTS_WRITE_DELAY); // only schedule lazy write for contacts that are in contacts[]
+  dirty_contacts_expiry = futureMillis(LAZY_CONTACTS_WRITE_DELAY);
 }
 
 static int sort_by_recent(const void *a, const void *b) {
@@ -793,7 +733,7 @@ MyMesh::MyMesh(mesh::Radio &radio, mesh::RNG &rng, mesh::RTCClock &rtc, SimpleMe
 
   // defaults
   memset(&_prefs, 0, sizeof(_prefs));
-  _prefs.airtime_factor = 1.0;
+  _prefs.airtime_factor = 1.0; // one half
   strcpy(_prefs.node_name, "NONAME");
   _prefs.freq = LORA_FREQ;
   _prefs.sf = LORA_SF;
@@ -818,14 +758,14 @@ void MyMesh::begin(bool has_display) {
     _store->saveMainIdentity(self_id);
   }
 
-// if name is provided as a build flag, use that as default node name instead
-#ifdef ADVERT_NAME
-  strcpy(_prefs.node_name, ADVERT_NAME);
-#else
   // use hex of first 4 bytes of identity public key as default node name
   char pub_key_hex[10];
   mesh::Utils::toHex(pub_key_hex, self_id.pub_key, 4);
   strcpy(_prefs.node_name, pub_key_hex);
+
+// if name is provided as a build flag, use that as default node name instead
+#ifdef ADVERT_NAME
+  strcpy(_prefs.node_name, ADVERT_NAME);
 #endif
 
   // load persisted prefs
@@ -838,7 +778,7 @@ void MyMesh::begin(bool has_display) {
   _prefs.bw = constrain(_prefs.bw, 7.8f, 500.0f);
   _prefs.sf = constrain(_prefs.sf, 5, 12);
   _prefs.cr = constrain(_prefs.cr, 5, 8);
-  _prefs.tx_power_dbm = constrain(_prefs.tx_power_dbm, -9, MAX_LORA_TX_POWER);
+  _prefs.tx_power_dbm = constrain(_prefs.tx_power_dbm, 1, MAX_LORA_TX_POWER);
   _prefs.gps_enabled = constrain(_prefs.gps_enabled, 0, 1);  // Ensure boolean 0 or 1
   _prefs.gps_interval = constrain(_prefs.gps_interval, 0, 86400);  // Max 24 hours
 
@@ -863,7 +803,6 @@ void MyMesh::begin(bool has_display) {
 
   resetContacts();
   _store->loadContacts(this);
-  bootstrapRTCfromContacts();
   addChannel("Public", PUBLIC_GROUP_PSK); // pre-configure Andy's public channel
   _store->loadChannels(this);
 
@@ -1125,7 +1064,6 @@ void MyMesh::handleCmdFrame(size_t len) {
     uint8_t *pub_key = &cmd_frame[1];
     ContactInfo *recipient = lookupContactByPubKey(pub_key, PUB_KEY_SIZE);
     if (recipient && removeContact(*recipient)) {
-      _store->deleteBlobByKey(pub_key, PUB_KEY_SIZE);
       dirty_contacts_expiry = futureMillis(LAZY_CONTACTS_WRITE_DELAY);
       writeOKFrame();
     } else {
@@ -1228,11 +1166,10 @@ void MyMesh::handleCmdFrame(size_t len) {
       writeErrFrame(ERR_CODE_ILLEGAL_ARG);
     }
   } else if (cmd_frame[0] == CMD_SET_RADIO_TX_POWER) {
-    int8_t power = (int8_t)cmd_frame[1];
-    if (power < -9 || power > MAX_LORA_TX_POWER) {
+    if (cmd_frame[1] > MAX_LORA_TX_POWER) {
       writeErrFrame(ERR_CODE_ILLEGAL_ARG);
     } else {
-      _prefs.tx_power_dbm = power;
+      _prefs.tx_power_dbm = cmd_frame[1];
       savePrefs();
       radio_set_tx_power(_prefs.tx_power_dbm);
       writeOKFrame();
@@ -1298,20 +1235,16 @@ void MyMesh::handleCmdFrame(size_t len) {
 #endif
   } else if (cmd_frame[0] == CMD_IMPORT_PRIVATE_KEY && len >= 65) {
 #if ENABLE_PRIVATE_KEY_IMPORT
-    if (!mesh::LocalIdentity::validatePrivateKey(&cmd_frame[1])) {
-        writeErrFrame(ERR_CODE_ILLEGAL_ARG); // invalid key
+    mesh::LocalIdentity identity;
+    identity.readFrom(&cmd_frame[1], 64);
+    if (_store->saveMainIdentity(identity)) {
+      self_id = identity;
+      writeOKFrame();
+      // re-load contacts, to invalidate ecdh shared_secrets
+      resetContacts();
+      _store->loadContacts(this);
     } else {
-        mesh::LocalIdentity identity;
-        identity.readFrom(&cmd_frame[1], 64);
-        if (_store->saveMainIdentity(identity)) {
-          self_id = identity;
-          writeOKFrame();
-          // re-load contacts, to invalidate ecdh shared_secrets
-          resetContacts();
-          _store->loadContacts(this);
-        } else {
-          writeErrFrame(ERR_CODE_FILE_IO_ERROR);
-        }
+      writeErrFrame(ERR_CODE_FILE_IO_ERROR);
     }
 #else
     writeDisabledFrame();
@@ -1568,7 +1501,7 @@ void MyMesh::handleCmdFrame(size_t len) {
         sendDirect(pkt, &cmd_frame[10], path_len);
 
         uint32_t t = _radio->getEstAirtimeFor(pkt->payload_len + pkt->path_len + 2);
-        uint32_t est_timeout = calcDirectTimeoutMillisFor(t, path_len >> path_sz);
+        uint32_t est_timeout = calcDirectTimeoutMillisFor(t, path_len);
 
         out_frame[0] = RESP_CODE_SENT;
         out_frame[1] = 0;
@@ -1692,14 +1625,12 @@ void MyMesh::handleCmdFrame(size_t len) {
       uint32_t n_sent_direct = getNumSentDirect();
       uint32_t n_recv_flood = getNumRecvFlood();
       uint32_t n_recv_direct = getNumRecvDirect();
-      uint32_t n_recv_errors = radio_driver.getPacketsRecvErrors();
       memcpy(&out_frame[i], &recv, 4); i += 4;
       memcpy(&out_frame[i], &sent, 4); i += 4;
       memcpy(&out_frame[i], &n_sent_flood, 4); i += 4;
       memcpy(&out_frame[i], &n_sent_direct, 4); i += 4;
       memcpy(&out_frame[i], &n_recv_flood, 4); i += 4;
       memcpy(&out_frame[i], &n_recv_direct, 4); i += 4;
-      memcpy(&out_frame[i], &n_recv_errors, 4); i += 4;
       _serial->writeFrame(out_frame, i);
     } else {
       writeErrFrame(ERR_CODE_ILLEGAL_ARG); // invalid stats sub-type
@@ -1732,15 +1663,6 @@ void MyMesh::handleCmdFrame(size_t len) {
     } else {
       writeErrFrame(ERR_CODE_TABLE_FULL);
     }
-  } else if (cmd_frame[0] == CMD_SET_AUTOADD_CONFIG) {
-    _prefs.autoadd_config = cmd_frame[1];
-    savePrefs();
-    writeOKFrame();  
-  } else if (cmd_frame[0] == CMD_GET_AUTOADD_CONFIG) {
-    int i = 0;
-    out_frame[i++] = RESP_CODE_AUTOADD_CONFIG;
-    out_frame[i++] = _prefs.autoadd_config;
-    _serial->writeFrame(out_frame, i);
   } else {
     writeErrFrame(ERR_CODE_UNSUPPORTED_CMD);
     MESH_DEBUG_PRINTLN("ERROR: unknown command: %02X", cmd_frame[0]);

examples/companion_radio/MyMesh.h

@@ -8,11 +8,11 @@
 #define FIRMWARE_VER_CODE 8
 
 #ifndef FIRMWARE_BUILD_DATE
-#define FIRMWARE_BUILD_DATE "29 Jan 2026"
+#define FIRMWARE_BUILD_DATE "30 Nov 2025"
 #endif
 
 #ifndef FIRMWARE_VERSION
-#define FIRMWARE_VERSION "v1.12.0"
+#define FIRMWARE_VERSION "v1.11.0"
 #endif
 
 #if defined(NRF52_PLATFORM) || defined(STM32_PLATFORM)
@@ -114,10 +114,6 @@ protected:
 
   void logRxRaw(float snr, float rssi, const uint8_t raw[], int len) override;
   bool isAutoAddEnabled() const override;
-  bool shouldAutoAddContactType(uint8_t type) const override;
-  bool shouldOverwriteWhenFull() const override;
-  void onContactsFull() override;
-  void onContactOverwrite(const uint8_t* pub_key) override;
   bool onContactPathRecv(ContactInfo& from, uint8_t* in_path, uint8_t in_path_len, uint8_t* out_path, uint8_t out_path_len, uint8_t extra_type, uint8_t* extra, uint8_t extra_len) override;
   void onDiscoveredContact(ContactInfo &contact, bool is_new, uint8_t path_len, const uint8_t* path) override;
   void onContactPathUpdated(const ContactInfo &contact) override;

examples/companion_radio/NodePrefs.h

@@ -17,7 +17,7 @@ struct NodePrefs {  // persisted to file
   uint8_t multi_acks;
   uint8_t manual_add_contacts;
   float bw;
-  int8_t tx_power_dbm;
+  uint8_t tx_power_dbm;
   uint8_t telemetry_mode_base;
   uint8_t telemetry_mode_loc;
   uint8_t telemetry_mode_env;
@@ -27,5 +27,4 @@ struct NodePrefs {  // persisted to file
   uint8_t  buzzer_quiet;
   uint8_t  gps_enabled;      // GPS enabled flag (0=disabled, 1=enabled)
   uint32_t gps_interval;     // GPS read interval in seconds
-  uint8_t autoadd_config;    // bitmask for auto-add contacts config
 };

examples/companion_radio/main.cpp

@@ -151,7 +151,9 @@ void setup() {
   );
 
 #ifdef BLE_PIN_CODE
-  serial_interface.begin(BLE_NAME_PREFIX, the_mesh.getNodePrefs()->node_name, the_mesh.getBLEPin());
+  char dev_name[32+16];
+  sprintf(dev_name, "%s%s", BLE_NAME_PREFIX, the_mesh.getNodeName());
+  serial_interface.begin(dev_name, the_mesh.getBLEPin());
 #else
   serial_interface.begin(Serial);
 #endif
@@ -194,11 +196,12 @@ void setup() {
   );
 
 #ifdef WIFI_SSID
-  board.setInhibitSleep(true);   // prevent sleep when WiFi is active
   WiFi.begin(WIFI_SSID, WIFI_PWD);
   serial_interface.begin(TCP_PORT);
 #elif defined(BLE_PIN_CODE)
-  serial_interface.begin(BLE_NAME_PREFIX, the_mesh.getNodePrefs()->node_name, the_mesh.getBLEPin());
+  char dev_name[32+16];
+  sprintf(dev_name, "%s%s", BLE_NAME_PREFIX, the_mesh.getNodeName());
+  serial_interface.begin(dev_name, the_mesh.getBLEPin());
 #elif defined(SERIAL_RX)
   companion_serial.setPins(SERIAL_RX, SERIAL_TX);
   companion_serial.begin(115200);

examples/companion_radio/ui-new/UITask.cpp

@@ -103,14 +103,8 @@ class HomeScreen : public UIScreen {
 
   void renderBatteryIndicator(DisplayDriver& display, uint16_t batteryMilliVolts) {
     // Convert millivolts to percentage
-#ifndef BATT_MIN_MILLIVOLTS
-  #define BATT_MIN_MILLIVOLTS 3000
-#endif
-#ifndef BATT_MAX_MILLIVOLTS
-  #define BATT_MAX_MILLIVOLTS 4200
-#endif
-    const int minMilliVolts = BATT_MIN_MILLIVOLTS;
-    const int maxMilliVolts = BATT_MAX_MILLIVOLTS;
+    const int minMilliVolts = 3000; // Minimum voltage (e.g., 3.0V)
+    const int maxMilliVolts = 4200; // Maximum voltage (e.g., 4.2V)
     int batteryPercentage = ((batteryMilliVolts - minMilliVolts) * 100) / (maxMilliVolts - minMilliVolts);
     if (batteryPercentage < 0) batteryPercentage = 0; // Clamp to 0%
     if (batteryPercentage > 100) batteryPercentage = 100; // Clamp to 100%
@@ -458,17 +452,15 @@ class MsgPreviewScreen : public UIScreen {
   };
   #define MAX_UNREAD_MSGS   32
   int num_unread;
-  int head = MAX_UNREAD_MSGS - 1; // index of latest unread message
   MsgEntry unread[MAX_UNREAD_MSGS];
 
 public:
   MsgPreviewScreen(UITask* task, mesh::RTCClock* rtc) : _task(task), _rtc(rtc) { num_unread = 0; }
 
   void addPreview(uint8_t path_len, const char* from_name, const char* msg) {
-    head = (head + 1) % MAX_UNREAD_MSGS;
-    if (num_unread < MAX_UNREAD_MSGS) num_unread++;
+    if (num_unread >= MAX_UNREAD_MSGS) return;  // full
 
-    auto p = &unread[head];
+    auto p = &unread[num_unread++];
     p->timestamp = _rtc->getCurrentTime();
     if (path_len == 0xFF) {
       sprintf(p->origin, "(D) %s:", from_name);
@@ -486,7 +478,7 @@ public:
     sprintf(tmp, "Unread: %d", num_unread);
     display.print(tmp);
 
-    auto p = &unread[head];
+    auto p = &unread[0];
 
     int secs = _rtc->getCurrentTime() - p->timestamp;
     if (secs < 60) {
@@ -522,10 +514,14 @@ public:
 
   bool handleInput(char c) override {
     if (c == KEY_NEXT || c == KEY_RIGHT) {
-      head = (head + MAX_UNREAD_MSGS - 1) % MAX_UNREAD_MSGS;
       num_unread--;
       if (num_unread == 0) {
         _task->gotoHomeScreen();
+      } else {
+        // delete first/curr item from unread queue
+        for (int i = 0; i < num_unread; i++) {
+          unread[i] = unread[i + 1];
+        }
       }
       return true;
     }

examples/companion_radio/ui-orig/UITask.cpp

@@ -149,14 +149,8 @@ void UITask::newMsg(uint8_t path_len, const char* from_name, const char* text, i
 
 void UITask::renderBatteryIndicator(uint16_t batteryMilliVolts) {
   // Convert millivolts to percentage
-#ifndef BATT_MIN_MILLIVOLTS
-  #define BATT_MIN_MILLIVOLTS 3000
-#endif
-#ifndef BATT_MAX_MILLIVOLTS
-  #define BATT_MAX_MILLIVOLTS 4200
-#endif
-  const int minMilliVolts = BATT_MIN_MILLIVOLTS;
-  const int maxMilliVolts = BATT_MAX_MILLIVOLTS;
+  const int minMilliVolts = 3000; // Minimum voltage (e.g., 3.0V)
+  const int maxMilliVolts = 4200; // Maximum voltage (e.g., 4.2V)
   int batteryPercentage = ((batteryMilliVolts - minMilliVolts) * 100) / (maxMilliVolts - minMilliVolts);
   if (batteryPercentage < 0) batteryPercentage = 0; // Clamp to 0%
   if (batteryPercentage > 100) batteryPercentage = 100; // Clamp to 100%

examples/kiss_modem/KissModem.cpp

@@ -1,581 +0,0 @@
-#include "KissModem.h"
-#include <CayenneLPP.h>
-
-KissModem::KissModem(Stream& serial, mesh::LocalIdentity& identity, mesh::RNG& rng,
-                     mesh::Radio& radio, mesh::MainBoard& board, SensorManager& sensors)
-  : _serial(serial), _identity(identity), _rng(rng), _radio(radio), _board(board), _sensors(sensors) {
-  _rx_len = 0;
-  _rx_escaped = false;
-  _rx_active = false;
-  _has_pending_tx = false;
-  _pending_tx_len = 0;
-  _txdelay = KISS_DEFAULT_TXDELAY;
-  _persistence = KISS_DEFAULT_PERSISTENCE;
-  _slottime = KISS_DEFAULT_SLOTTIME;
-  _txtail = 0;
-  _fullduplex = 0;
-  _tx_state = TX_IDLE;
-  _tx_timer = 0;
-  _setRadioCallback = nullptr;
-  _setTxPowerCallback = nullptr;
-  _getCurrentRssiCallback = nullptr;
-  _getStatsCallback = nullptr;
-  _config = {0, 0, 0, 0, 0};
-  _signal_report_enabled = true;
-}
-
-void KissModem::begin() {
-  _rx_len = 0;
-  _rx_escaped = false;
-  _rx_active = false;
-  _has_pending_tx = false;
-  _tx_state = TX_IDLE;
-}
-
-void KissModem::writeByte(uint8_t b) {
-  if (b == KISS_FEND) {
-    _serial.write(KISS_FESC);
-    _serial.write(KISS_TFEND);
-  } else if (b == KISS_FESC) {
-    _serial.write(KISS_FESC);
-    _serial.write(KISS_TFESC);
-  } else {
-    _serial.write(b);
-  }
-}
-
-void KissModem::writeFrame(uint8_t type, const uint8_t* data, uint16_t len) {
-  _serial.write(KISS_FEND);
-  writeByte(type);
-  for (uint16_t i = 0; i < len; i++) {
-    writeByte(data[i]);
-  }
-  _serial.write(KISS_FEND);
-}
-
-void KissModem::writeHardwareFrame(uint8_t sub_cmd, const uint8_t* data, uint16_t len) {
-  _serial.write(KISS_FEND);
-  writeByte(KISS_CMD_SETHARDWARE);
-  writeByte(sub_cmd);
-  for (uint16_t i = 0; i < len; i++) {
-    writeByte(data[i]);
-  }
-  _serial.write(KISS_FEND);
-}
-
-void KissModem::writeHardwareError(uint8_t error_code) {
-  writeHardwareFrame(HW_RESP_ERROR, &error_code, 1);
-}
-
-void KissModem::loop() {
-  while (_serial.available()) {
-    uint8_t b = _serial.read();
-
-    if (b == KISS_FEND) {
-      if (_rx_active && _rx_len > 0) {
-        processFrame();
-      }
-      _rx_len = 0;
-      _rx_escaped = false;
-      _rx_active = true;
-      continue;
-    }
-
-    if (!_rx_active) continue;
-
-    if (b == KISS_FESC) {
-      _rx_escaped = true;
-      continue;
-    }
-
-    if (_rx_escaped) {
-      _rx_escaped = false;
-      if (b == KISS_TFEND) b = KISS_FEND;
-      else if (b == KISS_TFESC) b = KISS_FESC;
-      else continue;
-    }
-
-    if (_rx_len < KISS_MAX_FRAME_SIZE) {
-      _rx_buf[_rx_len++] = b;
-    } else {
-      /* Buffer full with no FEND; reset so we don't stay stuck ignoring input. */
-      _rx_len = 0;
-      _rx_escaped = false;
-      _rx_active = false;
-    }
-  }
-
-  processTx();
-}
-
-void KissModem::processFrame() {
-  if (_rx_len < 1) return;
-
-  uint8_t type_byte = _rx_buf[0];
-
-  if (type_byte == KISS_CMD_RETURN) return;
-
-  uint8_t port = (type_byte >> 4) & 0x0F;
-  uint8_t cmd = type_byte & 0x0F;
-
-  if (port != 0) return;
-
-  const uint8_t* data = &_rx_buf[1];
-  uint16_t data_len = _rx_len - 1;
-
-  switch (cmd) {
-    case KISS_CMD_DATA:
-      if (data_len > 0 && data_len <= KISS_MAX_PACKET_SIZE && !_has_pending_tx) {
-        memcpy(_pending_tx, data, data_len);
-        _pending_tx_len = data_len;
-        _has_pending_tx = true;
-      }
-      break;
-
-    case KISS_CMD_TXDELAY:
-      if (data_len >= 1) _txdelay = data[0];
-      break;
-
-    case KISS_CMD_PERSISTENCE:
-      if (data_len >= 1) _persistence = data[0];
-      break;
-
-    case KISS_CMD_SLOTTIME:
-      if (data_len >= 1) _slottime = data[0];
-      break;
-
-    case KISS_CMD_TXTAIL:
-      if (data_len >= 1) _txtail = data[0];
-      break;
-
-    case KISS_CMD_FULLDUPLEX:
-      if (data_len >= 1) _fullduplex = data[0];
-      break;
-
-    case KISS_CMD_SETHARDWARE:
-      if (data_len >= 1) {
-        handleHardwareCommand(data[0], data + 1, data_len - 1);
-      }
-      break;
-
-    default:
-      break;
-  }
-}
-
-void KissModem::handleHardwareCommand(uint8_t sub_cmd, const uint8_t* data, uint16_t len) {
-  switch (sub_cmd) {
-    case HW_CMD_GET_IDENTITY:
-      handleGetIdentity();
-      break;
-    case HW_CMD_GET_RANDOM:
-      handleGetRandom(data, len);
-      break;
-    case HW_CMD_VERIFY_SIGNATURE:
-      handleVerifySignature(data, len);
-      break;
-    case HW_CMD_SIGN_DATA:
-      handleSignData(data, len);
-      break;
-    case HW_CMD_ENCRYPT_DATA:
-      handleEncryptData(data, len);
-      break;
-    case HW_CMD_DECRYPT_DATA:
-      handleDecryptData(data, len);
-      break;
-    case HW_CMD_KEY_EXCHANGE:
-      handleKeyExchange(data, len);
-      break;
-    case HW_CMD_HASH:
-      handleHash(data, len);
-      break;
-    case HW_CMD_SET_RADIO:
-      handleSetRadio(data, len);
-      break;
-    case HW_CMD_SET_TX_POWER:
-      handleSetTxPower(data, len);
-      break;
-    case HW_CMD_GET_RADIO:
-      handleGetRadio();
-      break;
-    case HW_CMD_GET_TX_POWER:
-      handleGetTxPower();
-      break;
-    case HW_CMD_GET_VERSION:
-      handleGetVersion();
-      break;
-    case HW_CMD_GET_CURRENT_RSSI:
-      handleGetCurrentRssi();
-      break;
-    case HW_CMD_IS_CHANNEL_BUSY:
-      handleIsChannelBusy();
-      break;
-    case HW_CMD_GET_AIRTIME:
-      handleGetAirtime(data, len);
-      break;
-    case HW_CMD_GET_NOISE_FLOOR:
-      handleGetNoiseFloor();
-      break;
-    case HW_CMD_GET_STATS:
-      handleGetStats();
-      break;
-    case HW_CMD_GET_BATTERY:
-      handleGetBattery();
-      break;
-    case HW_CMD_PING:
-      handlePing();
-      break;
-    case HW_CMD_GET_SENSORS:
-      handleGetSensors(data, len);
-      break;
-    case HW_CMD_GET_MCU_TEMP:
-      handleGetMCUTemp();
-      break;
-    case HW_CMD_REBOOT:
-      handleReboot();
-      break;
-    case HW_CMD_GET_DEVICE_NAME:
-      handleGetDeviceName();
-      break;
-    case HW_CMD_SET_SIGNAL_REPORT:
-      handleSetSignalReport(data, len);
-      break;
-    case HW_CMD_GET_SIGNAL_REPORT:
-      handleGetSignalReport();
-      break;
-    default:
-      writeHardwareError(HW_ERR_UNKNOWN_CMD);
-      break;
-  }
-}
-
-void KissModem::processTx() {
-  switch (_tx_state) {
-    case TX_IDLE:
-      if (_has_pending_tx) {
-        if (_fullduplex) {
-          _tx_timer = millis();
-          _tx_state = TX_DELAY;
-        } else {
-          _tx_state = TX_WAIT_CLEAR;
-        }
-      }
-      break;
-
-    case TX_WAIT_CLEAR:
-      if (!_radio.isReceiving()) {
-        uint8_t rand_val;
-        _rng.random(&rand_val, 1);
-        if (rand_val <= _persistence) {
-          _tx_timer = millis();
-          _tx_state = TX_DELAY;
-        } else {
-          _tx_timer = millis();
-          _tx_state = TX_SLOT_WAIT;
-        }
-      }
-      break;
-
-    case TX_SLOT_WAIT:
-      if (millis() - _tx_timer >= (uint32_t)_slottime * 10) {
-        _tx_state = TX_WAIT_CLEAR;
-      }
-      break;
-
-    case TX_DELAY:
-      if (millis() - _tx_timer >= (uint32_t)_txdelay * 10) {
-        _radio.startSendRaw(_pending_tx, _pending_tx_len);
-        _tx_state = TX_SENDING;
-      }
-      break;
-
-    case TX_SENDING:
-      if (_radio.isSendComplete()) {
-        _radio.onSendFinished();
-        uint8_t result = 0x01;
-        writeHardwareFrame(HW_RESP_TX_DONE, &result, 1);
-        _has_pending_tx = false;
-        _tx_state = TX_IDLE;
-      }
-      break;
-  }
-}
-
-void KissModem::onPacketReceived(int8_t snr, int8_t rssi, const uint8_t* packet, uint16_t len) {
-  writeFrame(KISS_CMD_DATA, packet, len);
-  if (_signal_report_enabled) {
-    uint8_t meta[2] = { (uint8_t)snr, (uint8_t)rssi };
-    writeHardwareFrame(HW_RESP_RX_META, meta, 2);
-  }
-}
-
-void KissModem::handleGetIdentity() {
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_IDENTITY), _identity.pub_key, PUB_KEY_SIZE);
-}
-
-void KissModem::handleGetRandom(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t requested = data[0];
-  if (requested < 1 || requested > 64) {
-    writeHardwareError(HW_ERR_INVALID_PARAM);
-    return;
-  }
-
-  uint8_t buf[64];
-  _rng.random(buf, requested);
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_RANDOM), buf, requested);
-}
-
-void KissModem::handleVerifySignature(const uint8_t* data, uint16_t len) {
-  if (len < PUB_KEY_SIZE + SIGNATURE_SIZE + 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  mesh::Identity signer(data);
-  const uint8_t* signature = data + PUB_KEY_SIZE;
-  const uint8_t* msg = data + PUB_KEY_SIZE + SIGNATURE_SIZE;
-  uint16_t msg_len = len - PUB_KEY_SIZE - SIGNATURE_SIZE;
-
-  uint8_t result = signer.verify(signature, msg, msg_len) ? 0x01 : 0x00;
-  writeHardwareFrame(HW_RESP(HW_CMD_VERIFY_SIGNATURE), &result, 1);
-}
-
-void KissModem::handleSignData(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t signature[SIGNATURE_SIZE];
-  _identity.sign(signature, data, len);
-  writeHardwareFrame(HW_RESP(HW_CMD_SIGN_DATA), signature, SIGNATURE_SIZE);
-}
-
-void KissModem::handleEncryptData(const uint8_t* data, uint16_t len) {
-  if (len < PUB_KEY_SIZE + 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  const uint8_t* key = data;
-  const uint8_t* plaintext = data + PUB_KEY_SIZE;
-  uint16_t plaintext_len = len - PUB_KEY_SIZE;
-
-  uint8_t buf[KISS_MAX_FRAME_SIZE];
-  int encrypted_len = mesh::Utils::encryptThenMAC(key, buf, plaintext, plaintext_len);
-
-  if (encrypted_len > 0) {
-    writeHardwareFrame(HW_RESP(HW_CMD_ENCRYPT_DATA), buf, encrypted_len);
-  } else {
-    writeHardwareError(HW_ERR_ENCRYPT_FAILED);
-  }
-}
-
-void KissModem::handleDecryptData(const uint8_t* data, uint16_t len) {
-  if (len < PUB_KEY_SIZE + CIPHER_MAC_SIZE + 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  const uint8_t* key = data;
-  const uint8_t* ciphertext = data + PUB_KEY_SIZE;
-  uint16_t ciphertext_len = len - PUB_KEY_SIZE;
-
-  uint8_t buf[KISS_MAX_FRAME_SIZE];
-  int decrypted_len = mesh::Utils::MACThenDecrypt(key, buf, ciphertext, ciphertext_len);
-
-  if (decrypted_len > 0) {
-    writeHardwareFrame(HW_RESP(HW_CMD_DECRYPT_DATA), buf, decrypted_len);
-  } else {
-    writeHardwareError(HW_ERR_MAC_FAILED);
-  }
-}
-
-void KissModem::handleKeyExchange(const uint8_t* data, uint16_t len) {
-  if (len < PUB_KEY_SIZE) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t shared_secret[PUB_KEY_SIZE];
-  _identity.calcSharedSecret(shared_secret, data);
-  writeHardwareFrame(HW_RESP(HW_CMD_KEY_EXCHANGE), shared_secret, PUB_KEY_SIZE);
-}
-
-void KissModem::handleHash(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t hash[32];
-  mesh::Utils::sha256(hash, 32, data, len);
-  writeHardwareFrame(HW_RESP(HW_CMD_HASH), hash, 32);
-}
-
-void KissModem::handleSetRadio(const uint8_t* data, uint16_t len) {
-  if (len < 10) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-  if (!_setRadioCallback) {
-    writeHardwareError(HW_ERR_NO_CALLBACK);
-    return;
-  }
-
-  memcpy(&_config.freq_hz, data, 4);
-  memcpy(&_config.bw_hz, data + 4, 4);
-  _config.sf = data[8];
-  _config.cr = data[9];
-
-  _setRadioCallback(_config.freq_hz / 1000000.0f, _config.bw_hz / 1000.0f, _config.sf, _config.cr);
-  writeHardwareFrame(HW_RESP_OK, nullptr, 0);
-}
-
-void KissModem::handleSetTxPower(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-  if (!_setTxPowerCallback) {
-    writeHardwareError(HW_ERR_NO_CALLBACK);
-    return;
-  }
-
-  _config.tx_power = data[0];
-  _setTxPowerCallback(data[0]);
-  writeHardwareFrame(HW_RESP_OK, nullptr, 0);
-}
-
-void KissModem::handleGetRadio() {
-  uint8_t buf[10];
-  memcpy(buf, &_config.freq_hz, 4);
-  memcpy(buf + 4, &_config.bw_hz, 4);
-  buf[8] = _config.sf;
-  buf[9] = _config.cr;
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_RADIO), buf, 10);
-}
-
-void KissModem::handleGetTxPower() {
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_TX_POWER), &_config.tx_power, 1);
-}
-
-void KissModem::handleGetVersion() {
-  uint8_t buf[2];
-  buf[0] = KISS_FIRMWARE_VERSION;
-  buf[1] = 0;
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_VERSION), buf, 2);
-}
-
-void KissModem::handleGetCurrentRssi() {
-  if (!_getCurrentRssiCallback) {
-    writeHardwareError(HW_ERR_NO_CALLBACK);
-    return;
-  }
-
-  float rssi = _getCurrentRssiCallback();
-  int8_t rssi_byte = (int8_t)rssi;
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_CURRENT_RSSI), (uint8_t*)&rssi_byte, 1);
-}
-
-void KissModem::handleIsChannelBusy() {
-  uint8_t busy = _radio.isReceiving() ? 0x01 : 0x00;
-  writeHardwareFrame(HW_RESP(HW_CMD_IS_CHANNEL_BUSY), &busy, 1);
-}
-
-void KissModem::handleGetAirtime(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t packet_len = data[0];
-  uint32_t airtime = _radio.getEstAirtimeFor(packet_len);
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_AIRTIME), (uint8_t*)&airtime, 4);
-}
-
-void KissModem::handleGetNoiseFloor() {
-  int16_t noise_floor = _radio.getNoiseFloor();
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_NOISE_FLOOR), (uint8_t*)&noise_floor, 2);
-}
-
-void KissModem::handleGetStats() {
-  if (!_getStatsCallback) {
-    writeHardwareError(HW_ERR_NO_CALLBACK);
-    return;
-  }
-
-  uint32_t rx, tx, errors;
-  _getStatsCallback(&rx, &tx, &errors);
-  uint8_t buf[12];
-  memcpy(buf, &rx, 4);
-  memcpy(buf + 4, &tx, 4);
-  memcpy(buf + 8, &errors, 4);
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_STATS), buf, 12);
-}
-
-void KissModem::handleGetBattery() {
-  uint16_t mv = _board.getBattMilliVolts();
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_BATTERY), (uint8_t*)&mv, 2);
-}
-
-void KissModem::handlePing() {
-  writeHardwareFrame(HW_RESP(HW_CMD_PING), nullptr, 0);
-}
-
-void KissModem::handleGetSensors(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-
-  uint8_t permissions = data[0];
-  CayenneLPP telemetry(255);
-  if (_sensors.querySensors(permissions, telemetry)) {
-    writeHardwareFrame(HW_RESP(HW_CMD_GET_SENSORS), telemetry.getBuffer(), telemetry.getSize());
-  } else {
-    writeHardwareFrame(HW_RESP(HW_CMD_GET_SENSORS), nullptr, 0);
-  }
-}
-
-void KissModem::handleGetMCUTemp() {
-  float temp = _board.getMCUTemperature();
-  if (isnan(temp)) {
-    writeHardwareError(HW_ERR_NO_CALLBACK);
-    return;
-  }
-  int16_t temp_tenths = (int16_t)(temp * 10.0f);
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_MCU_TEMP), (uint8_t*)&temp_tenths, 2);
-}
-
-void KissModem::handleReboot() {
-  writeHardwareFrame(HW_RESP_OK, nullptr, 0);
-  _serial.flush();
-  delay(50);
-  _board.reboot();
-}
-
-void KissModem::handleGetDeviceName() {
-  const char* name = _board.getManufacturerName();
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_DEVICE_NAME), (const uint8_t*)name, strlen(name));
-}
-
-void KissModem::handleSetSignalReport(const uint8_t* data, uint16_t len) {
-  if (len < 1) {
-    writeHardwareError(HW_ERR_INVALID_LENGTH);
-    return;
-  }
-  _signal_report_enabled = (data[0] != 0x00);
-  uint8_t val = _signal_report_enabled ? 0x01 : 0x00;
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_SIGNAL_REPORT), &val, 1);
-}
-
-void KissModem::handleGetSignalReport() {
-  uint8_t val = _signal_report_enabled ? 0x01 : 0x00;
-  writeHardwareFrame(HW_RESP(HW_CMD_GET_SIGNAL_REPORT), &val, 1);
-}

examples/kiss_modem/KissModem.h

@@ -1,183 +0,0 @@
-#pragma once
-
-#include <Arduino.h>
-#include <Identity.h>
-#include <Utils.h>
-#include <Mesh.h>
-#include <helpers/SensorManager.h>
-
-#define KISS_FEND  0xC0
-#define KISS_FESC  0xDB
-#define KISS_TFEND 0xDC
-#define KISS_TFESC 0xDD
-
-#define KISS_MAX_FRAME_SIZE  512
-#define KISS_MAX_PACKET_SIZE 255
-
-#define KISS_CMD_DATA        0x00
-#define KISS_CMD_TXDELAY     0x01
-#define KISS_CMD_PERSISTENCE 0x02
-#define KISS_CMD_SLOTTIME    0x03
-#define KISS_CMD_TXTAIL      0x04
-#define KISS_CMD_FULLDUPLEX  0x05
-#define KISS_CMD_SETHARDWARE 0x06
-#define KISS_CMD_RETURN      0xFF
-
-#define KISS_DEFAULT_TXDELAY     50
-#define KISS_DEFAULT_PERSISTENCE 63
-#define KISS_DEFAULT_SLOTTIME    10
-
-#define HW_CMD_GET_IDENTITY      0x01
-#define HW_CMD_GET_RANDOM        0x02
-#define HW_CMD_VERIFY_SIGNATURE  0x03
-#define HW_CMD_SIGN_DATA         0x04
-#define HW_CMD_ENCRYPT_DATA      0x05
-#define HW_CMD_DECRYPT_DATA      0x06
-#define HW_CMD_KEY_EXCHANGE      0x07
-#define HW_CMD_HASH              0x08
-#define HW_CMD_SET_RADIO         0x09
-#define HW_CMD_SET_TX_POWER      0x0A
-#define HW_CMD_GET_RADIO         0x0B
-#define HW_CMD_GET_TX_POWER      0x0C
-#define HW_CMD_GET_CURRENT_RSSI  0x0D
-#define HW_CMD_IS_CHANNEL_BUSY   0x0E
-#define HW_CMD_GET_AIRTIME       0x0F
-#define HW_CMD_GET_NOISE_FLOOR   0x10
-#define HW_CMD_GET_VERSION       0x11
-#define HW_CMD_GET_STATS         0x12
-#define HW_CMD_GET_BATTERY       0x13
-#define HW_CMD_GET_MCU_TEMP      0x14
-#define HW_CMD_GET_SENSORS       0x15
-#define HW_CMD_GET_DEVICE_NAME   0x16
-#define HW_CMD_PING              0x17
-#define HW_CMD_REBOOT            0x18
-#define HW_CMD_SET_SIGNAL_REPORT 0x19
-#define HW_CMD_GET_SIGNAL_REPORT 0x1A
-
-/* Response code = command code | 0x80.  Generic / unsolicited use 0xF0+. */
-#define HW_RESP(cmd)             ((cmd) | 0x80)
-
-/* Generic responses (shared by multiple commands) */
-#define HW_RESP_OK               0xF0
-#define HW_RESP_ERROR            0xF1
-
-/* Unsolicited notifications (no corresponding request) */
-#define HW_RESP_TX_DONE          0xF8
-#define HW_RESP_RX_META          0xF9
-
-#define HW_ERR_INVALID_LENGTH    0x01
-#define HW_ERR_INVALID_PARAM     0x02
-#define HW_ERR_NO_CALLBACK       0x03
-#define HW_ERR_MAC_FAILED        0x04
-#define HW_ERR_UNKNOWN_CMD       0x05
-#define HW_ERR_ENCRYPT_FAILED    0x06
-
-#define KISS_FIRMWARE_VERSION 1
-
-typedef void (*SetRadioCallback)(float freq, float bw, uint8_t sf, uint8_t cr);
-typedef void (*SetTxPowerCallback)(uint8_t power);
-typedef float (*GetCurrentRssiCallback)();
-typedef void (*GetStatsCallback)(uint32_t* rx, uint32_t* tx, uint32_t* errors);
-
-struct RadioConfig {
-  uint32_t freq_hz;
-  uint32_t bw_hz;
-  uint8_t sf;
-  uint8_t cr;
-  uint8_t tx_power;
-};
-
-enum TxState {
-  TX_IDLE,
-  TX_WAIT_CLEAR,
-  TX_SLOT_WAIT,
-  TX_DELAY,
-  TX_SENDING
-};
-
-class KissModem {
-  Stream& _serial;
-  mesh::LocalIdentity& _identity;
-  mesh::RNG& _rng;
-  mesh::Radio& _radio;
-  mesh::MainBoard& _board;
-  SensorManager& _sensors;
-
-  uint8_t _rx_buf[KISS_MAX_FRAME_SIZE];
-  uint16_t _rx_len;
-  bool _rx_escaped;
-  bool _rx_active;
-
-  uint8_t _pending_tx[KISS_MAX_PACKET_SIZE];
-  uint16_t _pending_tx_len;
-  bool _has_pending_tx;
-
-  uint8_t _txdelay;
-  uint8_t _persistence;
-  uint8_t _slottime;
-  uint8_t _txtail;
-  uint8_t _fullduplex;
-
-  TxState _tx_state;
-  uint32_t _tx_timer;
-
-  SetRadioCallback _setRadioCallback;
-  SetTxPowerCallback _setTxPowerCallback;
-  GetCurrentRssiCallback _getCurrentRssiCallback;
-  GetStatsCallback _getStatsCallback;
-
-  RadioConfig _config;
-  bool _signal_report_enabled;
-
-  void writeByte(uint8_t b);
-  void writeFrame(uint8_t type, const uint8_t* data, uint16_t len);
-  void writeHardwareFrame(uint8_t sub_cmd, const uint8_t* data, uint16_t len);
-  void writeHardwareError(uint8_t error_code);
-  void processFrame();
-  void handleHardwareCommand(uint8_t sub_cmd, const uint8_t* data, uint16_t len);
-  void processTx();
-
-  void handleGetIdentity();
-  void handleGetRandom(const uint8_t* data, uint16_t len);
-  void handleVerifySignature(const uint8_t* data, uint16_t len);
-  void handleSignData(const uint8_t* data, uint16_t len);
-  void handleEncryptData(const uint8_t* data, uint16_t len);
-  void handleDecryptData(const uint8_t* data, uint16_t len);
-  void handleKeyExchange(const uint8_t* data, uint16_t len);
-  void handleHash(const uint8_t* data, uint16_t len);
-  void handleSetRadio(const uint8_t* data, uint16_t len);
-  void handleSetTxPower(const uint8_t* data, uint16_t len);
-  void handleGetRadio();
-  void handleGetTxPower();
-  void handleGetVersion();
-  void handleGetCurrentRssi();
-  void handleIsChannelBusy();
-  void handleGetAirtime(const uint8_t* data, uint16_t len);
-  void handleGetNoiseFloor();
-  void handleGetStats();
-  void handleGetBattery();
-  void handlePing();
-  void handleGetSensors(const uint8_t* data, uint16_t len);
-  void handleGetMCUTemp();
-  void handleReboot();
-  void handleGetDeviceName();
-  void handleSetSignalReport(const uint8_t* data, uint16_t len);
-  void handleGetSignalReport();
-
-public:
-  KissModem(Stream& serial, mesh::LocalIdentity& identity, mesh::RNG& rng,
-            mesh::Radio& radio, mesh::MainBoard& board, SensorManager& sensors);
-
-  void begin();
-  void loop();
-
-  void setRadioCallback(SetRadioCallback cb) { _setRadioCallback = cb; }
-  void setTxPowerCallback(SetTxPowerCallback cb) { _setTxPowerCallback = cb; }
-  void setGetCurrentRssiCallback(GetCurrentRssiCallback cb) { _getCurrentRssiCallback = cb; }
-  void setGetStatsCallback(GetStatsCallback cb) { _getStatsCallback = cb; }
-
-  void onPacketReceived(int8_t snr, int8_t rssi, const uint8_t* packet, uint16_t len);
-  bool isTxBusy() const { return _tx_state != TX_IDLE; }
-  /** True only when radio is actually transmitting; use to skip recvRaw in main loop. */
-  bool isActuallyTransmitting() const { return _tx_state == TX_SENDING; }
-};

examples/kiss_modem/main.cpp

@@ -1,146 +0,0 @@
-#include <Arduino.h>
-#include <target.h>
-#include <helpers/ArduinoHelpers.h>
-#include <helpers/IdentityStore.h>
-#include "KissModem.h"
-
-#if defined(NRF52_PLATFORM)
-  #include <InternalFileSystem.h>
-#elif defined(RP2040_PLATFORM)
-  #include <LittleFS.h>
-#elif defined(ESP32)
-  #include <SPIFFS.h>
-#endif
-#if defined(KISS_UART_RX) && defined(KISS_UART_TX)
-  #include <HardwareSerial.h>
-#endif
-
-#define NOISE_FLOOR_CALIB_INTERVAL_MS 2000
-#define AGC_RESET_INTERVAL_MS 30000
-
-StdRNG rng;
-mesh::LocalIdentity identity;
-KissModem* modem;
-static uint32_t next_noise_floor_calib_ms = 0;
-static uint32_t next_agc_reset_ms = 0;
-
-void halt() {
-  while (1) ;
-}
-
-void loadOrCreateIdentity() {
-#if defined(NRF52_PLATFORM)
-  InternalFS.begin();
-  IdentityStore store(InternalFS, "");
-#elif defined(ESP32)
-  SPIFFS.begin(true);
-  IdentityStore store(SPIFFS, "/identity");
-#elif defined(RP2040_PLATFORM)
-  LittleFS.begin();
-  IdentityStore store(LittleFS, "/identity");
-  store.begin();
-#else
-  #error "Filesystem not defined"
-#endif
-
-  if (!store.load("_main", identity)) {
-    identity = radio_new_identity();
-    while (identity.pub_key[0] == 0x00 || identity.pub_key[0] == 0xFF) {
-      identity = radio_new_identity();
-    }
-    store.save("_main", identity);
-  }
-}
-
-void onSetRadio(float freq, float bw, uint8_t sf, uint8_t cr) {
-  radio_set_params(freq, bw, sf, cr);
-}
-
-void onSetTxPower(uint8_t power) {
-  radio_set_tx_power(power);
-}
-
-float onGetCurrentRssi() {
-  return radio_driver.getCurrentRSSI();
-}
-
-void onGetStats(uint32_t* rx, uint32_t* tx, uint32_t* errors) {
-  *rx = radio_driver.getPacketsRecv();
-  *tx = radio_driver.getPacketsSent();
-  *errors = radio_driver.getPacketsRecvErrors();
-}
-
-void setup() {
-  board.begin();
-
-  if (!radio_init()) {
-    halt();
-  }
-
-  radio_driver.begin();
-
-  rng.begin(radio_get_rng_seed());
-  loadOrCreateIdentity();
-
-  sensors.begin();
-
-#if defined(KISS_UART_RX) && defined(KISS_UART_TX)
-#if defined(ESP32)
-  Serial1.setPins(KISS_UART_RX, KISS_UART_TX);
-  Serial1.begin(115200);
-#elif defined(NRF52_PLATFORM)
-  ((Uart *)&Serial1)->setPins(KISS_UART_RX, KISS_UART_TX);
-  Serial1.begin(115200);
-#elif defined(RP2040_PLATFORM)
-  ((SerialUART *)&Serial1)->setRX(KISS_UART_RX);
-  ((SerialUART *)&Serial1)->setTX(KISS_UART_TX);
-  Serial1.begin(115200);
-#elif defined(STM32_PLATFORM)
-  ((HardwareSerial *)&Serial1)->setRx(KISS_UART_RX);
-  ((HardwareSerial *)&Serial1)->setTx(KISS_UART_TX);
-  Serial1.begin(115200);
-#else
-  #error "KISS UART not supported on this platform"
-#endif
-  modem = new KissModem(Serial1, identity, rng, radio_driver, board, sensors);
-#else
-  Serial.begin(115200);
-  uint32_t start = millis();
-  while (!Serial && millis() - start < 3000) delay(10);
-  delay(100);
-  modem = new KissModem(Serial, identity, rng, radio_driver, board, sensors);
-#endif
-
-  modem->setRadioCallback(onSetRadio);
-  modem->setTxPowerCallback(onSetTxPower);
-  modem->setGetCurrentRssiCallback(onGetCurrentRssi);
-  modem->setGetStatsCallback(onGetStats);
-  modem->begin();
-}
-
-void loop() {
-  modem->loop();
-
-  if (!modem->isActuallyTransmitting()) {
-    if (!modem->isTxBusy()) {
-      if ((uint32_t)(millis() - next_agc_reset_ms) >= AGC_RESET_INTERVAL_MS) {
-        radio_driver.resetAGC();
-        next_agc_reset_ms = millis();
-      }
-    }
-
-    uint8_t rx_buf[256];
-    int rx_len = radio_driver.recvRaw(rx_buf, sizeof(rx_buf));
-    if (rx_len > 0) {
-      int8_t snr = (int8_t)(radio_driver.getLastSNR() * 4);
-      int8_t rssi = (int8_t)radio_driver.getLastRSSI();
-      modem->onPacketReceived(snr, rssi, rx_buf, rx_len);
-    }
-  }
-
-  if ((uint32_t)(millis() - next_noise_floor_calib_ms) >= NOISE_FLOOR_CALIB_INTERVAL_MS) {
-    radio_driver.triggerNoiseFloorCalibrate(0);
-    next_noise_floor_calib_ms = millis();
-  }
-  radio_driver.loop();
-}

examples/simple_repeater/MyMesh.cpp

@@ -226,7 +226,7 @@ int MyMesh::handleRequest(ClientInfo *sender, uint32_t sender_timestamp, uint8_t
     stats.n_direct_dups = ((SimpleMeshTables *)getTables())->getNumDirectDups();
     stats.n_flood_dups = ((SimpleMeshTables *)getTables())->getNumFloodDups();
     stats.total_rx_air_time_secs = getReceiveAirTime() / 1000;
-    stats.n_recv_errors = radio_driver.getPacketsRecvErrors();
+
     memcpy(&reply_data[4], &stats, sizeof(stats));
 
     return 4 + sizeof(stats); //  reply_len
@@ -719,6 +719,12 @@ bool MyMesh::onPeerPathRecv(mesh::Packet *packet, int sender_idx, const uint8_t
 #define CTL_TYPE_NODE_DISCOVER_RESP  0x90
 
 void MyMesh::onControlDataRecv(mesh::Packet* packet) {
+  if (!packet->payload) {
+    MESH_DEBUG_PRINTLN("onControlDataRecv: packet->payload is null");
+    return;
+  }
+
+#if !defined(STEALTH_MODE)
   uint8_t type = packet->payload[0] & 0xF0;    // just test upper 4 bits
   if (type == CTL_TYPE_NODE_DISCOVER_REQ && packet->payload_len >= 6
       && !_prefs.disable_fwd && discover_limiter.allow(rtc_clock.getCurrentTime())
@@ -747,12 +753,13 @@ void MyMesh::onControlDataRecv(mesh::Packet* packet) {
       }
     }
   }
+#endif
 }
 
 MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondClock &ms, mesh::RNG &rng,
                mesh::RTCClock &rtc, mesh::MeshTables &tables)
     : mesh::Mesh(radio, ms, rng, rtc, *new StaticPoolPacketManager(32), tables),
-      _cli(board, rtc, sensors, acl, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4), region_map(key_store), temp_map(key_store),
+      _cli(board, rtc, sensors, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4), region_map(key_store), temp_map(key_store),
       discover_limiter(4, 120),  // max 4 every 2 minutes
       anon_limiter(4, 180)   // max 4 every 3 minutes
 #if defined(WITH_RS232_BRIDGE)
@@ -776,7 +783,7 @@ MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondCloc
 
   // defaults
   memset(&_prefs, 0, sizeof(_prefs));
-  _prefs.airtime_factor = 1.0;
+  _prefs.airtime_factor = 1.0;   // one half
   _prefs.rx_delay_base = 0.0f;   // turn off by default, was 10.0;
   _prefs.tx_delay_factor = 0.5f; // was 0.25f
   _prefs.direct_tx_delay_factor = 0.2f; // was zero
@@ -789,8 +796,8 @@ MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondCloc
   _prefs.bw = LORA_BW;
   _prefs.cr = LORA_CR;
   _prefs.tx_power_dbm = LORA_TX_POWER;
-  _prefs.advert_interval = 1;        // default to 2 minutes for NEW installs
-  _prefs.flood_advert_interval = 12; // 12 hours
+  _prefs.advert_interval = DEF_LOCAL_ADVERT_INTERVAL;
+  _prefs.flood_advert_interval = DEF_FLOOD_ADVERT_INTERVAL;
   _prefs.flood_advert_base = 0.308f;
   _prefs.flood_max = 64;
   _prefs.interference_threshold = 0; // disabled
@@ -817,7 +824,7 @@ void MyMesh::begin(FILESYSTEM *fs) {
   _fs = fs;
   // load persisted prefs
   _cli.loadPrefs(_fs);
-  acl.load(_fs, self_id);
+  acl.load(_fs);
   // TODO: key_store.begin();
   region_map.load(_fs);
 
@@ -908,7 +915,7 @@ void MyMesh::dumpLogFile() {
   }
 }
 
-void MyMesh::setTxPower(int8_t power_dbm) {
+void MyMesh::setTxPower(uint8_t power_dbm) {
   radio_set_tx_power(power_dbm);
 }
 
@@ -981,6 +988,7 @@ void MyMesh::formatPacketStatsReply(char *reply) {
 }
 
 void MyMesh::saveIdentity(const mesh::LocalIdentity &new_id) {
+  self_id = new_id;
 #if defined(NRF52_PLATFORM) || defined(STM32_PLATFORM)
   IdentityStore store(*_fs, "");
 #elif defined(ESP32)
@@ -990,7 +998,7 @@ void MyMesh::saveIdentity(const mesh::LocalIdentity &new_id) {
 #else
 #error "need to define saveIdentity()"
 #endif
-  store.save("_main", new_id);
+  store.save("_main", self_id);
 }
 
 void MyMesh::clearStats() {
@@ -1081,8 +1089,8 @@ void MyMesh::handleCommand(uint32_t sender_timestamp, char *command, char *reply
 
     const char* parts[4];
     int n = mesh::Utils::parseTextParts(command, parts, 4, ' ');
-    if (n == 1) {
-      region_map.exportTo(reply, 160);
+    if (n == 1 && sender_timestamp == 0) {
+      region_map.exportTo(Serial);
     } else if (n >= 2 && strcmp(parts[1], "load") == 0) {
       temp_map.resetFrom(region_map);   // rebuild regions in a temp instance
       memset(load_stack, 0, sizeof(load_stack));
@@ -1155,25 +1163,6 @@ void MyMesh::handleCommand(uint32_t sender_timestamp, char *command, char *reply
       } else {
         strcpy(reply, "Err - not found");
       }
-    } else if (n >= 3 && strcmp(parts[1], "list") == 0) {
-      uint8_t mask = 0;
-      bool invert = false;
-      
-      if (strcmp(parts[2], "allowed") == 0) {
-        mask = REGION_DENY_FLOOD;
-        invert = false;  // list regions that DON'T have DENY flag
-      } else if (strcmp(parts[2], "denied") == 0) {
-        mask = REGION_DENY_FLOOD;
-        invert = true;   // list regions that DO have DENY flag
-      } else {
-        strcpy(reply, "Err - use 'allowed' or 'denied'");
-        return;
-      }
-      
-      int len = region_map.exportNamesTo(reply, 160, mask, invert);
-      if (len == 0) {
-        strcpy(reply, "-none-");
-      }
     } else {
       strcpy(reply, "Err - ??");
     }
@@ -1228,8 +1217,5 @@ void MyMesh::loop() {
 
 // To check if there is pending work
 bool MyMesh::hasPendingWork() const {
-#if defined(WITH_BRIDGE)
-  if (bridge.isRunning()) return true;  // bridge needs WiFi radio, can't sleep
-#endif
   return _mgr->getOutboundCount(0xFFFFFFFF) > 0;
 }

examples/simple_repeater/MyMesh.h

@@ -54,7 +54,6 @@ struct RepeaterStats {
   int16_t  last_snr;   // x 4
   uint16_t n_direct_dups, n_flood_dups;
   uint32_t total_rx_air_time_secs;
-  uint32_t n_recv_errors;
 };
 
 #ifndef MAX_CLIENTS
@@ -69,11 +68,11 @@ struct NeighbourInfo {
 };
 
 #ifndef FIRMWARE_BUILD_DATE
-  #define FIRMWARE_BUILD_DATE   "29 Jan 2026"
+  #define FIRMWARE_BUILD_DATE   "30 Nov 2025"
 #endif
 
 #ifndef FIRMWARE_VERSION
-  #define FIRMWARE_VERSION   "v1.12.0"
+  #define FIRMWARE_VERSION   "v1.11.0"
 #endif
 
 #define FIRMWARE_ROLE "repeater"
@@ -87,11 +86,11 @@ class MyMesh : public mesh::Mesh, public CommonCLICallbacks {
   unsigned long next_local_advert, next_flood_advert;
   bool _logging;
   NodePrefs _prefs;
-  ClientACL  acl;
   CommonCLI _cli;
   uint8_t reply_data[MAX_PACKET_PAYLOAD];
   uint8_t reply_path[MAX_PATH_SIZE];
   int8_t  reply_path_len;
+  ClientACL  acl;
   TransportKeyStore key_store;
   RegionMap region_map, temp_map;
   RegionEntry* load_stack[8];
@@ -187,7 +186,7 @@ public:
 
   void applyTempRadioParams(float freq, float bw, uint8_t sf, uint8_t cr, int timeout_mins) override;
   bool formatFileSystem() override;
-  void sendSelfAdvertisement(int delay_millis, bool flood) override;
+  void sendSelfAdvertisement(int delay_millis, bool flood = true) override;
   void updateAdvertTimer() override;
   void updateFloodAdvertTimer() override;
 
@@ -198,7 +197,7 @@ public:
   }
 
   void dumpLogFile() override;
-  void setTxPower(int8_t power_dbm) override;
+  void setTxPower(uint8_t power_dbm) override;
   void formatNeighborsReply(char *reply) override;
   void removeNeighbor(const uint8_t* pubkey, int key_len) override;
   void formatStatsReply(char *reply) override;

examples/simple_repeater/main.cpp

@@ -29,12 +29,6 @@ void setup() {
 
   board.begin();
 
-#if defined(MESH_DEBUG) && defined(NRF52_PLATFORM)
-  // give some extra time for serial to settle so
-  // boot debug messages can be seen on terminal
-  delay(5000);
-#endif
-
   // For power saving
   lastActive = millis(); // mark last active time since boot
 
@@ -48,7 +42,6 @@ void setup() {
 #endif
 
   if (!radio_init()) {
-    MESH_DEBUG_PRINTLN("Radio init failed!");
     halt();
   }
 
@@ -94,8 +87,8 @@ void setup() {
   ui_task.begin(the_mesh.getNodePrefs(), FIRMWARE_BUILD_DATE, FIRMWARE_VERSION);
 #endif
 
-  // send out initial zero hop Advertisement to the mesh
-#if ENABLE_ADVERT_ON_BOOT == 1
+#if !defined(STEALTH_MODE) && !defined(NO_BOOT_ADVERT)
+  // send out initial Zero Hop Advertisement to the mesh
   the_mesh.sendSelfAdvertisement(16000, false);
 #endif
 }
@@ -134,17 +127,14 @@ void loop() {
 #endif
   rtc_clock.tick();
 
-  if (the_mesh.getNodePrefs()->powersaving_enabled && !the_mesh.hasPendingWork()) {
-    #if defined(NRF52_PLATFORM)
-    board.sleep(1800); // nrf ignores seconds param, sleeps whenever possible
-    #else
-    if (the_mesh.millisHasNowPassed(lastActive + nextSleepinSecs * 1000)) { // To check if it is time to sleep
+  if (the_mesh.getNodePrefs()->powersaving_enabled &&                     // To check if power saving is enabled
+      the_mesh.millisHasNowPassed(lastActive + nextSleepinSecs * 1000)) { // To check if it is time to sleep
+    if (!the_mesh.hasPendingWork()) { // No pending work. Safe to sleep
       board.sleep(1800);             // To sleep. Wake up after 30 minutes or when receiving a LoRa packet
       lastActive = millis();
       nextSleepinSecs = 5;  // Default: To work for 5s and sleep again
     } else {
       nextSleepinSecs += 5; // When there is pending work, to work another 5s
     }
-    #endif
   }
 }

examples/simple_room_server/MyMesh.cpp

@@ -596,7 +596,7 @@ void MyMesh::onAckRecv(mesh::Packet *packet, uint32_t ack_crc) {
 MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondClock &ms, mesh::RNG &rng,
                mesh::RTCClock &rtc, mesh::MeshTables &tables)
     : mesh::Mesh(radio, ms, rng, rtc, *new StaticPoolPacketManager(32), tables),
-      _cli(board, rtc, sensors, acl, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4) {
+      _cli(board, rtc, sensors, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4) {
   last_millis = 0;
   uptime_millis = 0;
   next_local_advert = next_flood_advert = 0;
@@ -606,7 +606,7 @@ MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondCloc
 
   // defaults
   memset(&_prefs, 0, sizeof(_prefs));
-  _prefs.airtime_factor = 1.0;
+  _prefs.airtime_factor = 1.0;   // one half
   _prefs.rx_delay_base = 0.0f;   // off by default, was 10.0
   _prefs.tx_delay_factor = 0.5f; // was 0.25f;
   _prefs.direct_tx_delay_factor = 0.2f; // was zero
@@ -620,8 +620,8 @@ MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondCloc
   _prefs.cr = LORA_CR;
   _prefs.tx_power_dbm = LORA_TX_POWER;
   _prefs.disable_fwd = 1;
-  _prefs.advert_interval = 1;        // default to 2 minutes for NEW installs
-  _prefs.flood_advert_interval = 12; // 12 hours
+  _prefs.advert_interval = DEF_LOCAL_ADVERT_INTERVAL;
+  _prefs.flood_advert_interval = DEF_FLOOD_ADVERT_INTERVAL;
   _prefs.flood_advert_base = 0.308f;
   _prefs.flood_max = 64;
   _prefs.interference_threshold = 0; // disabled
@@ -647,7 +647,7 @@ void MyMesh::begin(FILESYSTEM *fs) {
   // load persisted prefs
   _cli.loadPrefs(_fs);
 
-  acl.load(_fs, self_id);
+  acl.load(_fs);
 
   radio_set_params(_prefs.freq, _prefs.bw, _prefs.sf, _prefs.cr);
   radio_set_tx_power(_prefs.tx_power_dbm);
@@ -729,11 +729,12 @@ void MyMesh::dumpLogFile() {
   }
 }
 
-void MyMesh::setTxPower(int8_t power_dbm) {
+void MyMesh::setTxPower(uint8_t power_dbm) {
   radio_set_tx_power(power_dbm);
 }
 
 void MyMesh::saveIdentity(const mesh::LocalIdentity &new_id) {
+  self_id = new_id;
 #if defined(NRF52_PLATFORM) || defined(STM32_PLATFORM)
   IdentityStore store(*_fs, "");
 #elif defined(ESP32)
@@ -743,7 +744,7 @@ void MyMesh::saveIdentity(const mesh::LocalIdentity &new_id) {
 #else
 #error "need to define saveIdentity()"
 #endif
-  store.save("_main", new_id);
+  store.save("_main", self_id);
 }
 
 void MyMesh::clearStats() {

examples/simple_room_server/MyMesh.h

@@ -26,11 +26,11 @@
 /* ------------------------------ Config -------------------------------- */
 
 #ifndef FIRMWARE_BUILD_DATE
-  #define FIRMWARE_BUILD_DATE   "29 Jan 2026"
+  #define FIRMWARE_BUILD_DATE   "30 Nov 2025"
 #endif
 
 #ifndef FIRMWARE_VERSION
-  #define FIRMWARE_VERSION   "v1.12.0"
+  #define FIRMWARE_VERSION   "v1.11.0"
 #endif
 
 #ifndef LORA_FREQ
@@ -94,8 +94,8 @@ class MyMesh : public mesh::Mesh, public CommonCLICallbacks {
   unsigned long next_local_advert, next_flood_advert;
   bool _logging;
   NodePrefs _prefs;
-  ClientACL acl;
   CommonCLI _cli;
+  ClientACL acl;
   unsigned long dirty_contacts_expiry;
   uint8_t reply_data[MAX_PACKET_PAYLOAD];
   unsigned long next_push;
@@ -177,7 +177,7 @@ public:
 
   void applyTempRadioParams(float freq, float bw, uint8_t sf, uint8_t cr, int timeout_mins) override;
   bool formatFileSystem() override;
-  void sendSelfAdvertisement(int delay_millis, bool flood) override;
+  void sendSelfAdvertisement(int delay_millis, bool flood = true) override;
   void updateAdvertTimer() override;
   void updateFloodAdvertTimer() override;
 
@@ -188,7 +188,7 @@ public:
   }
 
   void dumpLogFile() override;
-  void setTxPower(int8_t power_dbm) override;
+  void setTxPower(uint8_t power_dbm) override;
 
   void formatNeighborsReply(char *reply) override {
     strcpy(reply, "not supported");

examples/simple_room_server/main.cpp

@@ -76,8 +76,8 @@ void setup() {
   ui_task.begin(the_mesh.getNodePrefs(), FIRMWARE_BUILD_DATE, FIRMWARE_VERSION);
 #endif
 
-  // send out initial zero hop Advertisement to the mesh
-#if ENABLE_ADVERT_ON_BOOT == 1
+#if !defined(STEALTH_MODE) && !defined(NO_BOOT_ADVERT)
+  // send out initial Zero Hop Advertisement to the mesh
   the_mesh.sendSelfAdvertisement(16000, false);
 #endif
 }

examples/simple_secure_chat/main.cpp

@@ -66,7 +66,7 @@ struct NodePrefs {  // persisted to file
   char node_name[32];
   double node_lat, node_lon;
   float freq;
-  int8_t tx_power_dbm;
+  uint8_t tx_power_dbm;
   uint8_t unused[3];
 };
 
@@ -280,7 +280,7 @@ public:
   {
     // defaults
     memset(&_prefs, 0, sizeof(_prefs));
-    _prefs.airtime_factor = 1.0;
+    _prefs.airtime_factor = 2.0;    // one third
     strcpy(_prefs.node_name, "NONAME");
     _prefs.freq = LORA_FREQ;
     _prefs.tx_power_dbm = LORA_TX_POWER;
@@ -290,7 +290,7 @@ public:
   }
 
   float getFreqPref() const { return _prefs.freq; }
-  int8_t getTxPowerPref() const { return _prefs.tx_power_dbm; }
+  uint8_t getTxPowerPref() const { return _prefs.tx_power_dbm; }
 
   void begin(FILESYSTEM& fs) {
     _fs = &fs;
@@ -582,9 +582,7 @@ void setup() {
   the_mesh.showWelcome();
 
   // send out initial Advertisement to the mesh
-#if ENABLE_ADVERT_ON_BOOT == 1
   the_mesh.sendSelfAdvert(1200);   // add slight delay
-#endif
 }
 
 void loop() {

examples/simple_sensor/SensorMesh.cpp

@@ -695,7 +695,7 @@ void SensorMesh::onAckRecv(mesh::Packet* packet, uint32_t ack_crc) {
 
 SensorMesh::SensorMesh(mesh::MainBoard& board, mesh::Radio& radio, mesh::MillisecondClock& ms, mesh::RNG& rng, mesh::RTCClock& rtc, mesh::MeshTables& tables)
      : mesh::Mesh(radio, ms, rng, rtc, *new StaticPoolPacketManager(32), tables),
-      _cli(board, rtc, sensors, acl, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4)
+      _cli(board, rtc, sensors, &_prefs, this), telemetry(MAX_PACKET_PAYLOAD - 4)
 {
   next_local_advert = next_flood_advert = 0;
   dirty_contacts_expiry = 0;
@@ -705,7 +705,7 @@ SensorMesh::SensorMesh(mesh::MainBoard& board, mesh::Radio& radio, mesh::Millise
 
   // defaults
   memset(&_prefs, 0, sizeof(_prefs));
-  _prefs.airtime_factor = 1.0;
+  _prefs.airtime_factor = 1.0;    // one half
   _prefs.rx_delay_base =   0.0f;  // turn off by default, was 10.0;
   _prefs.tx_delay_factor = 0.5f;   // was 0.25f
   _prefs.direct_tx_delay_factor = 0.2f; // was zero
@@ -718,7 +718,7 @@ SensorMesh::SensorMesh(mesh::MainBoard& board, mesh::Radio& radio, mesh::Millise
   _prefs.bw = LORA_BW;
   _prefs.cr = LORA_CR;
   _prefs.tx_power_dbm = LORA_TX_POWER;
-  _prefs.advert_interval = 1;  // default to 2 minutes for NEW installs
+  _prefs.advert_interval = DEF_LOCAL_ADVERT_INTERVAL;
   _prefs.flood_advert_interval = 0;   // disabled
   _prefs.disable_fwd = true;
   _prefs.flood_max = 64;
@@ -736,7 +736,7 @@ void SensorMesh::begin(FILESYSTEM* fs) {
   // load persisted prefs
   _cli.loadPrefs(_fs);
 
-  acl.load(_fs, self_id);
+  acl.load(_fs);
 
   radio_set_params(_prefs.freq, _prefs.bw, _prefs.sf, _prefs.cr);
   radio_set_tx_power(_prefs.tx_power_dbm);
@@ -765,6 +765,7 @@ bool SensorMesh::formatFileSystem() {
 }
 
 void SensorMesh::saveIdentity(const mesh::LocalIdentity& new_id) {
+  self_id = new_id;
 #if defined(NRF52_PLATFORM) || defined(STM32_PLATFORM)
   IdentityStore store(*_fs, "");
 #elif defined(ESP32)
@@ -774,7 +775,7 @@ void SensorMesh::saveIdentity(const mesh::LocalIdentity& new_id) {
 #else
   #error "need to define saveIdentity()"
 #endif
-  store.save("_main", new_id);
+  store.save("_main", self_id);
 }
 
 void SensorMesh::applyTempRadioParams(float freq, float bw, uint8_t sf, uint8_t cr, int timeout_mins) {
@@ -815,7 +816,7 @@ void SensorMesh::updateFloodAdvertTimer() {
   }
 }
 
-void SensorMesh::setTxPower(int8_t power_dbm) {
+void SensorMesh::setTxPower(uint8_t power_dbm) {
   radio_set_tx_power(power_dbm);
 }
 

examples/simple_sensor/SensorMesh.h

@@ -33,11 +33,11 @@
 #define PERM_RECV_ALERTS_HI    (1 << 7)   // high priority alerts
 
 #ifndef FIRMWARE_BUILD_DATE
-  #define FIRMWARE_BUILD_DATE   "29 Jan 2026"
+  #define FIRMWARE_BUILD_DATE   "30 Nov 2025"
 #endif
 
 #ifndef FIRMWARE_VERSION
-  #define FIRMWARE_VERSION   "v1.12.0"
+  #define FIRMWARE_VERSION   "v1.11.0"
 #endif
 
 #define FIRMWARE_ROLE "sensor"
@@ -60,13 +60,13 @@ public:
   NodePrefs* getNodePrefs() { return &_prefs; }
   void savePrefs() override { _cli.savePrefs(_fs); }
   bool formatFileSystem() override;
-  void sendSelfAdvertisement(int delay_millis, bool flood) override;
+  void sendSelfAdvertisement(int delay_millis, bool flood = true) override;
   void updateAdvertTimer() override;
   void updateFloodAdvertTimer() override;
   void setLoggingOn(bool enable) override {  }
   void eraseLogFile() override { }
   void dumpLogFile() override { }
-  void setTxPower(int8_t power_dbm) override;
+  void setTxPower(uint8_t power_dbm) override;
   void formatNeighborsReply(char *reply) override {
     strcpy(reply, "not supported");
   }
@@ -133,9 +133,9 @@ private:
   FILESYSTEM* _fs;
   unsigned long next_local_advert, next_flood_advert;
   NodePrefs _prefs;
-  ClientACL  acl;
   CommonCLI _cli;
   uint8_t reply_data[MAX_PACKET_PAYLOAD];
+  ClientACL  acl;
   unsigned long dirty_contacts_expiry;
   CayenneLPP telemetry;
   uint32_t last_read_time;

examples/simple_sensor/main.cpp

@@ -110,8 +110,8 @@ void setup() {
   ui_task.begin(the_mesh.getNodePrefs(), FIRMWARE_BUILD_DATE, FIRMWARE_VERSION);
 #endif
 
-  // send out initial zero hop Advertisement to the mesh
-#if ENABLE_ADVERT_ON_BOOT == 1
+#if !defined(STEALTH_MODE) && !defined(NO_BOOT_ADVERT)
+  // send out initial Zero Hop Advertisement to the mesh
   the_mesh.sendSelfAdvertisement(16000, false);
 #endif
 }

fetch_prs.sh

@@ -1,8 +0,0 @@
-#!/bin/sh
-
-git branch -D pr-1297
-git branch -D pr-1338
-
-# fetch PRs
-git fetch upstream pull/1338/head:pr-1338
-git fetch upstream pull/1297/head:pr-1297

merge_prs.sh

@@ -1,8 +0,0 @@
-#!/bin/sh
-
-git merge pr-1338 --no-edit -m "Integration of upstrem PR #1338"
-git merge pr-1297 --no-edit -m "Integration of upstrem PR #1297"
-
-git merge pio-ini-adjustments -m "platformio.ini: Adjust defaults for LoRa frequncies and advert interval limits"
-
-

platformio.ini

@@ -23,13 +23,16 @@ lib_deps =
   adafruit/RTClib @ ^2.1.3
   melopero/Melopero RV3028 @ ^1.1.0
   electroniccats/CayenneLPP @ 1.6.1
-build_flags = -w -DNDEBUG -DRADIOLIB_STATIC_ONLY=1 -DRADIOLIB_GODMODE=1
+build_flags = -w -DNDEBUG
   -D LORA_FREQ=869.525
   -D LORA_BW=250
   -D LORA_SF=11
-  -D ENABLE_ADVERT_ON_BOOT=1
+  ;
   -D ENABLE_PRIVATE_KEY_IMPORT=1   ; NOTE: comment these out for more secure firmware
   -D ENABLE_PRIVATE_KEY_EXPORT=1
+  ;
+  -D RADIOLIB_STATIC_ONLY=1
+  -D RADIOLIB_GODMODE=1
   -D RADIOLIB_EXCLUDE_CC1101=1
   -D RADIOLIB_EXCLUDE_RF69=1
   -D RADIOLIB_EXCLUDE_SX1231=1
@@ -44,6 +47,15 @@ build_flags = -w -DNDEBUG -DRADIOLIB_STATIC_ONLY=1 -DRADIOLIB_GODMODE=1
   -D RADIOLIB_EXCLUDE_BELL=1
   -D RADIOLIB_EXCLUDE_RTTY=1
   -D RADIOLIB_EXCLUDE_SSTV=1
+  ;
+  -D MIN_LOCAL_ADVERT_INTERVAL=60
+  -D MAX_LOCAL_ADVERT_INTERVAL=240
+  -D DEF_LOCAL_ADVERT_INTERVAL=1    ; default to 2 minutes for NEW installs
+  -D MIN_FLOOD_ADVERT_INTERVAL=3
+  -D MAX_FLOOD_ADVERT_INTERVAL=48
+  -D DEF_FLOOD_ADVERT_INTERVAL=12   ; default to 12 hours for NEW installs
+  ; -D NO_BOOT_ADVERT=1 ; disable boot advertisement
+  ; -D STEALTH_MODE=1   ; disable all advertisements and DISCOVER_REQ
 build_src_filter =
   +<*.cpp>
   +<helpers/*.cpp>
@@ -68,10 +80,10 @@ lib_deps =
   file://arch/esp32/AsyncElegantOTA
 
 ; esp32c6 uses arduino framework 3.x
-; WARNING: experimental. May not work as stable as other platforms.
+; WARNING: experimental. pioarduino on esp32c6 needs work - it's not considered stable and has issues.
 [esp32c6_base]
 extends = esp32_base
-platform = https://github.com/pioarduino/platform-espressif32/releases/download/53.03.13-1/platform-espressif32.zip
+platform = https://github.com/pioarduino/platform-espressif32/releases/download/53.03.12/platform-espressif32.zip
 
 ; ----------------- NRF52 ---------------------
 
@@ -80,7 +92,7 @@ extends = arduino_base
 platform = nordicnrf52
 platform_packages =
   framework-arduinoadafruitnrf52 @ 1.10700.0
-extra_scripts =
+extra_scripts = 
   create-uf2.py
   arch/nrf52/extra_scripts/patch_bluefruit.py
 build_flags = ${arduino_base.build_flags}

src/Dispatcher.cpp

@@ -8,9 +8,7 @@
 
 namespace mesh {
 
-#define MAX_RX_DELAY_MILLIS        32000  // 32 seconds
-#define MIN_TX_BUDGET_RESERVE_MS   100    // min budget (ms) required before allowing next TX
-#define MIN_TX_BUDGET_AIRTIME_DIV  2      // require at least 1/N of estimated airtime as budget before TX
+#define MAX_RX_DELAY_MILLIS   32000  // 32 seconds
 
 #ifndef NOISE_FLOOR_CALIB_INTERVAL
   #define NOISE_FLOOR_CALIB_INTERVAL   2000     // 2 seconds
@@ -22,34 +20,12 @@ void Dispatcher::begin() {
   _err_flags = 0;
   radio_nonrx_start = _ms->getMillis();
 
-  duty_cycle_window_ms = getDutyCycleWindowMs();
-  float duty_cycle = 1.0f / (1.0f + getAirtimeBudgetFactor());
-  tx_budget_ms = (unsigned long)(duty_cycle_window_ms * duty_cycle);
-  last_budget_update = _ms->getMillis();
-
   _radio->begin();
   prev_isrecv_mode = _radio->isInRecvMode();
 }
 
 float Dispatcher::getAirtimeBudgetFactor() const {
-  return 1.0;
-}
-
-void Dispatcher::updateTxBudget() {
-  unsigned long now = _ms->getMillis();
-  unsigned long elapsed = now - last_budget_update;
-
-  float duty_cycle = 1.0f / (1.0f + getAirtimeBudgetFactor());
-  unsigned long max_budget = (unsigned long)(getDutyCycleWindowMs() * duty_cycle);
-  unsigned long refill = (unsigned long)(elapsed * duty_cycle);
-  
-  if (refill > 0) {
-    tx_budget_ms += refill;
-    if (tx_budget_ms > max_budget) {
-      tx_budget_ms = max_budget;
-    }
-    last_budget_update = now;
-  }
+  return 2.0;   // default, 33.3%  (1/3rd)
 }
 
 int Dispatcher::calcRxDelay(float score, uint32_t air_time) const {
@@ -85,24 +61,11 @@ void Dispatcher::loop() {
   if (outbound) {  // waiting for outbound send to be completed
     if (_radio->isSendComplete()) {
       long t = _ms->getMillis() - outbound_start;
-      total_air_time += t;
+      total_air_time += t;  // keep track of how much air time we are using
       //Serial.print("  airtime="); Serial.println(t);
 
-      updateTxBudget();
-
-      if (t > tx_budget_ms) {
-        tx_budget_ms = 0;
-      } else {
-        tx_budget_ms -= t;
-      }
-
-      if (tx_budget_ms < MIN_TX_BUDGET_RESERVE_MS) {
-        float duty_cycle = 1.0f / (1.0f + getAirtimeBudgetFactor());
-        unsigned long needed = MIN_TX_BUDGET_RESERVE_MS - tx_budget_ms;
-        next_tx_time = futureMillis((unsigned long)(needed / duty_cycle));
-      } else {
-        next_tx_time = _ms->getMillis();
-      }
+      // will need radio silence up to next_tx_time
+      next_tx_time = futureMillis(t * getAirtimeBudgetFactor());
 
       _radio->onSendFinished();
       logTx(outbound, 2 + outbound->path_len + outbound->payload_len);
@@ -261,20 +224,9 @@ void Dispatcher::processRecvPacket(Packet* pkt) {
 }
 
 void Dispatcher::checkSend() {
-  if (_mgr->getOutboundCount(_ms->getMillis()) == 0) return;
-  
-  updateTxBudget();
-  
-  uint32_t est_airtime = _radio->getEstAirtimeFor(MAX_TRANS_UNIT);
-  if (tx_budget_ms < est_airtime / MIN_TX_BUDGET_AIRTIME_DIV) {
-    float duty_cycle = 1.0f / (1.0f + getAirtimeBudgetFactor());
-    unsigned long needed = est_airtime / MIN_TX_BUDGET_AIRTIME_DIV - tx_budget_ms;
-    next_tx_time = futureMillis((unsigned long)(needed / duty_cycle));
-    return;
-  }
-  
-  if (!millisHasNowPassed(next_tx_time)) return;
-  if (_radio->isReceiving()) {
+  if (_mgr->getOutboundCount(_ms->getMillis()) == 0) return;  // nothing waiting to send
+  if (!millisHasNowPassed(next_tx_time)) return;   // still in 'radio silence' phase (from airtime budget setting)
+  if (_radio->isReceiving()) {   // LBT - check if radio is currently mid-receive, or if channel activity
     if (cad_busy_start == 0) {
       cad_busy_start = _ms->getMillis();   // record when CAD busy state started
     }

src/Dispatcher.h

@@ -122,12 +122,8 @@ class Dispatcher {
   bool  prev_isrecv_mode;
   uint32_t n_sent_flood, n_sent_direct;
   uint32_t n_recv_flood, n_recv_direct;
-  unsigned long tx_budget_ms;
-  unsigned long last_budget_update;
-  unsigned long duty_cycle_window_ms;
 
   void processRecvPacket(Packet* pkt);
-  void updateTxBudget();
 
 protected:
   PacketManager* _mgr;
@@ -146,9 +142,6 @@ protected:
     _err_flags = 0;
     radio_nonrx_start = 0;
     prev_isrecv_mode = true;
-    tx_budget_ms = 0;
-    last_budget_update = 0;
-    duty_cycle_window_ms = 3600000;
   }
 
   virtual DispatcherAction onRecvPacket(Packet* pkt) = 0;
@@ -166,7 +159,6 @@ protected:
   virtual uint32_t getCADFailMaxDuration() const;
   virtual int getInterferenceThreshold() const { return 0; }    // disabled by default
   virtual int getAGCResetInterval() const { return 0; }    // disabled by default
-  virtual unsigned long getDutyCycleWindowMs() const { return 3600000; }
 
 public:
   void begin();
@@ -176,9 +168,8 @@ public:
   void releasePacket(Packet* packet);
   void sendPacket(Packet* packet, uint8_t priority, uint32_t delay_millis=0);
 
-  unsigned long getTotalAirTime() const { return total_air_time; }
+  unsigned long getTotalAirTime() const { return total_air_time; }  // in milliseconds
   unsigned long getReceiveAirTime() const {return rx_air_time; }
-  unsigned long getRemainingTxBudget() const { return tx_budget_ms; }
   uint32_t getNumSentFlood() const { return n_sent_flood; }
   uint32_t getNumSentDirect() const { return n_sent_direct; }
   uint32_t getNumRecvFlood() const { return n_recv_flood; }

src/Identity.cpp

@@ -48,50 +48,6 @@ LocalIdentity::LocalIdentity(RNG* rng) {
   ed25519_create_keypair(pub_key, prv_key, seed);
 }
 
-bool LocalIdentity::validatePrivateKey(const uint8_t prv[64]) {
-    uint8_t pub[32];
-    ed25519_derive_pub(pub, prv); // derive public key from given private key
-
-    // disallow 00 or FF prefixed public keys
-    if (pub[0] == 0x00 || pub[0] == 0xFF) return false;
-
-    // known good test client keypair
-    const uint8_t test_client_prv[64] = {
-      0x70, 0x65, 0xe1, 0x8f, 0xd9, 0xfa, 0xbb, 0x70,
-      0xc1, 0xed, 0x90, 0xdc, 0xa1, 0x99, 0x07, 0xde,
-      0x69, 0x8c, 0x88, 0xb7, 0x09, 0xea, 0x14, 0x6e,
-      0xaf, 0xd9, 0x3d, 0x9b, 0x83, 0x0c, 0x7b, 0x60,
-      0xc4, 0x68, 0x11, 0x93, 0xc7, 0x9b, 0xbc, 0x39,
-      0x94, 0x5b, 0xa8, 0x06, 0x41, 0x04, 0xbb, 0x61,
-      0x8f, 0x8f, 0xd7, 0xa8, 0x4a, 0x0a, 0xf6, 0xf5,
-      0x70, 0x33, 0xd6, 0xe8, 0xdd, 0xcd, 0x64, 0x71
-    };
-    const uint8_t test_client_pub[32] = {
-      0x1e, 0xc7, 0x71, 0x75, 0xb0, 0x91, 0x8e, 0xd2,
-      0x06, 0xf9, 0xae, 0x04, 0xec, 0x13, 0x6d, 0x6d,
-      0x5d, 0x43, 0x15, 0xbb, 0x26, 0x30, 0x54, 0x27,
-      0xf6, 0x45, 0xb4, 0x92, 0xe9, 0x35, 0x0c, 0x10
-    };
-
-    uint8_t ss1[32], ss2[32];
-
-    // shared secret we calculte from test client pubkey and given private key
-    ed25519_key_exchange(ss1, test_client_pub, prv);
-
-    // shared secret they calculate from our derived public key and test client private key
-    ed25519_key_exchange(ss2, pub, test_client_prv);
-
-    // check that both shared secrets match
-    if (memcmp(ss1, ss2, 32) != 0) return false;
-
-    // reject all-zero shared secret
-    for (int i = 0; i < 32; i++) {
-        if (ss1[i] != 0) return true;
-    }
-
-    return false;
-}
-
 bool LocalIdentity::readFrom(Stream& s) {
   bool success = (s.readBytes(pub_key, PUB_KEY_SIZE) == PUB_KEY_SIZE);
   success = success && (s.readBytes(prv_key, PRV_KEY_SIZE) == PRV_KEY_SIZE);

src/Identity.h

@@ -76,13 +76,6 @@ public:
   */
   void calcSharedSecret(uint8_t* secret, const uint8_t* other_pub_key) const;
 
-  /**
-   * \brief  Validates that a given private key can be used for ECDH / shared-secret operations.
-   * \param  prv IN - the private key to validate (must be PRV_KEY_SIZE bytes)
-   * \returns true, if the private key is valid for login.
-  */
-  static bool validatePrivateKey(const uint8_t prv[64]);
-
   bool readFrom(Stream& s);
   bool writeTo(Stream& s) const;
   void printTo(Stream& s) const;

src/MeshCore.h

@@ -56,14 +56,6 @@ public:
   virtual void setGpio(uint32_t values) {}
   virtual uint8_t getStartupReason() const = 0;
   virtual bool startOTAUpdate(const char* id, char reply[]) { return false; }   // not supported
-
-  // Power management interface (boards with power management override these)
-  virtual bool isExternalPowered() { return false; }
-  virtual uint16_t getBootVoltage() { return 0; }
-  virtual uint32_t getResetReason() const { return 0; }
-  virtual const char* getResetReasonString(uint32_t reason) { return "Not available"; }
-  virtual uint8_t getShutdownReason() const { return 0; }
-  virtual const char* getShutdownReasonString(uint8_t reason) { return "Not available"; }
 };
 
 /**

src/helpers/BaseChatMesh.cpp

@@ -55,54 +55,6 @@ void BaseChatMesh::sendAckTo(const ContactInfo& dest, uint32_t ack_hash) {
   }
 }
 
-void BaseChatMesh::bootstrapRTCfromContacts() {
-  uint32_t latest = 0;
-  for (int i = 0; i < num_contacts; i++) {
-    if (contacts[i].lastmod > latest) {
-      latest = contacts[i].lastmod;
-    }
-  }
-  if (latest != 0) {
-    getRTCClock()->setCurrentTime(latest + 1);
-  }
-}
-
-ContactInfo* BaseChatMesh::allocateContactSlot() {
-  if (num_contacts < MAX_CONTACTS) {
-    return &contacts[num_contacts++];
-  } else if (shouldOverwriteWhenFull()) {
-    // Find oldest non-favourite contact by oldest lastmod timestamp
-    int oldest_idx = -1;
-    uint32_t oldest_lastmod = 0xFFFFFFFF;
-    for (int i = 0; i < num_contacts; i++) {
-      bool is_favourite = (contacts[i].flags & 0x01) != 0;
-      if (!is_favourite && contacts[i].lastmod < oldest_lastmod) {
-        oldest_lastmod = contacts[i].lastmod;
-        oldest_idx = i;
-      }
-    }
-    if (oldest_idx >= 0) {
-      onContactOverwrite(contacts[oldest_idx].id.pub_key);
-      return &contacts[oldest_idx];
-    }
-  }
-  return NULL; // no space, no overwrite or all contacts are all favourites
-}
-
-void BaseChatMesh::populateContactFromAdvert(ContactInfo& ci, const mesh::Identity& id, const AdvertDataParser& parser, uint32_t timestamp) {
-  memset(&ci, 0, sizeof(ci));
-  ci.id = id;
-  ci.out_path_len = -1;  // initially out_path is unknown
-  StrHelper::strncpy(ci.name, parser.getName(), sizeof(ci.name));
-  ci.type = parser.getType();
-  if (parser.hasLatLon()) {
-    ci.gps_lat = parser.getIntLat();
-    ci.gps_lon = parser.getIntLon();
-  }
-  ci.last_advert_timestamp = timestamp;
-  ci.lastmod = getRTCClock()->getCurrentTime();
-}
-
 void BaseChatMesh::onAdvertRecv(mesh::Packet* packet, const mesh::Identity& id, uint32_t timestamp, const uint8_t* app_data, size_t app_data_len) {
   AdvertDataParser parser(app_data, app_data_len);
   if (!(parser.isValid() && parser.hasName())) {
@@ -131,40 +83,52 @@ void BaseChatMesh::onAdvertRecv(mesh::Packet* packet, const mesh::Identity& id,
     plen = packet->writeTo(temp_buf);
     packet->header = save;
   }
+  putBlobByKey(id.pub_key, PUB_KEY_SIZE, temp_buf, plen);
 
-  bool is_new = false; // true = not in contacts[], false = exists in contacts[]
+  bool is_new = false;
   if (from == NULL) {
-    if (!shouldAutoAddContactType(parser.getType())) {
+    if (!isAutoAddEnabled()) {
       ContactInfo ci;
-      populateContactFromAdvert(ci, id, parser, timestamp);
+      memset(&ci, 0, sizeof(ci));
+      ci.id = id;
+      ci.out_path_len = -1;  // initially out_path is unknown
+      StrHelper::strncpy(ci.name, parser.getName(), sizeof(ci.name));
+      ci.type = parser.getType();
+      if (parser.hasLatLon()) {
+        ci.gps_lat = parser.getIntLat();
+        ci.gps_lon = parser.getIntLon();
+      }
+      ci.last_advert_timestamp = timestamp;
+      ci.lastmod = getRTCClock()->getCurrentTime();
       onDiscoveredContact(ci, true, packet->path_len, packet->path);       // let UI know
       return;
     }
 
-    from = allocateContactSlot();
-    if (from == NULL) {
-      ContactInfo ci;
-      populateContactFromAdvert(ci, id, parser, timestamp);
-      onDiscoveredContact(ci, true, packet->path_len, packet->path);
-      onContactsFull();
-      MESH_DEBUG_PRINTLN("onAdvertRecv: unable to allocate contact slot for new contact");
+    is_new = true;
+    if (num_contacts < MAX_CONTACTS) {
+      from = &contacts[num_contacts++];
+      from->id = id;
+      from->out_path_len = -1;  // initially out_path is unknown
+      from->gps_lat = 0;   // initially unknown GPS loc
+      from->gps_lon = 0;
+      from->sync_since = 0;
+
+      from->shared_secret_valid = false;  // ecdh shared_secret will be calculated later on demand  
+    } else {
+      MESH_DEBUG_PRINTLN("onAdvertRecv: contacts table is full!");
       return;
     }
-    
-    populateContactFromAdvert(*from, id, parser, timestamp);
-    from->sync_since = 0;
-    from->shared_secret_valid = false;
   }
+
   // update
-    putBlobByKey(id.pub_key, PUB_KEY_SIZE, temp_buf, plen);
-    StrHelper::strncpy(from->name, parser.getName(), sizeof(from->name));
-    from->type = parser.getType();
-    if (parser.hasLatLon()) {
-      from->gps_lat = parser.getIntLat();
-      from->gps_lon = parser.getIntLon();
-    }
-    from->last_advert_timestamp = timestamp;
-    from->lastmod = getRTCClock()->getCurrentTime();
+  StrHelper::strncpy(from->name, parser.getName(), sizeof(from->name));
+  from->type = parser.getType();
+  if (parser.hasLatLon()) {
+    from->gps_lat = parser.getIntLat();
+    from->gps_lon = parser.getIntLon();
+  }
+  from->last_advert_timestamp = timestamp;
+  from->lastmod = getRTCClock()->getCurrentTime();
 
   onDiscoveredContact(*from, is_new, packet->path_len, packet->path);       // let UI know
 }
@@ -758,9 +722,10 @@ ContactInfo* BaseChatMesh::lookupContactByPubKey(const uint8_t* pub_key, int pre
 }
 
 bool BaseChatMesh::addContact(const ContactInfo& contact) {
-  ContactInfo* dest = allocateContactSlot();
-  if (dest) {
+  if (num_contacts < MAX_CONTACTS) {
+    auto dest = &contacts[num_contacts++];
     *dest = contact;
+
     dest->shared_secret_valid = false; // mark shared_secret as needing calculation
     return true;  // success
   }

src/helpers/BaseChatMesh.h

@@ -88,17 +88,10 @@ protected:
     memset(connections, 0, sizeof(connections));
   }
 
-  void bootstrapRTCfromContacts();
   void resetContacts() { num_contacts = 0; }
-  void populateContactFromAdvert(ContactInfo& ci, const mesh::Identity& id, const AdvertDataParser& parser, uint32_t timestamp);
-  ContactInfo* allocateContactSlot(); // helper to find slot for new contact
 
   // 'UI' concepts, for sub-classes to implement
   virtual bool isAutoAddEnabled() const { return true; }
-  virtual bool shouldAutoAddContactType(uint8_t type) const { return true; }
-  virtual void onContactsFull() {};
-  virtual bool shouldOverwriteWhenFull() const { return false; }
-  virtual void onContactOverwrite(const uint8_t* pub_key) {};
   virtual void onDiscoveredContact(ContactInfo& contact, bool is_new, uint8_t path_len, const uint8_t* path) = 0;
   virtual ContactInfo* processAck(const uint8_t *data) = 0;
   virtual void onContactPathUpdated(const ContactInfo& contact) = 0;

src/helpers/ClientACL.cpp

@@ -11,8 +11,7 @@ static File openWrite(FILESYSTEM* _fs, const char* filename) {
   #endif
 }
 
-void ClientACL::load(FILESYSTEM* fs, const mesh::LocalIdentity& self_id) {
-  _fs = fs;
+void ClientACL::load(FILESYSTEM* _fs) {
   num_clients = 0;
   if (_fs->exists("/s_contacts")) {
   #if defined(RP2040_PLATFORM)
@@ -35,12 +34,11 @@ void ClientACL::load(FILESYSTEM* fs, const mesh::LocalIdentity& self_id) {
         success = success && (file.read(unused, 2) == 2);
         success = success && (file.read((uint8_t *)&c.out_path_len, 1) == 1);
         success = success && (file.read(c.out_path, 64) == 64);
-        success = success && (file.read(c.shared_secret, PUB_KEY_SIZE) == PUB_KEY_SIZE); // will be recalculated below
+        success = success && (file.read(c.shared_secret, PUB_KEY_SIZE) == PUB_KEY_SIZE);
 
         if (!success) break; // EOF
 
         c.id = mesh::Identity(pub_key);
-        self_id.calcSharedSecret(c.shared_secret, pub_key);  // recalculate shared secrets in case our private key changed
         if (num_clients < MAX_CLIENTS) {
           clients[num_clients++] = c;
         } else {
@@ -52,8 +50,7 @@ void ClientACL::load(FILESYSTEM* fs, const mesh::LocalIdentity& self_id) {
   }
 }
 
-void ClientACL::save(FILESYSTEM* fs, bool (*filter)(ClientInfo*)) {
-  _fs = fs;
+void ClientACL::save(FILESYSTEM* _fs, bool (*filter)(ClientInfo*)) {
   File file = openWrite(_fs, "/s_contacts");
   if (file) {
     uint8_t unused[2];
@@ -77,16 +74,6 @@ void ClientACL::save(FILESYSTEM* fs, bool (*filter)(ClientInfo*)) {
   }
 }
 
-bool ClientACL::clear() {
-  if (!_fs) return false; // no filesystem, nothing to clear
-  if (_fs->exists("/s_contacts")) {
-    _fs->remove("/s_contacts");
-  }
-  memset(clients, 0, sizeof(clients));
-  num_clients = 0;
-  return true;
-}
-
 ClientInfo* ClientACL::getClient(const uint8_t* pubkey, int key_len) {
   for (int i = 0; i < num_clients; i++) {
     if (memcmp(pubkey, clients[i].id.pub_key, key_len) == 0) return &clients[i];  // already known

src/helpers/ClientACL.h

@@ -36,7 +36,6 @@ struct ClientInfo {
 #endif
 
 class ClientACL {
-  FILESYSTEM* _fs;
   ClientInfo clients[MAX_CLIENTS];
   int num_clients;
 
@@ -45,9 +44,8 @@ public:
     memset(clients, 0, sizeof(clients));
     num_clients = 0;
   }
-  void load(FILESYSTEM* _fs, const mesh::LocalIdentity& self_id);
+  void load(FILESYSTEM* _fs);
   void save(FILESYSTEM* _fs, bool (*filter)(ClientInfo*)=NULL);
-  bool clear();
 
   ClientInfo* getClient(const uint8_t* pubkey, int key_len);
   ClientInfo* putClient(const mesh::Identity& id, uint8_t init_perms);

src/helpers/CommonCLI.cpp

@@ -16,7 +16,7 @@ static uint32_t _atoi(const char* sp) {
 
 static bool isValidName(const char *n) {
   while (*n) {
-    if (*n == '[' || *n == ']' || *n == '\\' || *n == ':' || *n == ',' || *n == '?' || *n == '*') return false;
+    if (*n == '[' || *n == ']' || *n == '/' || *n == '\\' || *n == ':' || *n == ',' || *n == '?' || *n == '*') return false;
     n++;
   }
   return true;
@@ -94,7 +94,7 @@ void CommonCLI::loadPrefsInt(FILESYSTEM* fs, const char* filename) {
     _prefs->bw = constrain(_prefs->bw, 7.8f, 500.0f);
     _prefs->sf = constrain(_prefs->sf, 5, 12);
     _prefs->cr = constrain(_prefs->cr, 5, 8);
-    _prefs->tx_power_dbm = constrain(_prefs->tx_power_dbm, -9, 30);
+    _prefs->tx_power_dbm = constrain(_prefs->tx_power_dbm, 1, 30);
     _prefs->multi_acks = constrain(_prefs->multi_acks, 0, 1);
     _prefs->adc_multiplier = constrain(_prefs->adc_multiplier, 0.0f, 10.0f);
 
@@ -177,8 +177,6 @@ void CommonCLI::savePrefs(FILESYSTEM* fs) {
   }
 }
 
-#define MIN_LOCAL_ADVERT_INTERVAL   60
-
 void CommonCLI::savePrefs() {
   if (_prefs->advert_interval * 2 < MIN_LOCAL_ADVERT_INTERVAL) {
     _prefs->advert_interval = 0;  // turn it off, now that device has been manually configured
@@ -202,13 +200,9 @@ uint8_t CommonCLI::buildAdvertData(uint8_t node_type, uint8_t* app_data) {
 void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, char* reply) {
     if (memcmp(command, "reboot", 6) == 0) {
       _board->reboot();  // doesn't return
-    } else if (memcmp(command, "clkreboot", 9) == 0) {
-      // Reset clock
-      getRTCClock()->setCurrentTime(1715770351);  // 15 May 2024, 8:50pm
-      _board->reboot();  // doesn't return
     } else if (memcmp(command, "advert", 6) == 0) {
-      // send flood advert
-      _callbacks->sendSelfAdvertisement(1500, true);  // longer delay, give CLI response time to be sent first
+      // Keep "advert" as flood for backward compatibility
+      _callbacks->sendSelfAdvertisement(1500);  // longer delay, give CLI response time to be sent first
       strcpy(reply, "OK - Advert sent");
     } else if (memcmp(command, "clock sync", 10) == 0) {
       uint32_t curr = getRTCClock()->getCurrentTime();
@@ -228,7 +222,7 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
       uint32_t now = getRTCClock()->getCurrentTime();
       DateTime dt = DateTime(now);
       sprintf(reply, "%02d:%02d - %d/%d/%d UTC", dt.hour(), dt.minute(), dt.day(), dt.month(), dt.year());
-    } else if (memcmp(command, "time ", 5) == 0) {  // set time (to epoch seconds)
+    } else if (memcmp(command, "time ", 5) == 0) { // set time (to epoch seconds)
       uint32_t secs = _atoi(&command[5]);
       uint32_t curr = getRTCClock()->getCurrentTime();
       if (secs > curr) {
@@ -332,7 +326,7 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
         }
         *reply = 0;  // set null terminator
       } else if (memcmp(config, "tx", 2) == 0 && (config[2] == 0 || config[2] == ' ')) {
-        sprintf(reply, "> %d", (int32_t) _prefs->tx_power_dbm);
+        sprintf(reply, "> %d", (uint32_t) _prefs->tx_power_dbm);
       } else if (memcmp(config, "freq", 4) == 0) {
         sprintf(reply, "> %s", StrHelper::ftoa(_prefs->freq));
       } else if (memcmp(config, "public.key", 10) == 0) {
@@ -377,33 +371,6 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
         }
       } else if (memcmp(config, "flood.advert.base", 17) == 0) {
           sprintf(reply, "> %s", StrHelper::ftoa(_prefs->flood_advert_base));
-      // Power management commands
-      } else if (memcmp(config, "pwrmgt.support", 14) == 0) {
-#ifdef NRF52_POWER_MANAGEMENT
-        strcpy(reply, "> supported");
-#else
-        strcpy(reply, "> unsupported");
-#endif
-      } else if (memcmp(config, "pwrmgt.source", 13) == 0) {
-#ifdef NRF52_POWER_MANAGEMENT
-        strcpy(reply, _board->isExternalPowered() ? "> external" : "> battery");
-#else
-        strcpy(reply, "ERROR: Power management not supported");
-#endif
-      } else if (memcmp(config, "pwrmgt.bootreason", 17) == 0) {
-#ifdef NRF52_POWER_MANAGEMENT
-        sprintf(reply, "> Reset: %s; Shutdown: %s",
-          _board->getResetReasonString(_board->getResetReason()),
-          _board->getShutdownReasonString(_board->getShutdownReason()));
-#else
-        strcpy(reply, "ERROR: Power management not supported");
-#endif
-      } else if (memcmp(config, "pwrmgt.bootmv", 13) == 0) {
-#ifdef NRF52_POWER_MANAGEMENT
-        sprintf(reply, "> %u mV", _board->getBootVoltage());
-#else
-        strcpy(reply, "ERROR: Power management not supported");
-#endif
       } else {
         sprintf(reply, "??: %s", config);
       }
@@ -434,8 +401,9 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
         strcpy(reply, "OK");
       } else if (memcmp(config, "flood.advert.interval ", 22) == 0) {
         int hours = _atoi(&config[22]);
-        if ((hours > 0 && hours < 3) || (hours > 168)) {
-          strcpy(reply, "Error: interval range is 3-168 hours");
+        if ((hours > 0 && hours < MIN_FLOOD_ADVERT_INTERVAL) || (hours > MAX_FLOOD_ADVERT_INTERVAL)) {
+          sprintf(reply, "Error: interval range is %d-%d hours", MIN_FLOOD_ADVERT_INTERVAL,
+                  MAX_FLOOD_ADVERT_INTERVAL);
         } else {
           _prefs->flood_advert_interval = (uint8_t)(hours);
           _callbacks->updateFloodAdvertTimer();
@@ -444,8 +412,9 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
         }
       } else if (memcmp(config, "advert.interval ", 16) == 0) {
         int mins = _atoi(&config[16]);
-        if ((mins > 0 && mins < MIN_LOCAL_ADVERT_INTERVAL) || (mins > 240)) {
-          sprintf(reply, "Error: interval range is %d-240 minutes", MIN_LOCAL_ADVERT_INTERVAL);
+        if ((mins > 0 && mins < MIN_LOCAL_ADVERT_INTERVAL) || (mins > MAX_LOCAL_ADVERT_INTERVAL)) {
+          sprintf(reply, "Error: interval range is %d-%d minutes",MIN_LOCAL_ADVERT_INTERVAL,
+                  MAX_LOCAL_ADVERT_INTERVAL);
         } else {
           _prefs->advert_interval = (uint8_t)(mins / 2);
           _callbacks->updateAdvertTimer();
@@ -456,18 +425,17 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch
         StrHelper::strncpy(_prefs->guest_password, &config[15], sizeof(_prefs->guest_password));
         savePrefs();
         strcpy(reply, "OK");
-      } else if (memcmp(config, "prv.key ", 8) == 0) {
+      } else if (sender_timestamp == 0 &&
+                 memcmp(config, "prv.key ", 8) == 0) { // from serial command line only
         uint8_t prv_key[PRV_KEY_SIZE];
         bool success = mesh::Utils::fromHex(prv_key, PRV_KEY_SIZE, &config[8]);
-        // only allow rekey if key is valid
-        if (success && mesh::LocalIdentity::validatePrivateKey(prv_key)) {
+        if (success) {
           mesh::LocalIdentity new_id;
           new_id.readFrom(prv_key, PRV_KEY_SIZE);
           _callbacks->saveIdentity(new_id);
-          strcpy(reply, "OK, reboot to apply! New pubkey: ");
-          mesh::Utils::toHex(&reply[33], new_id.pub_key, PUB_KEY_SIZE);
+          strcpy(reply, "OK");
         } else {
-          strcpy(reply, "Error, bad key");
+          strcpy(reply, "Error, invalid key");
         }
       } else if (memcmp(config, "name ", 5) == 0) {
         if (isValidName(&config[5])) {

src/helpers/CommonCLI.h

@@ -3,7 +3,6 @@
 #include "Mesh.h"
 #include <helpers/IdentityStore.h>
 #include <helpers/SensorManager.h>
-#include <helpers/ClientACL.h>
 
 #if defined(WITH_RS232_BRIDGE) || defined(WITH_ESPNOW_BRIDGE)
 #define WITH_BRIDGE
@@ -19,7 +18,7 @@ struct NodePrefs { // persisted to file
   double node_lat, node_lon;
   char password[16];
   float freq;
-  int8_t tx_power_dbm;
+  uint8_t tx_power_dbm;
   uint8_t disable_fwd;
   uint8_t advert_interval;       // minutes / 2
   uint8_t flood_advert_interval; // hours
@@ -62,13 +61,13 @@ public:
   virtual const char* getBuildDate() = 0;
   virtual const char* getRole() = 0;
   virtual bool formatFileSystem() = 0;
-  virtual void sendSelfAdvertisement(int delay_millis, bool flood) = 0;
+  virtual void sendSelfAdvertisement(int delay_millis, bool flood = true) = 0;
   virtual void updateAdvertTimer() = 0;
   virtual void updateFloodAdvertTimer() = 0;
   virtual void setLoggingOn(bool enable) = 0;
   virtual void eraseLogFile() = 0;
   virtual void dumpLogFile() = 0;
-  virtual void setTxPower(int8_t power_dbm) = 0;
+  virtual void setTxPower(uint8_t power_dbm) = 0;
   virtual void formatNeighborsReply(char *reply) = 0;
   virtual void removeNeighbor(const uint8_t* pubkey, int key_len) {
     // no op by default
@@ -96,7 +95,6 @@ class CommonCLI {
   CommonCLICallbacks* _callbacks;
   mesh::MainBoard* _board;
   SensorManager* _sensors;
-  ClientACL* _acl;
   char tmp[PRV_KEY_SIZE*2 + 4];
 
   mesh::RTCClock* getRTCClock() { return _rtc; }
@@ -104,8 +102,8 @@ class CommonCLI {
   void loadPrefsInt(FILESYSTEM* _fs, const char* filename);
 
 public:
-  CommonCLI(mesh::MainBoard& board, mesh::RTCClock& rtc, SensorManager& sensors, ClientACL& acl, NodePrefs* prefs, CommonCLICallbacks* callbacks)
-      : _board(&board), _rtc(&rtc), _sensors(&sensors), _acl(&acl), _prefs(prefs), _callbacks(callbacks) { }
+  CommonCLI(mesh::MainBoard& board, mesh::RTCClock& rtc, SensorManager& sensors, NodePrefs* prefs, CommonCLICallbacks* callbacks)
+      : _board(&board), _rtc(&rtc), _sensors(&sensors), _prefs(prefs), _callbacks(callbacks) { }
 
   void loadPrefs(FILESYSTEM* _fs);
   void savePrefs(FILESYSTEM* _fs);

src/helpers/ESP32Board.cpp

@@ -11,7 +11,6 @@
 #include <SPIFFS.h>
 
 bool ESP32Board::startOTAUpdate(const char* id, char reply[]) {
-  inhibit_sleep = true;   // prevent sleep during OTA
   WiFi.softAP("MeshCore-OTA", NULL);
 
   sprintf(reply, "Started: http://%s/update", WiFi.softAPIP().toString().c_str());

src/helpers/ESP32Board.h

@@ -8,12 +8,12 @@
 #include <rom/rtc.h>
 #include <sys/time.h>
 #include <Wire.h>
+#include "esp_wifi.h"
 #include "driver/rtc_io.h"
 
 class ESP32Board : public mesh::MainBoard {
 protected:
   uint8_t startup_reason;
-  bool inhibit_sleep = false;
 
 public:
   void begin() {
@@ -72,7 +72,11 @@ public:
   }
 
   void sleep(uint32_t secs) override {
-    if (!inhibit_sleep) {
+    // To check for WiFi status to see if there is active OTA
+    wifi_mode_t mode;
+    esp_err_t err = esp_wifi_get_mode(&mode);
+    
+    if (err != ESP_OK) {          // WiFi is off ~ No active OTA, safe to go to sleep
       enterLightSleep(secs);      // To wake up after "secs" seconds or when receiving a LoRa packet
     }
   }
@@ -122,10 +126,6 @@ public:
   }
 
   bool startOTAUpdate(const char* id, char reply[]) override;
-
-  void setInhibitSleep(bool inhibit) {
-    inhibit_sleep = inhibit;
-  }
 };
 
 class ESP32RTCClock : public mesh::RTCClock {

src/helpers/NRF52Board.cpp

@@ -2,7 +2,6 @@
 #include "NRF52Board.h"
 
 #include <bluefruit.h>
-#include <nrf_soc.h>
 
 static BLEDfu bledfu;
 
@@ -22,222 +21,6 @@ void NRF52Board::begin() {
   startup_reason = BD_STARTUP_NORMAL;
 }
 
-#ifdef NRF52_POWER_MANAGEMENT
-#include "nrf.h"
-
-// Power Management global variables
-uint32_t g_nrf52_reset_reason = 0;     // Reset/Startup reason
-uint8_t g_nrf52_shutdown_reason = 0;   // Shutdown reason
-
-// Early constructor - runs before SystemInit() clears the registers
-// Priority 101 ensures this runs before SystemInit (102) and before
-// any C++ static constructors (default 65535)
-static void __attribute__((constructor(101))) nrf52_early_reset_capture() {
-  g_nrf52_reset_reason = NRF_POWER->RESETREAS;
-  g_nrf52_shutdown_reason = NRF_POWER->GPREGRET2;
-}
-
-void NRF52Board::initPowerMgr() {
-  // Copy early-captured register values
-  reset_reason = g_nrf52_reset_reason;
-  shutdown_reason = g_nrf52_shutdown_reason;
-  boot_voltage_mv = 0;  // Will be set by checkBootVoltage()
-
-  // Clear registers for next boot
-  // Note: At this point SoftDevice may or may not be enabled
-  uint8_t sd_enabled = 0;
-  sd_softdevice_is_enabled(&sd_enabled);
-  if (sd_enabled) {
-    sd_power_reset_reason_clr(0xFFFFFFFF);
-    sd_power_gpregret_clr(1, 0xFF);
-  } else {
-    NRF_POWER->RESETREAS = 0xFFFFFFFF;  // Write 1s to clear
-    NRF_POWER->GPREGRET2 = 0;
-  }
-
-  // Log reset/shutdown info
-  if (shutdown_reason != SHUTDOWN_REASON_NONE) {
-    MESH_DEBUG_PRINTLN("PWRMGT: Reset = %s (0x%lX); Shutdown = %s (0x%02X)",
-      getResetReasonString(reset_reason), (unsigned long)reset_reason,
-      getShutdownReasonString(shutdown_reason), shutdown_reason);
-  } else {
-    MESH_DEBUG_PRINTLN("PWRMGT: Reset = %s (0x%lX)",
-      getResetReasonString(reset_reason), (unsigned long)reset_reason);
-  }
-}
-
-bool NRF52Board::isExternalPowered() {
-  // Check if SoftDevice is enabled before using its API
-  uint8_t sd_enabled = 0;
-  sd_softdevice_is_enabled(&sd_enabled);
-
-  if (sd_enabled) {
-    uint32_t usb_status;
-    sd_power_usbregstatus_get(&usb_status);
-    return (usb_status & POWER_USBREGSTATUS_VBUSDETECT_Msk) != 0;
-  } else {
-    return (NRF_POWER->USBREGSTATUS & POWER_USBREGSTATUS_VBUSDETECT_Msk) != 0;
-  }
-}
-
-const char* NRF52Board::getResetReasonString(uint32_t reason) {
-  if (reason & POWER_RESETREAS_RESETPIN_Msk) return "Reset Pin";
-  if (reason & POWER_RESETREAS_DOG_Msk) return "Watchdog";
-  if (reason & POWER_RESETREAS_SREQ_Msk) return "Soft Reset";
-  if (reason & POWER_RESETREAS_LOCKUP_Msk) return "CPU Lockup";
-  #ifdef POWER_RESETREAS_LPCOMP_Msk
-    if (reason & POWER_RESETREAS_LPCOMP_Msk) return "Wake from LPCOMP";
-  #endif
-  #ifdef POWER_RESETREAS_VBUS_Msk
-    if (reason & POWER_RESETREAS_VBUS_Msk) return "Wake from VBUS";
-  #endif
-  #ifdef POWER_RESETREAS_OFF_Msk
-    if (reason & POWER_RESETREAS_OFF_Msk) return "Wake from GPIO";
-  #endif
-  #ifdef POWER_RESETREAS_DIF_Msk
-    if (reason & POWER_RESETREAS_DIF_Msk) return "Debug Interface";
-  #endif
-  return "Cold Boot";
-}
-
-const char* NRF52Board::getShutdownReasonString(uint8_t reason) {
-  switch (reason) {
-    case SHUTDOWN_REASON_LOW_VOLTAGE:  return "Low Voltage";
-    case SHUTDOWN_REASON_USER:         return "User Request";
-    case SHUTDOWN_REASON_BOOT_PROTECT: return "Boot Protection";
-  }
-  return "Unknown";
-}
-
-bool NRF52Board::checkBootVoltage(const PowerMgtConfig* config) {
-  initPowerMgr();
-
-  // Read boot voltage
-  boot_voltage_mv = getBattMilliVolts();
-  
-  if (config->voltage_bootlock == 0) return true;  // Protection disabled
-
-  // Skip check if externally powered
-  if (isExternalPowered()) {
-    MESH_DEBUG_PRINTLN("PWRMGT: Boot check skipped (external power)");
-    boot_voltage_mv = getBattMilliVolts();
-    return true;
-  }
-
-  MESH_DEBUG_PRINTLN("PWRMGT: Boot voltage = %u mV (threshold = %u mV)",
-      boot_voltage_mv, config->voltage_bootlock);
-
-  // Only trigger shutdown if reading is valid (>1000mV) AND below threshold
-  // This prevents spurious shutdowns on ADC glitches or uninitialized reads
-  if (boot_voltage_mv > 1000 && boot_voltage_mv < config->voltage_bootlock) {
-    MESH_DEBUG_PRINTLN("PWRMGT: Boot voltage too low - entering protective shutdown");
-
-    initiateShutdown(SHUTDOWN_REASON_BOOT_PROTECT);
-    return false;  // Should never reach this
-  }
-
-  return true;
-}
-
-void NRF52Board::initiateShutdown(uint8_t reason) {
-  enterSystemOff(reason);
-}
-
-void NRF52Board::enterSystemOff(uint8_t reason) {
-  MESH_DEBUG_PRINTLN("PWRMGT: Entering SYSTEMOFF (%s)", getShutdownReasonString(reason));
-
-  // Record shutdown reason in GPREGRET2
-  uint8_t sd_enabled = 0;
-  sd_softdevice_is_enabled(&sd_enabled);
-  if (sd_enabled) {
-    sd_power_gpregret_clr(1, 0xFF);
-    sd_power_gpregret_set(1, reason);
-  } else {
-    NRF_POWER->GPREGRET2 = reason;
-  }
-
-  // Flush serial buffers
-  Serial.flush();
-  delay(100);
-
-  // Enter SYSTEMOFF
-  if (sd_enabled) {
-    uint32_t err = sd_power_system_off();
-    if (err == NRF_ERROR_SOFTDEVICE_NOT_ENABLED) {  //SoftDevice not enabled
-      sd_enabled = 0;
-    }
-  }
-
-  if (!sd_enabled) {
-    // SoftDevice not available; write directly to POWER->SYSTEMOFF
-    NRF_POWER->SYSTEMOFF = POWER_SYSTEMOFF_SYSTEMOFF_Enter;
-  }
-
-  // If we get here, something went wrong. Reset to recover.
-  NVIC_SystemReset();
-}
-
-void NRF52Board::configureVoltageWake(uint8_t ain_channel, uint8_t refsel) {
-  // LPCOMP is not managed by SoftDevice - direct register access required
-  // Halt and disable before reconfiguration
-  NRF_LPCOMP->TASKS_STOP = 1;
-  NRF_LPCOMP->ENABLE = LPCOMP_ENABLE_ENABLE_Disabled;
-
-  // Select analog input (AIN0-7 maps to PSEL 0-7)
-  NRF_LPCOMP->PSEL = ((uint32_t)ain_channel << LPCOMP_PSEL_PSEL_Pos) & LPCOMP_PSEL_PSEL_Msk;
-
-  // Reference: REFSEL (0-6=1/8..7/8, 7=ARef, 8-15=1/16..15/16)
-  NRF_LPCOMP->REFSEL = ((uint32_t)refsel << LPCOMP_REFSEL_REFSEL_Pos) & LPCOMP_REFSEL_REFSEL_Msk;
-
-  // Detect UP events (voltage rises above threshold for battery recovery)
-  NRF_LPCOMP->ANADETECT = LPCOMP_ANADETECT_ANADETECT_Up;
-
-  // Enable 50mV hysteresis for noise immunity
-  NRF_LPCOMP->HYST = LPCOMP_HYST_HYST_Hyst50mV;
-
-  // Clear stale events/interrupts before enabling wake
-  NRF_LPCOMP->EVENTS_READY = 0;
-  NRF_LPCOMP->EVENTS_DOWN = 0;
-  NRF_LPCOMP->EVENTS_UP = 0;
-  NRF_LPCOMP->EVENTS_CROSS = 0;
-
-  NRF_LPCOMP->INTENCLR = 0xFFFFFFFF;
-  NRF_LPCOMP->INTENSET = LPCOMP_INTENSET_UP_Msk;
-
-  // Enable LPCOMP
-  NRF_LPCOMP->ENABLE = LPCOMP_ENABLE_ENABLE_Enabled;
-  NRF_LPCOMP->TASKS_START = 1;
-
-  // Wait for comparator to settle before entering SYSTEMOFF
-  for (uint8_t i = 0; i < 20 && !NRF_LPCOMP->EVENTS_READY; i++) {
-    delayMicroseconds(50);
-  }
-
-  if (refsel == 7) {
-    MESH_DEBUG_PRINTLN("PWRMGT: LPCOMP wake configured (AIN%d, ref=ARef)", ain_channel);
-  } else if (refsel <= 6) {
-    MESH_DEBUG_PRINTLN("PWRMGT: LPCOMP wake configured (AIN%d, ref=%d/8 VDD)",
-      ain_channel, refsel + 1);
-  } else {
-    uint8_t ref_num = (uint8_t)((refsel - 8) * 2 + 1);
-    MESH_DEBUG_PRINTLN("PWRMGT: LPCOMP wake configured (AIN%d, ref=%d/16 VDD)",
-      ain_channel, ref_num);
-  }
-
-  // Configure VBUS (USB power) wake alongside LPCOMP
-  uint8_t sd_enabled = 0;
-  sd_softdevice_is_enabled(&sd_enabled);
-  if (sd_enabled) {
-    sd_power_usbdetected_enable(1);
-  } else {
-    NRF_POWER->EVENTS_USBDETECTED = 0;
-    NRF_POWER->INTENSET = POWER_INTENSET_USBDETECTED_Msk;
-  }
-
-  MESH_DEBUG_PRINTLN("PWRMGT: VBUS wake configured");
-}
-#endif
-
 void NRF52BoardDCDC::begin() {
   NRF52Board::begin();
 
@@ -251,32 +34,6 @@ void NRF52BoardDCDC::begin() {
   }
 }
 
-void NRF52Board::sleep(uint32_t secs) {
-  // Clear FPU interrupt flags to avoid insomnia
-  // see errata 87 for details https://docs.nordicsemi.com/bundle/errata_nRF52840_Rev3/page/ERR/nRF52840/Rev3/latest/anomaly_840_87.html
-  #if (__FPU_USED == 1)
-  __set_FPSCR(__get_FPSCR() & ~(0x0000009F)); 
-  (void) __get_FPSCR();
-  NVIC_ClearPendingIRQ(FPU_IRQn);
-  #endif
-
-  // On nRF52, we use event-driven sleep instead of timed sleep
-  // The 'secs' parameter is ignored - we wake on any interrupt
-  uint8_t sd_enabled = 0;
-  sd_softdevice_is_enabled(&sd_enabled);
-
-  if (sd_enabled) {
-    // first call processes pending softdevice events, second call sleeps.
-    sd_app_evt_wait();
-    sd_app_evt_wait();
-  } else {
-    // softdevice is disabled, use raw WFE
-    __SEV();
-    __WFE();
-    __WFE();
-  }
-}
-
 // Temperature from NRF52 MCU
 float NRF52Board::getMCUTemperature() {
   NRF_TEMP->TASKS_START = 1; // Start temperature measurement
@@ -297,7 +54,7 @@ float NRF52Board::getMCUTemperature() {
   return temp * 0.25f; // Convert to *C
 }
 
-bool NRF52Board::startOTAUpdate(const char *id, char reply[]) {
+bool NRF52BoardOTA::startOTAUpdate(const char *id, char reply[]) {
   // Config the peripheral connection with maximum bandwidth
   // more SRAM required by SoftDevice
   // Note: All config***() function must be called before begin()

src/helpers/NRF52Board.h

@@ -5,62 +5,15 @@
 
 #if defined(NRF52_PLATFORM)
 
-#ifdef NRF52_POWER_MANAGEMENT
-// Shutdown Reason Codes (stored in GPREGRET before SYSTEMOFF)
-#define SHUTDOWN_REASON_NONE          0x00
-#define SHUTDOWN_REASON_LOW_VOLTAGE   0x4C  // 'L' - Runtime low voltage threshold
-#define SHUTDOWN_REASON_USER          0x55  // 'U' - User requested powerOff()
-#define SHUTDOWN_REASON_BOOT_PROTECT  0x42  // 'B' - Boot voltage protection
-
-// Boards provide this struct with their hardware-specific settings and callbacks.
-struct PowerMgtConfig {
-  // LPCOMP wake configuration (for voltage recovery from SYSTEMOFF)
-  uint8_t lpcomp_ain_channel;       // AIN0-7 for voltage sensing pin
-  uint8_t lpcomp_refsel;            // REFSEL value: 0-6=1/8..7/8, 7=ARef, 8-15=1/16..15/16
-
-  // Boot protection voltage threshold (millivolts)
-  // Set to 0 to disable boot protection
-  uint16_t voltage_bootlock;
-};
-#endif
-
 class NRF52Board : public mesh::MainBoard {
-#ifdef NRF52_POWER_MANAGEMENT
-  void initPowerMgr();
-#endif
-
 protected:
   uint8_t startup_reason;
-  char *ota_name;
-
-#ifdef NRF52_POWER_MANAGEMENT
-  uint32_t reset_reason;              // RESETREAS register value
-  uint8_t shutdown_reason;            // GPREGRET value (why we entered last SYSTEMOFF)
-  uint16_t boot_voltage_mv;           // Battery voltage at boot (millivolts)
-
-  bool checkBootVoltage(const PowerMgtConfig* config);
-  void enterSystemOff(uint8_t reason);
-  void configureVoltageWake(uint8_t ain_channel, uint8_t refsel);
-  virtual void initiateShutdown(uint8_t reason);
-#endif
 
 public:
-  NRF52Board(char *otaname) : ota_name(otaname) {}
   virtual void begin();
   virtual uint8_t getStartupReason() const override { return startup_reason; }
   virtual float getMCUTemperature() override;
   virtual void reboot() override { NVIC_SystemReset(); }
-  virtual bool startOTAUpdate(const char *id, char reply[]) override;
-  virtual void sleep(uint32_t secs) override;
-
-#ifdef NRF52_POWER_MANAGEMENT
-  bool isExternalPowered() override;
-  uint16_t getBootVoltage() override { return boot_voltage_mv; }
-  virtual uint32_t getResetReason() const override { return reset_reason; }
-  uint8_t getShutdownReason() const override { return shutdown_reason; }
-  const char* getResetReasonString(uint32_t reason) override;
-  const char* getShutdownReasonString(uint8_t reason) override;
-#endif
 };
 
 /*
@@ -72,7 +25,15 @@ public:
  */
 class NRF52BoardDCDC : virtual public NRF52Board {
 public:
-  NRF52BoardDCDC() {}
   virtual void begin() override;
 };
+
+class NRF52BoardOTA : virtual public NRF52Board {
+private:
+  char *ota_name;
+
+public:
+  NRF52BoardOTA(char *name) : ota_name(name) {}
+  virtual bool startOTAUpdate(const char *id, char reply[]) override;
+};
 #endif

src/helpers/RegionMap.cpp

@@ -2,45 +2,6 @@
 #include <helpers/TxtDataHelpers.h>
 #include <SHA256.h>
 
-// helper class for region map exporter, we emulate Stream with a safe buffer writer.
-
-class BufStream : public Stream {
-public:
-  BufStream(char *buf, size_t max_len)
-    : _buf(buf), _max_len(max_len), _pos(0) {
-    if (_max_len > 0) _buf[0] = 0;
-  }
-
-  size_t write(uint8_t c) override {
-    if (_pos + 1 >= _max_len) return 0;
-    _buf[_pos++] = c;
-    _buf[_pos] = 0;
-    return 1;
-  }
-
-  size_t write(const uint8_t *buffer, size_t size) override {
-    size_t written = 0;
-    while (written < size) {
-      if (!write(buffer[written])) break;
-      written++;
-    }
-    return written;
-  }
-
-  int available() override { return 0; }
-  int read() override { return -1; }
-  int peek() override { return -1; }
-  void flush() override {}
-
-  size_t length() const { return _pos; }
-
-private:
-  char *_buf;
-  size_t _max_len;
-  size_t _pos;
-};
-
-
 RegionMap::RegionMap(TransportKeyStore& store) : _store(&store) {
   next_id = 1; num_regions = 0; home_id = 0;
   wildcard.id = wildcard.parent = 0;
@@ -50,11 +11,7 @@ RegionMap::RegionMap(TransportKeyStore& store) : _store(&store) {
 
 bool RegionMap::is_name_char(uint8_t c) {
   // accept all alpha-num or accented characters, but exclude most punctuation chars
-  return c == '-' || c == '$' || c == '#' || (c >= '0' && c <= '9') || c >= 'A';
-}
-
-static const char* skip_hash(const char* name) {
-  return *name == '#' ? name + 1 : name;
+  return c == '-' || c == '#' || (c >= '0' && c <= '9') || c >= 'A';
 }
 
 static File openWrite(FILESYSTEM* _fs, const char* filename) {
@@ -170,17 +127,11 @@ RegionEntry* RegionMap::findMatch(mesh::Packet* packet, uint8_t mask) {
     if ((region->flags & mask) == 0) {   // does region allow this? (per 'mask' param)
       TransportKey keys[4];
       int num;
-      if (region->name[0] == '$') {   // private region
-        num = _store->loadKeysFor(region->id, keys, 4);
-      } else if (region->name[0] == '#') {   // auto hashtag region
+      if (region->name[0] == '#') {   // auto hashtag region
         _store->getAutoKeyFor(region->id, region->name, keys[0]);
         num = 1;
-      } else {   // new: implicit auto hashtag region
-        char tmp[sizeof(region->name)];
-        tmp[0] = '#';
-        strcpy(&tmp[1], region->name);
-        _store->getAutoKeyFor(region->id, tmp, keys[0]);
-        num = 1;
+      } else {
+        num = _store->loadKeysFor(region->id, keys, 4);
       }
       for (int j = 0; j < num; j++) {
         uint16_t code = keys[j].calcTransportCode(packet);
@@ -196,10 +147,9 @@ RegionEntry* RegionMap::findMatch(mesh::Packet* packet, uint8_t mask) {
 RegionEntry* RegionMap::findByName(const char* name) {
   if (strcmp(name, "*") == 0) return &wildcard;
 
-  if (*name == '#') { name++; }  // ignore the '#' when matching by name
   for (int i = 0; i < num_regions; i++) {
     auto region = &regions[i];
-    if (strcmp(name, skip_hash(region->name)) == 0) return region;
+    if (strcmp(name, region->name) == 0) return region;
   }
   return NULL;  // not found
 }
@@ -207,12 +157,11 @@ RegionEntry* RegionMap::findByName(const char* name) {
 RegionEntry* RegionMap::findByNamePrefix(const char* prefix) {
   if (strcmp(prefix, "*") == 0) return &wildcard;
 
-  if (*prefix == '#') { prefix++; }  // ignore the '#' when matching by name
   RegionEntry* partial = NULL;
   for (int i = 0; i < num_regions; i++) {
     auto region = &regions[i];
-    if (strcmp(prefix, skip_hash(region->name)) == 0) return region;  // is a complete match, preference this one
-    if (memcmp(prefix, skip_hash(region->name), strlen(prefix)) == 0) {
+    if (strcmp(prefix, region->name) == 0) return region;  // is a complete match, preference this one
+    if (memcmp(prefix, region->name, strlen(prefix)) == 0) {
       partial = region;
     }
   }
@@ -271,9 +220,9 @@ void RegionMap::printChildRegions(int indent, const RegionEntry* parent, Stream&
   }
 
   if (parent->flags & REGION_DENY_FLOOD) {
-    out.printf("%s%s\n", skip_hash(parent->name), parent->id == home_id ? "^" : "");
+    out.printf("%s%s\n", parent->name, parent->id == home_id ? "^" : "");
   } else {
-    out.printf("%s%s F\n", skip_hash(parent->name), parent->id == home_id ? "^" : "");
+    out.printf("%s%s F\n", parent->name, parent->id == home_id ? "^" : "");
   }
 
   for (int i = 0; i < num_regions; i++) {
@@ -288,40 +237,24 @@ void RegionMap::exportTo(Stream& out) const {
   printChildRegions(0, &wildcard, out);   // recursive
 }
 
-size_t RegionMap::exportTo(char *dest, size_t max_len) const {
-  if (!dest || max_len == 0) return 0;
-
-  BufStream bs(dest, max_len);
-  exportTo(bs);              // ← reuse existing logic
-  return bs.length();
-}
-
-int RegionMap::exportNamesTo(char *dest, int max_len, uint8_t mask, bool invert) {
+int RegionMap::exportNamesTo(char *dest, int max_len, uint8_t mask) {
   char *dp = dest;
-  
-  // Check wildcard region
-  bool wildcard_matches = invert ? (wildcard.flags & mask) : !(wildcard.flags & mask);
-  if (wildcard_matches) {
+  if ((wildcard.flags & mask) == 0) {
     *dp++ = '*';
     *dp++ = ',';
   }
 
-    for (int i = 0; i < num_regions; i++) {
+  for (int i = 0; i < num_regions; i++) {
     auto region = &regions[i];
-    
-    // Check if region matches the filter criteria
-    bool region_matches = invert ? (region->flags & mask) : !(region->flags & mask);
-    
-    if (region_matches) {
-      int len = strlen(skip_hash(region->name));
+    if ((region->flags & mask) == 0) {   // region allowed? (per 'mask' param)
+      int len = strlen(region->name);
       if ((dp - dest) + len + 2 < max_len) {   // only append if name will fit
-        memcpy(dp, skip_hash(region->name), len);
+        memcpy(dp, region->name, len);
         dp += len;
         *dp++ = ',';
       }
     }
   }
-
   if (dp > dest) { dp--; }   // don't include trailing comma
 
   *dp = 0;  // set null terminator

src/helpers/RegionMap.h

@@ -49,9 +49,7 @@ public:
   int getCount() const { return num_regions; }
   const RegionEntry* getByIdx(int i) const { return &regions[i]; }
   const RegionEntry* getRoot() const { return &wildcard; }
-  int exportNamesTo(char *dest, int max_len, uint8_t mask, bool invert = false);
+  int exportNamesTo(char *dest, int max_len, uint8_t mask);
 
-  void    exportTo(Stream& out) const;
-  size_t  exportTo(char *dest, size_t max_len) const;
- 
+  void exportTo(Stream& out) const;
 };

src/helpers/StatsFormatHelper.h

@@ -42,14 +42,13 @@ public:
                                uint32_t n_recv_flood,
                                uint32_t n_recv_direct) {
     sprintf(reply, 
-      "{\"recv\":%u,\"sent\":%u,\"flood_tx\":%u,\"direct_tx\":%u,\"flood_rx\":%u,\"direct_rx\":%u,\"recv_errors\":%u}",
+      "{\"recv\":%u,\"sent\":%u,\"flood_tx\":%u,\"direct_tx\":%u,\"flood_rx\":%u,\"direct_rx\":%u}",
       driver.getPacketsRecv(),
       driver.getPacketsSent(),
       n_sent_flood,
       n_sent_direct,
       n_recv_flood,
-      n_recv_direct,
-      driver.getPacketsRecvErrors()
+      n_recv_direct
     );
   }
 };

src/helpers/esp32/SerialBLEInterface.cpp

@@ -9,21 +9,11 @@
 
 #define ADVERT_RESTART_DELAY  1000   // millis
 
-void SerialBLEInterface::begin(const char* prefix, char* name, uint32_t pin_code) {
+void SerialBLEInterface::begin(const char* device_name, uint32_t pin_code) {
   _pin_code = pin_code;
 
-  if (strcmp(name, "@@MAC") == 0) {
-    uint8_t addr[8];
-    memset(addr, 0, sizeof(addr));
-    esp_efuse_mac_get_default(addr);
-    sprintf(name, "%02X%02X%02X%02X%02X%02X",    // modify (IN-OUT param)
-          addr[5], addr[4], addr[3], addr[2], addr[1], addr[0]);
-  }
-  char dev_name[32+16];
-  sprintf(dev_name, "%s%s", prefix, name);
-
   // Create the BLE Device
-  BLEDevice::init(dev_name);
+  BLEDevice::init(device_name);
   BLEDevice::setSecurityCallbacks(this);
   BLEDevice::setMTU(MAX_FRAME_SIZE);
 

src/helpers/esp32/SerialBLEInterface.h

@@ -61,13 +61,7 @@ public:
     send_queue_len = recv_queue_len = 0;
   }
 
-  /**
-   * init the BLE interface.
-   * @param prefix   a prefix for the device name
-   * @param name  IN/OUT - a name for the device (combined with prefix). If "@@MAC", is modified and returned
-   * @param pin_code   the BLE security pin
-   */
-  void begin(const char* prefix, char* name, uint32_t pin_code);
+  void begin(const char* device_name, uint32_t pin_code);
 
   // BaseSerialInterface methods
   void enable() override;

src/helpers/nrf52/SerialBLEInterface.cpp

@@ -123,7 +123,7 @@ void SerialBLEInterface::onBLEEvent(ble_evt_t* evt) {
   }
 }
 
-void SerialBLEInterface::begin(const char* prefix, char* name, uint32_t pin_code) {
+void SerialBLEInterface::begin(const char* device_name, uint32_t pin_code) {
   instance = this;
 
   char charpin[20];
@@ -133,17 +133,7 @@ void SerialBLEInterface::begin(const char* prefix, char* name, uint32_t pin_code
   // Bluefruit.autoConnLed(false);
   Bluefruit.configPrphBandwidth(BANDWIDTH_MAX);
   Bluefruit.begin();
- 
-  char dev_name[32+16];
-  if (strcmp(name, "@@MAC") == 0) {
-    ble_gap_addr_t addr;
-    if (sd_ble_gap_addr_get(&addr) == NRF_SUCCESS) {
-      sprintf(name, "%02X%02X%02X%02X%02X%02X",    // modify (IN-OUT param)
-          addr.addr[5], addr.addr[4], addr.addr[3], addr.addr[2], addr.addr[1], addr.addr[0]);
-    }
-  }
-  sprintf(dev_name, "%s%s", prefix, name);
-
+  
   // Connection interval units: 1.25ms, supervision timeout units: 10ms
   ble_gap_conn_params_t ppcp_params;
   ppcp_params.min_conn_interval = BLE_MIN_CONN_INTERVAL;
@@ -163,7 +153,7 @@ void SerialBLEInterface::begin(const char* prefix, char* name, uint32_t pin_code
   }
   
   Bluefruit.setTxPower(BLE_TX_POWER);
-  Bluefruit.setName(dev_name);
+  Bluefruit.setName(device_name);
 
   Bluefruit.Security.setMITM(true);
   Bluefruit.Security.setPIN(charpin);

src/helpers/nrf52/SerialBLEInterface.h

@@ -52,14 +52,7 @@ public:
     recv_queue_len = 0;
   }
 
-  /**
-   * init the BLE interface.
-   * @param prefix   a prefix for the device name
-   * @param name  IN/OUT - a name for the device (combined with prefix). If "@@MAC", is modified and returned
-   * @param pin_code   the BLE security pin
-   */
-  void begin(const char* prefix, char* name, uint32_t pin_code);
-
+  void begin(const char* device_name, uint32_t pin_code);
   void disconnect();
   void enable() override;
   void disable() override;

src/helpers/radiolib/CustomSX1262.h

@@ -76,14 +76,6 @@ class CustomSX1262 : public SX1262 {
       setRfSwitchPins(SX126X_RXEN, SX126X_TXEN);
   #endif 
 
-  // for improved RX with Heltec v4
-  #ifdef SX126X_REGISTER_PATCH
-    uint8_t r_data = 0;
-    readRegister(0x8B5, &r_data, 1);
-    r_data |= 0x01;
-    writeRegister(0x8B5, &r_data, 1);
-  #endif
-
       return true;  // success
     }
 

src/helpers/radiolib/RadioLibWrappers.cpp

@@ -105,7 +105,6 @@ int RadioLibWrapper::recvRaw(uint8_t* bytes, int sz) {
       if (err != RADIOLIB_ERR_NONE) {
         MESH_DEBUG_PRINTLN("RadioLibWrapper: error: readData(%d)", err);
         len = 0;
-        n_recv_errors++;
       } else {
       //  Serial.print("  readData() -> "); Serial.println(len);
         n_recv++;

src/helpers/radiolib/RadioLibWrappers.h

@@ -7,7 +7,7 @@ class RadioLibWrapper : public mesh::Radio {
 protected:
   PhysicalLayer* _radio;
   mesh::MainBoard* _board;
-  uint32_t n_recv, n_sent, n_recv_errors;
+  uint32_t n_recv, n_sent;
   int16_t _noise_floor, _threshold;
   uint16_t _num_floor_samples;
   int32_t _floor_sample_sum;
@@ -45,9 +45,8 @@ public:
   void loop() override;
 
   uint32_t getPacketsRecv() const { return n_recv; }
-  uint32_t getPacketsRecvErrors() const { return n_recv_errors; }
   uint32_t getPacketsSent() const { return n_sent; }
-  void resetStats() { n_recv = n_sent = n_recv_errors = 0; }
+  void resetStats() { n_recv = n_sent = 0; }
 
   virtual float getLastRSSI() const override;
   virtual float getLastSNR() const override;

src/helpers/sensors/EnvironmentSensorManager.cpp

@@ -42,7 +42,7 @@ static Adafruit_BME280 BME280;
 #endif
 #define TELEM_BMP280_SEALEVELPRESSURE_HPA (1013.25)    // Athmospheric pressure at sea level
 #include <Adafruit_BMP280.h>
-static Adafruit_BMP280 BMP280(TELEM_WIRE);
+static Adafruit_BMP280 BMP280;
 #endif
 
 #if ENV_INCLUDE_SHTC3
@@ -58,7 +58,6 @@ static SensirionI2cSht4x SHT4X;
 
 #if ENV_INCLUDE_LPS22HB
 #include <Arduino_LPS22HB.h>
-LPS22HBClass LPS22HB(*TELEM_WIRE);
 #endif
 
 #if ENV_INCLUDE_INA3221
@@ -219,7 +218,7 @@ bool EnvironmentSensorManager::begin() {
   #endif
 
   #if ENV_INCLUDE_SHTC3
-  if (SHTC3.begin(TELEM_WIRE)) {
+  if (SHTC3.begin()) {
     MESH_DEBUG_PRINTLN("Found sensor: SHTC3");
     SHTC3_initialized = true;
   } else {
@@ -244,7 +243,7 @@ bool EnvironmentSensorManager::begin() {
   #endif
 
   #if ENV_INCLUDE_LPS22HB
-  if (LPS22HB.begin()) {
+  if (BARO.begin()) {
     MESH_DEBUG_PRINTLN("Found sensor: LPS22HB");
     LPS22HB_initialized = true;
   } else {
@@ -284,7 +283,7 @@ bool EnvironmentSensorManager::begin() {
     INA260_initialized = true;
   } else {
     INA260_initialized = false;
-    MESH_DEBUG_PRINTLN("INA260 was not found at I2C address %02X", TELEM_INA260_ADDRESS);
+    MESH_DEBUG_PRINTLN("INA260 was not found at I2C address %02X", TELEM_INA219_ADDRESS);
   }
   #endif
 
@@ -408,8 +407,8 @@ bool EnvironmentSensorManager::querySensors(uint8_t requester_permissions, Cayen
 
     #if ENV_INCLUDE_LPS22HB
     if (LPS22HB_initialized) {
-      telemetry.addTemperature(TELEM_CHANNEL_SELF, LPS22HB.readTemperature());
-      telemetry.addBarometricPressure(TELEM_CHANNEL_SELF, LPS22HB.readPressure() * 10); // convert kPa to hPa
+      telemetry.addTemperature(TELEM_CHANNEL_SELF, BARO.readTemperature());
+      telemetry.addBarometricPressure(TELEM_CHANNEL_SELF, BARO.readPressure() * 10); // convert kPa to hPa
     }
     #endif
 

src/helpers/ui/SSD1306Display.cpp

@@ -7,10 +7,6 @@ bool SSD1306Display::i2c_probe(TwoWire& wire, uint8_t addr) {
 }
 
 bool SSD1306Display::begin() {
-  if (!_isOn) {
-    if (_peripher_power) _peripher_power->claim();
-    _isOn = true;
-  }
   #ifdef DISPLAY_ROTATION
   display.setRotation(DISPLAY_ROTATION);
   #endif
@@ -18,25 +14,13 @@ bool SSD1306Display::begin() {
 }
 
 void SSD1306Display::turnOn() {
-  if (!_isOn) {
-    if (_peripher_power) _peripher_power->claim();
-    _isOn = true;  // set before begin() to prevent double claim
-    if (_peripher_power) begin();  // re-init display after power was cut
-  }
   display.ssd1306_command(SSD1306_DISPLAYON);
+  _isOn = true;
 }
 
 void SSD1306Display::turnOff() {
   display.ssd1306_command(SSD1306_DISPLAYOFF);
-  if (_isOn) {
-    if (_peripher_power) {
-#if PIN_OLED_RESET >= 0
-      digitalWrite(PIN_OLED_RESET, LOW);
-#endif
-      _peripher_power->release();
-    }
-    _isOn = false;
-  }
+  _isOn = false;
 }
 
 void SSD1306Display::clear() {

src/helpers/ui/SSD1306Display.h

@@ -5,7 +5,6 @@
 #include <Adafruit_GFX.h>
 #define SSD1306_NO_SPLASH
 #include <Adafruit_SSD1306.h>
-#include <helpers/RefCountedDigitalPin.h>
 
 #ifndef PIN_OLED_RESET
   #define PIN_OLED_RESET        21 // Reset pin # (or -1 if sharing Arduino reset pin)
@@ -19,16 +18,10 @@ class SSD1306Display : public DisplayDriver {
   Adafruit_SSD1306 display;
   bool _isOn;
   uint8_t _color;
-  RefCountedDigitalPin* _peripher_power;
 
   bool i2c_probe(TwoWire& wire, uint8_t addr);
 public:
-  SSD1306Display(RefCountedDigitalPin* peripher_power=NULL) : DisplayDriver(128, 64), 
-      display(128, 64, &Wire, PIN_OLED_RESET),
-      _peripher_power(peripher_power)
-  {
-    _isOn = false; 
-  }
+  SSD1306Display() : DisplayDriver(128, 64), display(128, 64, &Wire, PIN_OLED_RESET) { _isOn = false; }
   bool begin();
 
   bool isOn() override { return _isOn; }

src/helpers/ui/ST7789Display.cpp

@@ -10,13 +10,8 @@
 #define Y_OFFSET 1  // Vertical offset to prevent top row cutoff
 #endif
 
-#ifdef HELTEC_VISION_MASTER_T190
-  #define SCALE_X  2.5f        // 320 / 128
-  #define SCALE_Y  2.65625f    // 170 / 64
-#else
-  #define SCALE_X  1.875f      // 240 / 128
-  #define SCALE_Y  2.109375f   // 135 / 64
-#endif
+#define SCALE_X  1.875f     // 240 / 128
+#define SCALE_Y  2.109375f   // 135 / 64
 
 bool ST7789Display::begin() {
   if(!_isOn) {

src/helpers/ui/ST7789LCDDisplay.cpp

@@ -28,14 +28,11 @@ bool ST7789LCDDisplay::begin() {
       digitalWrite(PIN_TFT_LEDA_CTL, HIGH);
     }
     if (PIN_TFT_RST != -1) {
-      pinMode(PIN_TFT_RST, OUTPUT);
-      digitalWrite(PIN_TFT_RST, LOW); 
-      delay(10);
       digitalWrite(PIN_TFT_RST, HIGH);
     }
 
     // Im not sure if this is just a t-deck problem or not, if your display is slow try this.
-    #if defined(LILYGO_TDECK) || defined(HELTEC_LORA_V4_TFT)
+    #ifdef LILYGO_TDECK
       displaySPI.begin(PIN_TFT_SCL, -1, PIN_TFT_SDA, PIN_TFT_CS);
     #endif
 

src/helpers/ui/ST7789LCDDisplay.h

@@ -8,7 +8,7 @@
 #include <helpers/RefCountedDigitalPin.h>
 
 class ST7789LCDDisplay : public DisplayDriver {
-  #if defined(LILYGO_TDECK) || defined(HELTEC_LORA_V4_TFT)
+  #ifdef LILYGO_TDECK
     SPIClass displaySPI;
   #endif
   Adafruit_ST7789 display;
@@ -25,7 +25,7 @@ public:
   {
     _isOn = false;
   }
-#elif defined(LILYGO_TDECK) || defined(HELTEC_LORA_V4_TFT)
+#elif LILYGO_TDECK
   ST7789LCDDisplay(RefCountedDigitalPin* peripher_power=NULL) : DisplayDriver(128, 64),
       displaySPI(HSPI),
       display(&displaySPI, PIN_TFT_CS, PIN_TFT_DC, PIN_TFT_RST),

tools/maint/patch_and_build_hansemesh_fw.sh

@@ -1,64 +0,0 @@
-#!/bin/bash  # Note: switched to bash for process substitution support
-
-export PATH="$HOME/.platformio/penv/bin:$PATH"
-
-LOGFILE="$PWD/meshcore-evo-fw.log"
-FIRMWARE_VERSION="v1.12.0-evo_0.1.7"
-FIRMWARE_BUILD_DATE=$(date '+%d-%b-%Y')
-
-collect_bin_files(){
-    DEST_DIR="./firmwares"
-    mkdir -p "$DEST_DIR"
-    BUILD_DIR=".pio/build"
-
-    if [ ! -d "$BUILD_DIR" ]; then
-        echo "Error: $BUILD_DIR not found. Did you run the build process?"
-        exit 1
-    fi
-
-    echo "Copying firmware files to $DEST_DIR..."
-
-    for target_path in "$BUILD_DIR"/*/; do
-        echo $target_path
-        target_name=$(basename "$target_path")
-    #    if ls "$target_path"*.bin >/dev/null 2>&1; then
-            for bin_file in "$target_path"*firmware*.{uf2,bin,zip}; do
-                filename=$(basename "$bin_file")
-                new_filename="${target_name}_${FIRMWARE_VERSION}_${FIRMWARE_BUILD_DATE}_${filename}"
-                cp "$bin_file" "$DEST_DIR/$new_filename"
-                echo "Done: $new_filename"
-            done
-    #    fi
-    done
-}
-
-# Everything after this line goes to BOTH console and logfile
-exec > >(tee -a "$LOGFILE") 2>&1
-
-echo "-------------------- Build start ----------------"
-date
-echo "-------------------------------------------------"
-
-# apply patches
-# ./tools/maint/apply_patches.sh 1199 1338 1297
-
-# build all repeater firmwares, the will be in .out
-FIRMWARE_VERSION=$FIRMWARE_VERSION ./build.sh build-repeater-firmwares
-
-# build single firmwares
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware ProMicro_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware RAK_4631_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware heltec_v4_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware Heltec_v3_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware Xiao_nrf52_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware LilyGo_T3S3_sx1262_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware Heltec_t114_without_display_repeater
-#FIRMWARE_VERSION=$FIRMWARE_VERSION FIRMWARE_BUILD_DATE=$FIRMWARE_BUILD_DATE ./build.sh build-firmware Heltec_t114_repeater
-#collect_bin_files
-
-
-echo "-------------------- Build end ------------------"
-date
-echo "-------------------------------------------------"
-
-#grep -E " SUCCESS | FAILED " hansemesh_fw.log

variants/ebyte_eora_s3/target.cpp

@@ -75,7 +75,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/ebyte_eora_s3/target.h

@@ -25,5 +25,5 @@ extern SensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/generic-e22/target.cpp

@@ -38,7 +38,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/generic-e22/target.h

@@ -17,5 +17,5 @@ extern SensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/generic_espnow/target.cpp

@@ -25,7 +25,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   // no-op
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio_driver.setTxPower(dbm);
 }
 

variants/generic_espnow/target.h

@@ -12,5 +12,5 @@ extern SensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_ct62/target.cpp

@@ -27,7 +27,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_ct62/target.h

@@ -16,5 +16,5 @@ extern SensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_e213/target.cpp

@@ -44,7 +44,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_e213/target.h

@@ -25,5 +25,5 @@ extern MomentaryButton user_btn;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_e290/target.cpp

@@ -44,7 +44,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_e290/target.h

@@ -25,5 +25,5 @@ extern MomentaryButton user_btn;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_mesh_solar/MeshSolarBoard.h

@@ -20,9 +20,9 @@
 #define SX126X_DIO2_AS_RF_SWITCH  true
 #define SX126X_DIO3_TCXO_VOLTAGE   1.8
 
-class MeshSolarBoard : public NRF52BoardDCDC {
+class MeshSolarBoard : public NRF52BoardOTA {
 public:
-  MeshSolarBoard() : NRF52Board("MESH_SOLAR_OTA") {}
+  MeshSolarBoard() : NRF52BoardOTA("MESH_SOLAR_OTA") {}
   void begin();
 
   uint16_t getBattMilliVolts() override {

variants/heltec_mesh_solar/target.cpp

@@ -34,7 +34,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_mesh_solar/target.h

@@ -42,5 +42,5 @@ extern SolarSensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_t114/T114Board.cpp

@@ -3,37 +3,9 @@
 #include <Arduino.h>
 #include <Wire.h>
 
-#ifdef NRF52_POWER_MANAGEMENT
-// Static configuration for power management
-// Values come from variant.h defines
-const PowerMgtConfig power_config = {
-  .lpcomp_ain_channel = PWRMGT_LPCOMP_AIN,
-  .lpcomp_refsel = PWRMGT_LPCOMP_REFSEL,
-  .voltage_bootlock = PWRMGT_VOLTAGE_BOOTLOCK
-};
-
-void T114Board::initiateShutdown(uint8_t reason) {
-#if ENV_INCLUDE_GPS == 1
-  pinMode(GPS_EN, OUTPUT);
-  digitalWrite(GPS_EN, LOW);
-#endif
-  digitalWrite(SX126X_POWER_EN, LOW);
-
-  bool enable_lpcomp = (reason == SHUTDOWN_REASON_LOW_VOLTAGE ||
-                        reason == SHUTDOWN_REASON_BOOT_PROTECT);
-  pinMode(PIN_BAT_CTL, OUTPUT);
-  digitalWrite(PIN_BAT_CTL, enable_lpcomp ? HIGH : LOW);
-
-  if (enable_lpcomp) {
-    configureVoltageWake(power_config.lpcomp_ain_channel, power_config.lpcomp_refsel);
-  }
-
-  enterSystemOff(reason);
-}
-#endif // NRF52_POWER_MANAGEMENT
-
 void T114Board::begin() {
   NRF52Board::begin();
+  NRF_POWER->DCDCEN = 1;
 
   pinMode(PIN_VBAT_READ, INPUT);
 
@@ -49,11 +21,6 @@ void T114Board::begin() {
 #endif
 
   pinMode(SX126X_POWER_EN, OUTPUT);
-#ifdef NRF52_POWER_MANAGEMENT
-  // Boot voltage protection check (may not return if voltage too low)
-  // We need to call this after we configure SX126X_POWER_EN as output but before we pull high
-  checkBootVoltage(&power_config);
-#endif
   digitalWrite(SX126X_POWER_EN, HIGH);
   delay(10); // give sx1262 some time to power up
 }

variants/heltec_t114/T114Board.h

@@ -9,14 +9,9 @@
 #define  PIN_BAT_CTL      6
 #define  MV_LSB   (3000.0F / 4096.0F) // 12-bit ADC with 3.0V input range
 
-class T114Board : public NRF52BoardDCDC {
-protected:
-#ifdef NRF52_POWER_MANAGEMENT
-  void initiateShutdown(uint8_t reason) override;
-#endif
-
+class T114Board : public NRF52BoardOTA {
 public:
-  T114Board() : NRF52Board("T114_OTA") {}
+    T114Board() : NRF52BoardOTA("T114_OTA") {}
   void begin();
 
 #if defined(P_LORA_TX_LED)
@@ -47,13 +42,13 @@ public:
   }
 
   void powerOff() override {
-#ifdef LED_PIN
+    #ifdef LED_PIN
     digitalWrite(LED_PIN, HIGH);
-#endif
-#if ENV_INCLUDE_GPS == 1
+    #endif
+    #if ENV_INCLUDE_GPS == 1
     pinMode(GPS_EN, OUTPUT);
     digitalWrite(GPS_EN, LOW);
-#endif
+    #endif
     sd_power_system_off();
   }
 };

variants/heltec_t114/platformio.ini

@@ -6,13 +6,11 @@ extends = nrf52_base
 board = heltec_t114
 board_build.ldscript = boards/nrf52840_s140_v6.ld
 build_flags = ${nrf52_base.build_flags}
-  ${sensor_base.build_flags}
   -I lib/nrf52/s140_nrf52_6.1.1_API/include
   -I lib/nrf52/s140_nrf52_6.1.1_API/include/nrf52
   -I variants/heltec_t114
   -I src/helpers/ui
   -D HELTEC_T114
-  -D NRF52_POWER_MANAGEMENT
   -D P_LORA_DIO_1=20
   -D P_LORA_NSS=24
   -D P_LORA_RESET=25
@@ -29,20 +27,20 @@ build_flags = ${nrf52_base.build_flags}
   -D SX126X_DIO3_TCXO_VOLTAGE=1.8
   -D SX126X_CURRENT_LIMIT=140
   -D SX126X_RX_BOOSTED_GAIN=1
+  -D DISPLAY_CLASS=NullDisplayDriver
+  -D ST7789
   -D PIN_GPS_RX=39
   -D PIN_GPS_TX=37
   -D PIN_GPS_EN=21
   -D PIN_GPS_RESET=38
   -D PIN_GPS_RESET_ACTIVE=LOW
-  -D ENV_PIN_SDA=PIN_WIRE1_SDA
-  -D ENV_PIN_SCL=PIN_WIRE1_SCL
 build_src_filter = ${nrf52_base.build_src_filter}
   +<helpers/*.cpp>
-  +<helpers/sensors>
   +<../variants/heltec_t114>
 lib_deps =
   ${nrf52_base.lib_deps}
-  ${sensor_base.lib_deps}
+  stevemarple/MicroNMEA @ ^2.0.6
+  adafruit/Adafruit GFX Library @ ^1.12.1
 debug_tool = jlink
 upload_protocol = nrfutil
 
@@ -101,7 +99,6 @@ board_upload.maximum_size = 712704
 build_flags =
   ${Heltec_t114.build_flags}
   -I examples/companion_radio/ui-new
-  -D DISPLAY_CLASS=NullDisplayDriver
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=40
   -D BLE_PIN_CODE=123456
@@ -124,7 +121,6 @@ board_upload.maximum_size = 712704
 build_flags =
   ${Heltec_t114.build_flags}
   -I examples/companion_radio/ui-new
-  -D DISPLAY_CLASS=NullDisplayDriver
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=40
 ;  -D BLE_PIN_CODE=123456
@@ -147,7 +143,6 @@ extends = Heltec_t114
 board = heltec_t114
 board_build.ldscript = boards/nrf52840_s140_v6.ld
 build_flags = ${Heltec_t114.build_flags}
-  -D ST7789
   -D HELTEC_T114_WITH_DISPLAY
   -D DISPLAY_CLASS=ST7789Display
 build_src_filter = ${Heltec_t114.build_src_filter}
@@ -157,7 +152,6 @@ build_src_filter = ${Heltec_t114.build_src_filter}
   +<helpers/ui/OLEDDisplayFonts.cpp>
 lib_deps =
   ${Heltec_t114.lib_deps}
-  adafruit/Adafruit SSD1306 @ ^2.5.13
 debug_tool = jlink
 upload_protocol = nrfutil
 

variants/heltec_t114/target.cpp

@@ -1,46 +1,28 @@
-#include "target.h"
-
 #include <Arduino.h>
+#include "target.h"
 #include <helpers/ArduinoHelpers.h>
-
-#ifdef ENV_INCLUDE_GPS
 #include <helpers/sensors/MicroNMEALocationProvider.h>
-#endif
 
 T114Board board;
 
-#if defined(P_LORA_SCLK)
 RADIO_CLASS radio = new Module(P_LORA_NSS, P_LORA_DIO_1, P_LORA_RESET, P_LORA_BUSY, SPI);
-#else
-RADIO_CLASS radio = new Module(P_LORA_NSS, P_LORA_DIO_1, P_LORA_RESET, P_LORA_BUSY);
-#endif
 
 WRAPPER_CLASS radio_driver(radio, board);
 
 VolatileRTCClock fallback_clock;
 AutoDiscoverRTCClock rtc_clock(fallback_clock);
-
-#if ENV_INCLUDE_GPS
-#include <helpers/sensors/MicroNMEALocationProvider.h>
-MicroNMEALocationProvider nmea = MicroNMEALocationProvider(Serial1);
-EnvironmentSensorManager sensors = EnvironmentSensorManager(nmea);
-#else
-EnvironmentSensorManager sensors;
-#endif
+MicroNMEALocationProvider nmea = MicroNMEALocationProvider(Serial1, &rtc_clock);
+T114SensorManager sensors = T114SensorManager(nmea);
 
 #ifdef DISPLAY_CLASS
-DISPLAY_CLASS display;
-MomentaryButton user_btn(PIN_USER_BTN, 1000, true);
+  DISPLAY_CLASS display;
+  MomentaryButton user_btn(PIN_USER_BTN, 1000, true);
 #endif
 
 bool radio_init() {
   rtc_clock.begin(Wire);
 
-#if defined(P_LORA_SCLK)
   return radio.std_init(&SPI);
-#else
-  return radio.std_init();
-#endif
 }
 
 uint32_t radio_get_rng_seed() {
@@ -54,11 +36,98 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 
 mesh::LocalIdentity radio_new_identity() {
   RadioNoiseListener rng(radio);
-  return mesh::LocalIdentity(&rng); // create new random identity
+  return mesh::LocalIdentity(&rng);  // create new random identity
+}
+
+void T114SensorManager::start_gps() {
+  if (!gps_active) {
+    gps_active = true;
+    _location->begin();
+  }
+}
+
+void T114SensorManager::stop_gps() {
+  if (gps_active) {
+    gps_active = false;
+    _location->stop();
+  }
+}
+
+bool T114SensorManager::begin() {
+  Serial1.begin(9600);
+
+  // Try to detect if GPS is physically connected to determine if we should expose the setting
+  pinMode(GPS_EN, OUTPUT);
+  digitalWrite(GPS_EN, HIGH);  // Power on GPS
+
+  // Give GPS a moment to power up and send data
+  delay(1500);
+
+  // We'll consider GPS detected if we see any data on Serial1
+  gps_detected = (Serial1.available() > 0);
+
+  if (gps_detected) {
+    MESH_DEBUG_PRINTLN("GPS detected");
+  } else {
+    MESH_DEBUG_PRINTLN("No GPS detected");
+  }
+  digitalWrite(GPS_EN, LOW);  // Power off GPS until the setting is changed
+
+  return true;
+}
+
+bool T114SensorManager::querySensors(uint8_t requester_permissions, CayenneLPP& telemetry) {
+  if (requester_permissions & TELEM_PERM_LOCATION) {   // does requester have permission?
+    telemetry.addGPS(TELEM_CHANNEL_SELF, node_lat, node_lon, node_altitude);
+  }
+  return true;
+}
+
+void T114SensorManager::loop() {
+  static long next_gps_update = 0;
+
+  _location->loop();
+
+  if (millis() > next_gps_update) {
+    if (_location->isValid()) {
+      node_lat = ((double)_location->getLatitude())/1000000.;
+      node_lon = ((double)_location->getLongitude())/1000000.;
+      node_altitude = ((double)_location->getAltitude()) / 1000.0;
+      MESH_DEBUG_PRINTLN("lat %f lon %f", node_lat, node_lon);
+    }
+    next_gps_update = millis() + 1000;
+  }
+}
+
+int T114SensorManager::getNumSettings() const {
+  return gps_detected ? 1 : 0;  // only show GPS setting if GPS is detected
+}
+
+const char* T114SensorManager::getSettingName(int i) const {
+  return (gps_detected && i == 0) ? "gps" : NULL;
+}
+
+const char* T114SensorManager::getSettingValue(int i) const {
+  if (gps_detected && i == 0) {
+    return gps_active ? "1" : "0";
+  }
+  return NULL;
+}
+
+bool T114SensorManager::setSettingValue(const char* name, const char* value) {
+  if (gps_detected && strcmp(name, "gps") == 0) {
+    if (strcmp(value, "0") == 0) {
+      stop_gps();
+    } else {
+      start_gps();
+    }
+    return true;
+  }
+  return false;  // not supported
 }

variants/heltec_t114/target.h

@@ -2,11 +2,11 @@
 
 #define RADIOLIB_STATIC_ONLY 1
 #include <RadioLib.h>
-#include <T114Board.h>
-#include <helpers/AutoDiscoverRTCClock.h>
-#include <helpers/radiolib/CustomSX1262Wrapper.h>
 #include <helpers/radiolib/RadioLibWrappers.h>
-#include <helpers/sensors/EnvironmentSensorManager.h>
+#include <T114Board.h>
+#include <helpers/radiolib/CustomSX1262Wrapper.h>
+#include <helpers/AutoDiscoverRTCClock.h>
+#include <helpers/SensorManager.h>
 #include <helpers/sensors/LocationProvider.h>
 
 #ifdef DISPLAY_CLASS
@@ -18,18 +18,37 @@
 #endif
 #endif
 
+class T114SensorManager : public SensorManager {
+  bool gps_active = false;
+  bool gps_detected = false;
+  LocationProvider* _location;
+
+  void start_gps();
+  void stop_gps();
+public:
+  T114SensorManager(LocationProvider &location): _location(&location) { }
+  bool begin() override;
+  bool querySensors(uint8_t requester_permissions, CayenneLPP& telemetry) override;
+  void loop() override;
+  LocationProvider* getLocationProvider() override { return gps_detected ? _location : NULL; }
+  int getNumSettings() const override;
+  const char* getSettingName(int i) const override;
+  const char* getSettingValue(int i) const override;
+  bool setSettingValue(const char* name, const char* value) override;
+};
+
 extern T114Board board;
 extern WRAPPER_CLASS radio_driver;
 extern AutoDiscoverRTCClock rtc_clock;
-extern EnvironmentSensorManager sensors;
+extern T114SensorManager sensors;
 
 #ifdef DISPLAY_CLASS
-extern DISPLAY_CLASS display;
-extern MomentaryButton user_btn;
+  extern DISPLAY_CLASS display;
+  extern MomentaryButton user_btn;
 #endif
 
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_t114/variant.h

@@ -14,7 +14,7 @@
 #define USE_LFXO    // 32.768 kHz crystal oscillator
 #define VARIANT_MCK (64000000ul)
 
-#define WIRE_INTERFACES_COUNT 	(2)
+#define WIRE_INTERFACES_COUNT 	(1)
 
 ////////////////////////////////////////////////////////////////////////////////
 // Power
@@ -30,14 +30,6 @@
 
 #define AREF_VOLTAGE            (3.0)
 
-// Power management boot protection threshold (millivolts)
-// Set to 0 to disable boot protection
-#define PWRMGT_VOLTAGE_BOOTLOCK 3300   // Won't boot below this voltage (mV)
-// LPCOMP wake configuration (voltage recovery from SYSTEMOFF)
-// AIN2 = P0.04 = BATTERY_PIN / PIN_VBAT_READ
-#define PWRMGT_LPCOMP_AIN 2
-#define PWRMGT_LPCOMP_REFSEL 1  // 2/8 VDD (~3.68-4.04V)
-
 ////////////////////////////////////////////////////////////////////////////////
 // Number of pins
 
@@ -58,11 +50,8 @@
 ////////////////////////////////////////////////////////////////////////////////
 // I2C pin definition
 
-#define PIN_WIRE_SDA            (26) // P0.26
-#define PIN_WIRE_SCL            (27) // P0.27
-
-#define PIN_WIRE1_SDA            (7) // P0.8
-#define PIN_WIRE1_SCL            (8) // P0.7
+#define PIN_WIRE_SDA            (26)             // P0.26
+#define PIN_WIRE_SCL            (27)             // P0.27
 
 ////////////////////////////////////////////////////////////////////////////////
 // SPI pin definition

variants/heltec_t190/target.cpp

@@ -44,7 +44,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_t190/target.h

@@ -25,5 +25,5 @@ extern MomentaryButton user_btn;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_tracker/target.cpp

@@ -47,7 +47,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_tracker/target.h

@@ -43,5 +43,5 @@ extern HWTSensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_tracker_v2/target.cpp

@@ -50,7 +50,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_tracker_v2/target.h

@@ -26,5 +26,5 @@ extern EnvironmentSensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_v2/target.cpp

@@ -43,7 +43,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_v2/target.h

@@ -25,5 +25,5 @@ extern SensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_v3/platformio.ini

@@ -323,7 +323,7 @@ lib_deps =
 extends = Heltec_lora32_v3
 build_flags =
   ${Heltec_lora32_v3.build_flags}
-  -D MAX_CONTACTS=350
+  -D MAX_CONTACTS=140
   -D MAX_GROUP_CHANNELS=40
 ; NOTE: DO NOT ENABLE -->  -D MESH_PACKET_LOGGING=1
 ; NOTE: DO NOT ENABLE -->  -D MESH_DEBUG=1
@@ -367,12 +367,3 @@ build_src_filter = ${Heltec_lora32_v3.build_src_filter}
 lib_deps =
   ${Heltec_lora32_v3.lib_deps}
   ${esp32_ota.lib_deps}
-
-[env:Heltec_v3_kiss_modem]
-extends = Heltec_lora32_v3
-build_flags =
-  ${Heltec_lora32_v3.build_flags}
-build_src_filter = ${Heltec_lora32_v3.build_src_filter}
-  +<../examples/kiss_modem/>
-lib_deps =
-  ${Heltec_lora32_v3.lib_deps}

variants/heltec_v3/target.cpp

@@ -50,7 +50,7 @@ void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr) {
   radio.setCodingRate(cr);
 }
 
-void radio_set_tx_power(int8_t dbm) {
+void radio_set_tx_power(uint8_t dbm) {
   radio.setOutputPower(dbm);
 }
 

variants/heltec_v3/target.h

@@ -26,5 +26,5 @@ extern EnvironmentSensorManager sensors;
 bool radio_init();
 uint32_t radio_get_rng_seed();
 void radio_set_params(float freq, float bw, uint8_t sf, uint8_t cr);
-void radio_set_tx_power(int8_t dbm);
+void radio_set_tx_power(uint8_t dbm);
 mesh::LocalIdentity radio_new_identity();

variants/heltec_v4/HeltecV4Board.cpp

@@ -86,9 +86,5 @@ void HeltecV4Board::begin() {
   }
 
   const char* HeltecV4Board::getManufacturerName() const {
-  #ifdef HELTEC_LORA_V4_TFT
-    return "Heltec V4 TFT";
-  #else
-    return "Heltec V4 OLED";
-  #endif
+    return "Heltec V4";
   }

variants/heltec_v4/platformio.ini

@@ -17,19 +17,20 @@ build_flags =
   -D P_LORA_SCLK=9
   -D P_LORA_MISO=11
   -D P_LORA_MOSI=10
-  -D P_LORA_PA_POWER=7   ; VFEM_Ctrl - Power on GC1109
-  -D P_LORA_PA_EN=2      ; PA CSD - Enable GC1109
-  -D P_LORA_PA_TX_EN=46  ; PA CPS - GC1109 TX PA full(High) / bypass(Low)
+  -D P_LORA_PA_POWER=7   ;power en
+  -D P_LORA_PA_EN=2
+  -D P_LORA_PA_TX_EN=46  ;enable tx
+  -D PIN_BOARD_SDA=17
+  -D PIN_BOARD_SCL=18
   -D PIN_USER_BTN=0
   -D PIN_VEXT_EN=36
-  -D PIN_VEXT_EN_ACTIVE=LOW
+  -D PIN_VEXT_EN_ACTIVE=HIGH
   -D LORA_TX_POWER=10 ;If it is configured as 10 here, the final output will be 22 dbm.
   -D MAX_LORA_TX_POWER=22 ; Max SX1262 output
-  -D SX126X_REGISTER_PATCH=1       ; Patch register 0x8B5 for improved RX
-  -D SX126X_DIO2_AS_RF_SWITCH=true ; GC1109 CTX is controlled by SX1262 DIO2
+  -D SX126X_DIO2_AS_RF_SWITCH=true
   -D SX126X_DIO3_TCXO_VOLTAGE=1.8
   -D SX126X_CURRENT_LIMIT=140
-  -D SX126X_RX_BOOSTED_GAIN=1      ; In some cases, commenting this out will improve RX
+  -D SX126X_RX_BOOSTED_GAIN=1
   -D PIN_GPS_RX=38
   -D PIN_GPS_TX=39
   -D PIN_GPS_RESET=42
@@ -46,45 +47,10 @@ lib_deps =
   ${esp32_base.lib_deps}
   ${sensor_base.lib_deps}
 
-[heltec_v4_oled]
-extends = Heltec_lora32_v4
-build_flags =
-  ${Heltec_lora32_v4.build_flags}
-  -D HELTEC_LORA_V4_OLED
-  -D PIN_BOARD_SDA=17
-  -D PIN_BOARD_SCL=18
-  -D PIN_OLED_RESET=21
-  -D ENV_PIN_SDA=4
-  -D ENV_PIN_SCL=3
-build_src_filter= ${Heltec_lora32_v4.build_src_filter}
-lib_deps = ${Heltec_lora32_v4.lib_deps}
-
-[heltec_v4_tft]
-extends = Heltec_lora32_v4
-build_flags =
-  ${Heltec_lora32_v4.build_flags}
-  -D HELTEC_LORA_V4_TFT
-  -D PIN_BOARD_SDA=4
-  -D PIN_BOARD_SCL=3
-  -D DISPLAY_SCALE_X=2.5
-  -D DISPLAY_SCALE_Y=3.75
-  -D PIN_TFT_RST=18
-  -D PIN_TFT_VDD_CTL=-1
-  -D PIN_TFT_LEDA_CTL=21
-  -D PIN_TFT_LEDA_CTL_ACTIVE=HIGH
-  -D PIN_TFT_CS=15
-  -D PIN_TFT_DC=16
-  -D PIN_TFT_SCL=17
-  -D PIN_TFT_SDA=33
-build_src_filter= ${Heltec_lora32_v4.build_src_filter}
-lib_deps = 
-  ${Heltec_lora32_v4.lib_deps}
-  adafruit/Adafruit ST7735 and ST7789 Library @ ^1.11.0
-
 [env:heltec_v4_repeater]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -D DISPLAY_CLASS=SSD1306Display
   -D ADVERT_NAME='"Heltec Repeater"'
   -D ADVERT_LAT=0.0
@@ -93,18 +59,18 @@ build_flags =
   -D MAX_NEIGHBOURS=50
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<helpers/ui/SSD1306Display.cpp>
   +<../examples/simple_repeater>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   ${esp32_ota.lib_deps}
   bakercp/CRC32 @ ^2.0.0
 
 [env:heltec_v4_repeater_bridge_espnow]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -D DISPLAY_CLASS=SSD1306Display
   -D ADVERT_NAME='"ESPNow Bridge"'
   -D ADVERT_LAT=0.0
@@ -115,18 +81,18 @@ build_flags =
 ;  -D BRIDGE_DEBUG=1
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<helpers/bridges/ESPNowBridge.cpp>
   +<helpers/ui/SSD1306Display.cpp>
   +<../examples/simple_repeater>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   ${esp32_ota.lib_deps}
 
 [env:heltec_v4_room_server]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -D DISPLAY_CLASS=SSD1306Display
   -D ADVERT_NAME='"Heltec Room"'
   -D ADVERT_LAT=0.0
@@ -135,50 +101,50 @@ build_flags =
   -D ROOM_PASSWORD='"hello"'
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<helpers/ui/SSD1306Display.cpp>
   +<../examples/simple_room_server>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   ${esp32_ota.lib_deps}
 
 [env:heltec_v4_terminal_chat]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=1
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<../examples/simple_secure_chat/main.cpp>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   densaugeo/base64 @ ~1.4.0
 
 [env:heltec_v4_companion_radio_usb]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -I examples/companion_radio/ui-new
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=40
   -D DISPLAY_CLASS=SSD1306Display
 ; NOTE: DO NOT ENABLE -->  -D MESH_PACKET_LOGGING=1
 ; NOTE: DO NOT ENABLE -->  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<helpers/ui/SSD1306Display.cpp>
   +<helpers/ui/MomentaryButton.cpp>
   +<../examples/companion_radio/*.cpp>
   +<../examples/companion_radio/ui-new/*.cpp>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   densaugeo/base64 @ ~1.4.0
 
 [env:heltec_v4_companion_radio_ble]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -I examples/companion_radio/ui-new
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=40
@@ -189,20 +155,20 @@ build_flags =
   -D OFFLINE_QUEUE_SIZE=256
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
   +<helpers/ui/SSD1306Display.cpp>
   +<helpers/ui/MomentaryButton.cpp>
   +<helpers/esp32/*.cpp>
   +<../examples/companion_radio/*.cpp>
   +<../examples/companion_radio/ui-new/*.cpp>
 lib_deps =
-  ${heltec_v4_oled.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   densaugeo/base64 @ ~1.4.0
 
 [env:heltec_v4_companion_radio_wifi]
-extends = heltec_v4_oled
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_oled.build_flags}
+  ${Heltec_lora32_v4.build_flags}
   -I examples/companion_radio/ui-new
   -D MAX_CONTACTS=350
   -D MAX_GROUP_CHANNELS=40
@@ -210,197 +176,35 @@ build_flags =
   -D WIFI_DEBUG_LOGGING=1
   -D WIFI_SSID='"myssid"'
   -D WIFI_PWD='"mypwd"'
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
-  +<helpers/ui/SSD1306Display.cpp>
-  +<helpers/ui/MomentaryButton.cpp>
-  +<helpers/esp32/*.cpp>
-  +<../examples/companion_radio/*.cpp>
-  +<../examples/companion_radio/ui-new/*.cpp>
-lib_deps =
-  ${heltec_v4_oled.lib_deps}
-  densaugeo/base64 @ ~1.4.0
-
-[env:heltec_v4_sensor]
-extends = heltec_v4_oled
-build_flags =
-  ${heltec_v4_oled.build_flags}
-  -D ADVERT_NAME='"Heltec v4 Sensor"'
-  -D ADVERT_LAT=0.0
-  -D ADVERT_LON=0.0
-  -D ADMIN_PASSWORD='"password"'
-  -D ENV_PIN_SDA=3
-  -D ENV_PIN_SCL=4
-  -D DISPLAY_CLASS=SSD1306Display
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_oled.build_src_filter}
-  +<helpers/ui/SSD1306Display.cpp>
-  +<../examples/simple_sensor>
-lib_deps =
-  ${heltec_v4_oled.lib_deps}
-  ${esp32_ota.lib_deps}
-
-
-[env:heltec_v4_tft_repeater]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-  -D ADVERT_NAME='"Heltec Repeater"'
-  -D ADVERT_LAT=0.0
-  -D ADVERT_LON=0.0
-  -D ADMIN_PASSWORD='"password"'
-  -D MAX_NEIGHBOURS=50
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
-  +<../examples/simple_repeater>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  ${esp32_ota.lib_deps}
-  bakercp/CRC32 @ ^2.0.0
-
-
-[env:heltec_v4_tft_repeater_bridge_espnow]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-  -D ADVERT_NAME='"ESPNow Bridge"'
-  -D ADVERT_LAT=0.0
-  -D ADVERT_LON=0.0
-  -D ADMIN_PASSWORD='"password"'
-  -D MAX_NEIGHBOURS=50
-  -D WITH_ESPNOW_BRIDGE=1
-;  -D BRIDGE_DEBUG=1
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/bridges/ESPNowBridge.cpp>
-  +<helpers/ui/ST7789LCDDisplay.cpp>
-  +<../examples/simple_repeater>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  ${esp32_ota.lib_deps}
-
-[env:heltec_v4_tft_room_server]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-  -D ADVERT_NAME='"Heltec Room"'
-  -D ADVERT_LAT=0.0
-  -D ADVERT_LON=0.0
-  -D ADMIN_PASSWORD='"password"'
-  -D ROOM_PASSWORD='"hello"'
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
-  +<../examples/simple_room_server>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  ${esp32_ota.lib_deps}
-
-[env:heltec_v4_tft_terminal_chat]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -D MAX_CONTACTS=350
-  -D MAX_GROUP_CHANNELS=1
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<../examples/simple_secure_chat/main.cpp>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  densaugeo/base64 @ ~1.4.0
-
-[env:heltec_v4_tft_companion_radio_usb]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -I examples/companion_radio/ui-new
-  -D MAX_CONTACTS=350
-  -D MAX_GROUP_CHANNELS=40
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-; NOTE: DO NOT ENABLE -->  -D MESH_PACKET_LOGGING=1
-; NOTE: DO NOT ENABLE -->  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
-  +<helpers/ui/MomentaryButton.cpp>
-  +<../examples/companion_radio/*.cpp>
-  +<../examples/companion_radio/ui-new/*.cpp>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  densaugeo/base64 @ ~1.4.0
-
-[env:heltec_v4_tft_companion_radio_ble]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -I examples/companion_radio/ui-new
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-  -D MAX_CONTACTS=350
-  -D MAX_GROUP_CHANNELS=40
-  -D BLE_PIN_CODE=123456   ; dynamic, random PIN
-  -D AUTO_SHUTDOWN_MILLIVOLTS=3400
-  -D BLE_DEBUG_LOGGING=1
   -D OFFLINE_QUEUE_SIZE=256
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
+  +<helpers/ui/SSD1306Display.cpp>
   +<helpers/ui/MomentaryButton.cpp>
   +<helpers/esp32/*.cpp>
   +<../examples/companion_radio/*.cpp>
   +<../examples/companion_radio/ui-new/*.cpp>
 lib_deps =
-  ${heltec_v4_tft.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   densaugeo/base64 @ ~1.4.0
 
-[env:heltec_v4_tft_companion_radio_wifi]
-extends = heltec_v4_tft
+[env:heltec_v4_sensor]
+extends = Heltec_lora32_v4
 build_flags =
-  ${heltec_v4_tft.build_flags}
-  -I examples/companion_radio/ui-new
-  -D MAX_CONTACTS=350
-  -D MAX_GROUP_CHANNELS=40
-  -D DISPLAY_CLASS=ST7789LCDDisplay
-  -D WIFI_DEBUG_LOGGING=1
-  -D WIFI_SSID='"myssid"'
-  -D WIFI_PWD='"mypwd"'
-;  -D MESH_PACKET_LOGGING=1
-;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
-  +<helpers/ui/MomentaryButton.cpp>
-  +<helpers/esp32/*.cpp>
-  +<../examples/companion_radio/*.cpp>
-  +<../examples/companion_radio/ui-new/*.cpp>
-lib_deps =
-  ${heltec_v4_tft.lib_deps}
-  densaugeo/base64 @ ~1.4.0
-
-[env:heltec_v4_tft_sensor]
-extends = heltec_v4_tft
-build_flags =
-  ${heltec_v4_tft.build_flags}
-  -D ADVERT_NAME='"Heltec v4 Sensor"'
+  ${Heltec_lora32_v4.build_flags}
+  -D ADVERT_NAME='"Heltec v3 Sensor"'
   -D ADVERT_LAT=0.0
   -D ADVERT_LON=0.0
   -D ADMIN_PASSWORD='"password"'
   -D ENV_PIN_SDA=3
   -D ENV_PIN_SCL=4
-  -D DISPLAY_CLASS=ST7789LCDDisplay
+  -D DISPLAY_CLASS=SSD1306Display
 ;  -D MESH_PACKET_LOGGING=1
 ;  -D MESH_DEBUG=1
-build_src_filter = ${heltec_v4_tft.build_src_filter}
-  +<helpers/ui/ST7789LCDDisplay.cpp>
+build_src_filter = ${Heltec_lora32_v4.build_src_filter}
+  +<helpers/ui/SSD1306Display.cpp>
   +<../examples/simple_sensor>
 lib_deps =
-  ${heltec_v4_tft.lib_deps}
+  ${Heltec_lora32_v4.lib_deps}
   ${esp32_ota.lib_deps}