Mirrors/MeshCore-Solo
1
0
Fork 0
mirror of https://github.com/MarekZegare4/MeshCore-Solo.git synced 2026-08-02 18:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): drop popup menu's header gap, tighten row tiling

Browse Source 
PopupMenu is compact and stands alone (no full-screen header to separate
from), so the gap meant for listStart() just wasted vertical space and let
the selection bar's edges miss the box border by a few px.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jakub
2026-06-18 15:33:18 +02:00
co-authored by Claude Sonnet 4.6
parent 92643d1721
commit 1bf90ed2fb
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/companion_radio/ui-new/PopupMenu.h
+4 -3
View File
@@ -41,8 +41,9 @@ struct PopupMenu {
const int item_h = lh + 2; // row pitch const int item_h = lh + 2; // row pitch
const int pad = 4; // inner left/right padding const int pad = 4; // inner left/right padding
const int margin = 4; // gap to the screen edge const int margin = 4; // gap to the screen edge
const int gap = 2; // breathing room below the separator (matches listStart()) // Compact menu: rows tile straight under the separator (no header gap here —
const int title_h = lh + 2 + sh + gap; // title text + scaled separator + gap // unlike full screens) so the selection bar fills its cell edge to edge.
const int title_h = lh + 2 + sh; // title text + scaled separator
// Hard ceiling: never show more rows than physically fit on screen. // Hard ceiling: never show more rows than physically fit on screen.
int avail_h = display.height() - margin * 2 - title_h - 2; int avail_h = display.height() - margin * 2 - title_h - 2;
@@ -78,7 +79,7 @@ struct PopupMenu {
if (bw < min_bw) bw = min_bw; if (bw < min_bw) bw = min_bw;
if (bw > max_bw) bw = max_bw; if (bw > max_bw) bw = max_bw;
int bh = title_h + vis * item_h + 2; int bh = title_h + vis * item_h + 1; // +1 keeps the last row off the bottom border
// Centre on screen (clamped to the margins on small displays). // Centre on screen (clamped to the margins on small displays).
int bx = (display.width() - bw) / 2; int bx = (display.width() - bw) / 2;