Add audit and reports page, and a change journal

ProxMenux modifies the host: it rewrites configuration files, installs packages, enables services. Until now nobody could say afterwards what had changed, and showing the script does not answer that question — a four-hundred-line function may alter two values, and the reader has no way to know which two. This adds the two halves of an answer.

The change journal records what ProxMenux does as it does it. Eleven bash primitives capture the previous state, apply the change and record it in the same step, writing to a spool that the Monitor reads back. One hundred and thirteen functions across twenty-five scripts are instrumented, covering post-install, shared storage, security tooling, container conversions, disk operations and the PVE 8 to 9 upgrade path. The page shows the difference — rotate 7 becoming rotate 14 — and never the script. Restore and backup scripts are deliberately left out: a restore puts the host back to a state some other script already recorded.

The Audit and reports page answers the other half: what state is this host in, regardless of who put it there. Forty-three checks across seven areas read the host and classify each result as critical, warning, observation, conformant, unverified or not applicable, with the evidence they read attached to each one. A declared policy lets the reader say what this particular host is expected to do — which guests must have a backup, which storages are essential — so the report judges the host against its own intent rather than a generic template. An inventory records the hardware, network and guest topology behind those readings, a comparison shows what moved between two runs, and six report profiles produce a printable document scoped to what the reader needs. Everything is available in the eight supported languages.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

scripts/lxc/lxc-privileged-to-unprivileged.sh

@@ -23,6 +23,10 @@ if [[ -f "$UTILS_FILE" ]]; then
     source "$UTILS_FILE"
 fi
 
+if [[ -f "$LOCAL_SCRIPTS/global/pmx_journal.sh" ]]; then
+    source "$LOCAL_SCRIPTS/global/pmx_journal.sh"
+fi
+
 load_language
 initialize_cache
 
@@ -53,6 +57,9 @@ select_privileged_container() {
 }
 
 validate_container_id() {
+    local FUNC_VERSION="1.1"
+    pmx_journal_context "validate_container_id" "$FUNC_VERSION"
+
     if [ -z "$CONTAINER_ID" ]; then
         msg_error "$(translate 'Container ID not defined. Make sure to select a container first.')"
         exit 1
@@ -66,6 +73,8 @@ validate_container_id() {
 
     if pct status "$CONTAINER_ID" | grep -q "running"; then
         msg_info "$(translate 'Stopping the container before conversion...')"
+        pmx_record_execution "stop CT ${CONTAINER_ID} for privileged-to-unprivileged conversion" \
+            "pct stop ${CONTAINER_ID}"
         pct stop "$CONTAINER_ID"
         msg_ok "$(translate 'Container stopped.')"
     fi
@@ -89,7 +98,12 @@ show_backup_warning() {
 }
 
 convert_direct_method() {
+    local FUNC_VERSION="1.1"
+    pmx_journal_context "convert_direct_method" "$FUNC_VERSION"
+
     msg_info2 "$(translate 'Starting direct conversion of container') $CONTAINER_ID..."
+    pmx_record_execution "convert CT ${CONTAINER_ID} filesystem ownership to unprivileged IDs" \
+        "mount rootfs, remap ownership by 100000, and update CT configuration"
     
     TEMP_DIR="/tmp/lxc_convert_$CONTAINER_ID"
     mkdir -p "$TEMP_DIR"
@@ -225,9 +239,9 @@ convert_direct_method() {
 
     CONFIG_FILE="/etc/pve/lxc/$CONTAINER_ID.conf"
     if ! grep -q "^unprivileged:" "$CONFIG_FILE"; then
-        echo "unprivileged: 1" >> "$CONFIG_FILE"
+        echo "unprivileged: 1" | pmx_append_file "$CONFIG_FILE"
     else
-        sed -i 's/^unprivileged:.*/unprivileged: 1/' "$CONFIG_FILE"
+        pmx_edit_file "$CONFIG_FILE" 's/^unprivileged:.*/unprivileged: 1/'
     fi
     
     msg_ok "$(translate 'Direct conversion completed for container') $CONTAINER_ID"
@@ -238,9 +252,12 @@ convert_direct_method() {
 }
 
 cleanup_and_finalize() {
+    local FUNC_VERSION="1.1"
+    pmx_journal_context "cleanup_and_finalize" "$FUNC_VERSION"
 
     if whiptail --yesno "$(translate 'Do you want to start the converted unprivileged container') $CONTAINER_ID $(translate 'now?')" 10 60; then
         msg_info2 "$(translate 'Starting unprivileged container...')"
+        pmx_record_execution "start converted unprivileged CT ${CONTAINER_ID}" "pct start ${CONTAINER_ID}"
         pct start "$CONTAINER_ID"
         msg_ok "$(translate 'Unprivileged container') $CONTAINER_ID $(translate 'started successfully.')"
     fi

scripts/lxc/lxc-unprivileged-to-privileged.sh

@@ -25,6 +25,10 @@ if [[ -f "$UTILS_FILE" ]]; then
     source "$UTILS_FILE"
 fi
 
+if [[ -f "$LOCAL_SCRIPTS/global/pmx_journal.sh" ]]; then
+    source "$LOCAL_SCRIPTS/global/pmx_journal.sh"
+fi
+
 load_language
 initialize_cache
 
@@ -69,12 +73,19 @@ show_backup_warning() {
 }
 
 convert_to_privileged() {
+    local FUNC_VERSION="2.0"
+    pmx_journal_context "convert_to_privileged" "$FUNC_VERSION"
+
     CONF_FILE="/etc/pve/lxc/$CONTAINER_ID.conf"
+    pmx_record_execution "convert CT ${CONTAINER_ID} to privileged mode" \
+        "stop CT if running and update ${CONF_FILE}"
     
     CONTAINER_STATUS=$(pct status "$CONTAINER_ID" | awk '{print $2}')
     
     if [ "$CONTAINER_STATUS" == "running" ]; then
         msg_info "$(translate 'Stopping container') $CONTAINER_ID..."
+        pmx_record_execution "stop CT ${CONTAINER_ID} for unprivileged-to-privileged conversion" \
+            "pct shutdown ${CONTAINER_ID}"
         pct shutdown "$CONTAINER_ID"
         
         # Wait for container to stop
@@ -101,8 +112,8 @@ convert_to_privileged() {
     msg_ok "$(translate 'Configuration backup created:') $CONF_FILE.bak"
     
     msg_info "$(translate 'Converting container to privileged...')"
-    sed -i '/^unprivileged: 1/d' "$CONF_FILE"
-    echo "unprivileged: 0" >> "$CONF_FILE"
+    pmx_edit_file "$CONF_FILE" '/^unprivileged: 1/d'
+    echo "unprivileged: 0" | pmx_append_file "$CONF_FILE"
     
     msg_ok "$(translate 'Container successfully converted to privileged.')"
 
@@ -112,9 +123,12 @@ convert_to_privileged() {
 }
 
 finalize_conversion() {
+    local FUNC_VERSION="2.0"
+    pmx_journal_context "finalize_conversion" "$FUNC_VERSION"
 
     if whiptail --yesno "$(translate 'Do you want to start the privileged container') $CONTAINER_ID $(translate 'now?')" 10 60; then
         msg_info "$(translate 'Starting privileged container...')"
+        pmx_record_execution "start converted privileged CT ${CONTAINER_ID}" "pct start ${CONTAINER_ID}"
         pct start "$CONTAINER_ID"
         msg_ok "$(translate 'Privileged container') $CONTAINER_ID $(translate 'started successfully.')"
     fi