5 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jacopo ClarkandGitHub	a2ee8d1e46	fix(ldap): do not create interfaces from interface_filter entries (#746) ... updateInterfaceLdapFilters saved the matched users with SaveInterface, which creates the interface when it is missing. On first start that panics. The sync runs immediately (main.go:85) and the importer later (main.go:116), so the sync creates a stub row for every interface_filter key, and the importer, which snapshotted the interface list before its device round-trips, then fails with "interface already exists". The window is GetInterfaces plus GetPeers, so a directory on localhost loses the race and a slower one hides it. The stub rows are wrong anyway. They have no backend, so a typo in an interface_filter key quietly created an interface attached to no controller. Look the interface up and skip with a warning when it is absent. The filter is applied on the next sync once the importer has created it. A lookup error that is not ErrNotFound also skips. Signed-off-by: clark-ja <37738506+clark-ja@users.noreply.github.com>	2026-09-01 22:47:46 +02:00
Jacopo ClarkandGitHub	64195a25c1	fix(ldap): do not disable every user when a sync returns no identifiers (#744) ... disable_missing tested absence against the raw sync result without checking that the search returned anything usable, so a search that succeeds and yields nothing looked like "every user has been removed". Connection and search errors were already safe, since synchronizeLdapUsers returns before the disable phase. The gap is the successful-but-empty case: a base_dn or sync_filter that stops matching, an unpopulated replica, a field_map user_identifier naming an attribute the server does not return, or a bind account that lost read access to the user subtree. LDAP gives nothing to tell those apart from a directory that is genuinely empty; they all answer success with zero entries. Acting on it is not a database flag. TopicUserDisabled removes each user's peers from the WireGuard device, the successful search means no error is logged, and every message on the path was Debug while log_level defaults to info, so the whole event was silent. It also repeats every sync interval. Refuse to disable anyone when no usable identifier came back, logging the provider, entry count and identifier field. The guard counts identifiers, not entries, so it covers the field_map case too. The per-user disable line moves from Debug to Warn so a mass disable is audible even where the guard does not fire. The cost is that a directory intentionally emptied of users now disables nobody. That is documented, along with the workaround: leave one account matching sync_filter and everyone else is disabled as before. Signed-off-by: clark-ja <37738506+clark-ja@users.noreply.github.com>	2026-09-01 22:38:31 +02:00
Jacopo ClarkandGitHub	a0cb7d9d39	fix(domain): make SanitizeString idempotent (#745) ... NFC normalisation ran before control and format characters were stripped. Removing a character can leave a base letter next to a combining mark the earlier pass never saw as a pair, so a second call composes it: input U+0041 U+0009 U+0300 ("A", tab, combining grave) once -> U+0041 U+0300 twice -> U+00C0 Found by TestPropertySanitizeStringIdempotent. Category Cf characters behave the same way. Strip first, then normalise. Normalisation still precedes truncation because composing changes the rune count. One side effect: invalid UTF-8 is now dropped by the strip loop instead of surviving as U+FFFD, so an identifier containing such bytes sanitises differently than before. Signed-off-by: clark-ja <37738506+clark-ja@users.noreply.github.com>	2026-09-01 22:30:37 +02:00
3 people	c1a7edcc9a	fix: prevent interface address clearing during startup (#651) ... Signed-off-by: jc <37738506+theguy147@users.noreply.github.com> Co-authored-by: jc <37738506+theguy147@users.noreply.github.com>	2026-03-25 22:08:06 +01:00
4 people	402cc1b5f3	feat: Implement LDAP interface-specific provisioning filters (#642) ... * Implement LDAP filter-based access control for interface provisioning * test: add unit tests for LDAP interface filtering logic * smaller improvements / cleanup --------- Co-authored-by: jc <37738506+theguy147@users.noreply.github.com> Co-authored-by: Christoph Haas <christoph.h@sprinternet.at>	2026-03-19 23:13:19 +01:00