ensure that LDAP filter values are escaped

docs/documentation/rest-api/swagger.yaml

@@ -403,12 +403,6 @@ definitions:
         type: object
     models.ProvisioningRequest:
         properties:
-            DisplayName:
-                description: |-
-                    DisplayName is an optional name for the new peer.
-                    If unset, a default template value (e.g., "API Peer ...") will be assigned.
-                example: API Peer xyz
-                type: string
             InterfaceIdentifier:
                 description: InterfaceIdentifier is the identifier of the WireGuard interface the peer should be linked to.
                 example: wg0

internal/app/api/core/assets/doc/v0_swagger.json

@@ -1781,11 +1781,6 @@
                         "type": "string"
                     }
                 },
-                "Backend": {
-                    "description": "the backend used for this interface e.g., local, mikrotik, ...",
-                    "type": "string",
-                    "example": "local"
-                },
                 "Disabled": {
                     "description": "flag that specifies if the interface is enabled (up) or not (down)",
                     "type": "boolean"
@@ -2254,12 +2249,6 @@
                 "ApiAdminOnly": {
                     "type": "boolean"
                 },
-                "AvailableBackends": {
-                    "type": "array",
-                    "items": {
-                        "$ref": "#/definitions/model.SettingsBackendNames"
-                    }
-                },
                 "LoginFormVisible": {
                     "type": "boolean"
                 },
@@ -2280,17 +2269,6 @@
                 }
             }
         },
-        "model.SettingsBackendNames": {
-            "type": "object",
-            "properties": {
-                "Id": {
-                    "type": "string"
-                },
-                "Name": {
-                    "type": "string"
-                }
-            }
-        },
         "model.User": {
             "type": "object",
             "properties": {

internal/app/api/core/assets/doc/v0_swagger.yaml

@@ -65,10 +65,6 @@ definitions:
         items:
           type: string
         type: array
-      Backend:
-        description: the backend used for this interface e.g., local, mikrotik, ...
-        example: local
-        type: string
       Disabled:
         description: flag that specifies if the interface is enabled (up) or not (down)
         type: boolean
@@ -385,10 +381,6 @@ definitions:
     properties:
       ApiAdminOnly:
         type: boolean
-      AvailableBackends:
-        items:
-          $ref: '#/definitions/model.SettingsBackendNames'
-        type: array
       LoginFormVisible:
         type: boolean
       MailLinkOnly:
@@ -402,13 +394,6 @@ definitions:
       WebAuthnEnabled:
         type: boolean
     type: object
-  model.SettingsBackendNames:
-    properties:
-      Id:
-        type: string
-      Name:
-        type: string
-    type: object
   model.User:
     properties:
       ApiEnabled:

internal/app/api/core/assets/doc/v1_swagger.json

@@ -2086,11 +2086,6 @@
                 "InterfaceIdentifier"
             ],
             "properties": {
-                "DisplayName": {
-                    "description": "DisplayName is an optional name for the new peer.\nIf unset, a default template value (e.g., \"API Peer ...\") will be assigned.",
-                    "type": "string",
-                    "example": "API Peer xyz"
-                },
                 "InterfaceIdentifier": {
                     "description": "InterfaceIdentifier is the identifier of the WireGuard interface the peer should be linked to.",
                     "type": "string",

internal/app/api/core/assets/doc/v1_swagger.yaml

@@ -445,12 +445,6 @@ definitions:
     type: object
   models.ProvisioningRequest:
     properties:
-      DisplayName:
-        description: |-
-          DisplayName is an optional name for the new peer.
-          If unset, a default template value (e.g., "API Peer ...") will be assigned.
-        example: API Peer xyz
-        type: string
       InterfaceIdentifier:
         description: InterfaceIdentifier is the identifier of the WireGuard interface
           the peer should be linked to.

internal/app/api/v1/backend/provisioning_service.go

@@ -162,11 +162,7 @@ func (p ProvisioningService) NewPeer(ctx context.Context, req models.Provisionin
 	if req.PresharedKey != "" {
 		peer.PresharedKey = domain.PreSharedKey(req.PresharedKey)
 	}
-	if req.DisplayName == "" {
-		peer.GenerateDisplayName("API")
-	} else {
-		peer.DisplayName = req.DisplayName
-	}
+	peer.GenerateDisplayName("API")
 
 	// save new peer
 	peer, err = p.peers.CreatePeer(ctx, peer)

internal/app/api/v1/models/models_provisioning.go

@@ -68,10 +68,6 @@ type ProvisioningRequest struct {
 	// If no user identifier is set, the authenticated user is used.
 	UserIdentifier string `json:"UserIdentifier" example:"uid-1234567"`
 
-	// DisplayName is an optional name for the new peer.
-	// If unset, a default template value (e.g., "API Peer ...") will be assigned.
-	DisplayName string `json:"DisplayName" example:"API Peer xyz" binding:"omitempty"`
-
 	// PublicKey is the optional public key of the peer. If no public key is set, a new key pair is generated.
 	PublicKey string `json:"PublicKey" example:"xTIBA5rboUvnH4htodjb6e697QjLERt1NAB4mZqp8Dg=" binding:"omitempty,len=44"`
 	// PresharedKey is the optional pre-shared key of the peer. If no pre-shared key is set, a new key is generated.

internal/app/auth/auth_ldap.go

@@ -54,7 +54,7 @@ func (l LdapAuthenticator) PlaintextAuthentication(userId domain.UserIdentifier,
 
 	attrs := []string{"dn"}
 
-	loginFilter := strings.Replace(l.cfg.LoginFilter, "{{login_identifier}}", string(userId), -1)
+	loginFilter := strings.Replace(l.cfg.LoginFilter, "{{login_identifier}}", ldap.EscapeFilter(string(userId)), -1)
 	searchRequest := ldap.NewSearchRequest(
 		l.cfg.BaseDN,
 		ldap.ScopeWholeSubtree, ldap.NeverDerefAliases, 0, 20, false, // 20 second time limit
@@ -100,7 +100,7 @@ func (l LdapAuthenticator) GetUserInfo(_ context.Context, userId domain.UserIden
 
 	attrs := internal.LdapSearchAttributes(&l.cfg.FieldMap)
 
-	loginFilter := strings.Replace(l.cfg.LoginFilter, "{{login_identifier}}", string(userId), -1)
+	loginFilter := strings.Replace(l.cfg.LoginFilter, "{{login_identifier}}", ldap.EscapeFilter(string(userId)), -1)
 	searchRequest := ldap.NewSearchRequest(
 		l.cfg.BaseDN,
 		ldap.ScopeWholeSubtree, ldap.NeverDerefAliases, 0, 20, false, // 20 second time limit