Fix api_v2 DNS record PUT tests for on_commit export and create_if_missing

This commit is contained in:
Eduardo Silva
2026-11-16 14:21:37 -03:00
parent 4e8ebce289
commit 4d02ae6879
+41 -20
View File
@@ -64,16 +64,17 @@ class ApiV2ManageDnsRecordTests(TestCase):
StaticHost.objects.create(hostname="app.example.com", ip_address="10.20.30.40")
DNSSettings.objects.create(name="dns_settings", pending_changes=True)
response = self.client.put(
self.url,
data=json.dumps({
"hostname": "app.example.com",
"ip_address": "10.20.30.41",
"skip_reload": False,
}),
content_type="application/json",
HTTP_TOKEN=str(self.api_key.token),
)
with self.captureOnCommitCallbacks(execute=True):
response = self.client.put(
self.url,
data=json.dumps({
"hostname": "app.example.com",
"ip_address": "10.20.30.41",
"skip_reload": False,
}),
content_type="application/json",
HTTP_TOKEN=str(self.api_key.token),
)
self.assertEqual(response.status_code, 200)
self.assertEqual(str(StaticHost.objects.get(hostname="app.example.com").ip_address), "10.20.30.41")
@@ -85,21 +86,41 @@ class ApiV2ManageDnsRecordTests(TestCase):
def test_put_upserts_missing_record_as_create(self, mock_export):
mock_export.side_effect = self._fake_export_dns_configuration
response = self.client.put(
self.url,
data=json.dumps({
"hostname": "new.example.com",
"ip_address": "10.20.30.50",
"skip_reload": False,
}),
content_type="application/json",
HTTP_TOKEN=str(self.api_key.token),
)
with self.captureOnCommitCallbacks(execute=True):
response = self.client.put(
self.url,
data=json.dumps({
"hostname": "new.example.com",
"ip_address": "10.20.30.50",
"skip_reload": False,
"create_if_missing": True,
}),
content_type="application/json",
HTTP_TOKEN=str(self.api_key.token),
)
self.assertEqual(response.status_code, 201)
self.assertTrue(StaticHost.objects.filter(hostname="new.example.com").exists())
mock_export.assert_called_once()
@patch("api_v2.views_api.export_dns_configuration")
def test_put_missing_record_without_create_if_missing_returns_404(self, mock_export):
with self.captureOnCommitCallbacks(execute=True):
response = self.client.put(
self.url,
data=json.dumps({
"hostname": "new.example.com",
"ip_address": "10.20.30.50",
"skip_reload": False,
}),
content_type="application/json",
HTTP_TOKEN=str(self.api_key.token),
)
self.assertEqual(response.status_code, 404)
self.assertFalse(StaticHost.objects.filter(hostname="new.example.com").exists())
mock_export.assert_not_called()
@patch("api_v2.views_api.export_dns_configuration")
def test_delete_deletes_record_and_does_not_require_ip(self, mock_export):
StaticHost.objects.create(hostname="del.example.com", ip_address="10.1.2.3")