Require Peer Manager level for scheduler profile and slot changes

This commit is contained in:
Eduardo Silva
2026-11-16 14:36:23 -03:00
parent 4d02ae6879
commit 76d735fe0f
3 changed files with 100 additions and 6 deletions
+66 -1
View File
@@ -1 +1,66 @@
# Create your tests here. import datetime
from django.contrib.auth.models import User
from django.test import TestCase
from django.urls import reverse
from scheduler.models import ScheduleProfile, ScheduleSlot
from user_manager.models import UserAcl
class SchedulerAccessControlTests(TestCase):
def setUp(self):
self.profile = ScheduleProfile.objects.create(name='Business Hours')
self.slot = ScheduleSlot.objects.create(
profile=self.profile, start_weekday=0, end_weekday=0,
start_time=datetime.time(8, 0), end_time=datetime.time(18, 0),
)
def _login_with_level(self, user_level):
user = User.objects.create_user(username=f'user{user_level}', password='fixture-password')
UserAcl.objects.create(user=user, user_level=user_level)
self.client.force_login(user)
def test_low_levels_cannot_change_profiles_or_slots(self):
for user_level in (10, 20):
with self.subTest(user_level=user_level):
self._login_with_level(user_level)
requests = (
(reverse('manage_scheduler_profile'), {'name': 'Changed', 'active': 'on'}),
(f"{reverse('manage_scheduler_profile')}?uuid={self.profile.uuid}", {'name': 'Changed'}),
(f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}", {}),
(f"{reverse('manage_scheduler_slot')}?profile_uuid={self.profile.uuid}", {
'start_weekday': 1, 'end_weekday': 1, 'start_time': '00:00', 'end_time': '23:59',
}),
(f"{reverse('delete_scheduler_slot')}?uuid={self.slot.uuid}", {}),
)
for url, data in requests:
response = self.client.post(url, data)
self.assertEqual(response.status_code, 200)
self.assertTemplateUsed(response, 'access_denied.html')
self.assertEqual(ScheduleProfile.objects.count(), 1)
self.assertEqual(ScheduleProfile.objects.get(uuid=self.profile.uuid).name, 'Business Hours')
self.assertEqual(ScheduleSlot.objects.count(), 1)
def test_peer_manager_can_delete_slot_and_profile(self):
self._login_with_level(30)
response = self.client.post(f"{reverse('delete_scheduler_slot')}?uuid={self.slot.uuid}")
self.assertEqual(response.status_code, 302)
self.assertFalse(ScheduleSlot.objects.exists())
response = self.client.post(f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}")
self.assertEqual(response.status_code, 302)
self.assertFalse(ScheduleProfile.objects.exists())
def test_profile_list_disables_crud_buttons_for_low_levels(self):
self._login_with_level(20)
response = self.client.get(reverse('scheduler_profile_list'))
self.assertEqual(response.status_code, 200)
self.assertContains(response, 'Business Hours')
self.assertNotContains(response, f"{reverse('manage_scheduler_profile')}?uuid={self.profile.uuid}")
self.assertNotContains(response, f"{reverse('delete_scheduler_profile')}?uuid={self.profile.uuid}")
self.assertContains(response, 'btn btn-primary disabled')
+13
View File
@@ -8,6 +8,7 @@ from django.utils.translation import gettext as _
from scheduler.forms import ScheduleProfileForm from scheduler.forms import ScheduleProfileForm
from scheduler.forms import ScheduleSlotForm from scheduler.forms import ScheduleSlotForm
from scheduler.models import ScheduleProfile, ScheduleSlot, PeerScheduling from scheduler.models import ScheduleProfile, ScheduleSlot, PeerScheduling
from user_manager.models import UserAcl
@login_required @login_required
@@ -21,6 +22,9 @@ def view_scheduler_profile_list(request):
@login_required @login_required
def view_manage_scheduler_profile(request): def view_manage_scheduler_profile(request):
if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists():
return render(request, 'access_denied.html', {'page_title': 'Access Denied'})
profile_uuid = request.GET.get('uuid') profile_uuid = request.GET.get('uuid')
if profile_uuid: if profile_uuid:
profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid) profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid)
@@ -60,6 +64,9 @@ def view_manage_scheduler_profile(request):
@login_required @login_required
def view_delete_scheduler_profile(request): def view_delete_scheduler_profile(request):
if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists():
return render(request, 'access_denied.html', {'page_title': 'Access Denied'})
profile_uuid = request.GET.get('uuid') profile_uuid = request.GET.get('uuid')
profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid) profile = get_object_or_404(ScheduleProfile, uuid=profile_uuid)
@@ -79,6 +86,9 @@ def view_delete_scheduler_profile(request):
@login_required @login_required
def view_manage_scheduler_slot(request): def view_manage_scheduler_slot(request):
if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists():
return render(request, 'access_denied.html', {'page_title': 'Access Denied'})
slot_uuid = request.GET.get('uuid') slot_uuid = request.GET.get('uuid')
profile_uuid = request.GET.get('profile_uuid') profile_uuid = request.GET.get('profile_uuid')
@@ -115,6 +125,9 @@ def view_manage_scheduler_slot(request):
@login_required @login_required
def view_delete_scheduler_slot(request): def view_delete_scheduler_slot(request):
if not UserAcl.objects.filter(user=request.user).filter(user_level__gte=30).exists():
return render(request, 'access_denied.html', {'page_title': 'Access Denied'})
slot_uuid = request.GET.get('uuid') slot_uuid = request.GET.get('uuid')
slot = get_object_or_404(ScheduleSlot, uuid=slot_uuid) slot = get_object_or_404(ScheduleSlot, uuid=slot_uuid)
profile = slot.profile profile = slot.profile
+21 -5
View File
@@ -21,12 +21,22 @@
<td>{{ profile.name }}</td> <td>{{ profile.name }}</td>
<td>{{ profile.peerscheduling_set.count }}</td> <td>{{ profile.peerscheduling_set.count }}</td>
<td class="text-nowrap"> <td class="text-nowrap">
<a href="{% url 'manage_scheduler_profile' %}?uuid={{ profile.uuid }}" <a
class="btn btn-sm btn-info" title="{% trans 'Edit' %}"> {% if user_acl.user_level >= 30 %}
href="{% url 'manage_scheduler_profile' %}?uuid={{ profile.uuid }}" class="btn btn-sm btn-info"
{% else %}
href="#" class="btn btn-sm btn-info disabled"
{% endif %}
title="{% trans 'Edit' %}">
<i class="far fa-edit"></i> <i class="far fa-edit"></i>
</a> </a>
<a href="{% url 'delete_scheduler_profile' %}?uuid={{ profile.uuid }}" <a
class="btn btn-sm btn-danger" title="{% trans 'Delete' %}"> {% if user_acl.user_level >= 30 %}
href="{% url 'delete_scheduler_profile' %}?uuid={{ profile.uuid }}" class="btn btn-sm btn-danger"
{% else %}
href="#" class="btn btn-sm btn-danger disabled"
{% endif %}
title="{% trans 'Delete' %}">
<i class="fas fa-trash"></i> <i class="fas fa-trash"></i>
</a> </a>
</td> </td>
@@ -40,7 +50,13 @@
</table> </table>
</div> </div>
<div class="card-footer"> <div class="card-footer">
<a href="{% url 'manage_scheduler_profile' %}" class="btn btn-primary"> <a
{% if user_acl.user_level >= 30 %}
href="{% url 'manage_scheduler_profile' %}" class="btn btn-primary"
{% else %}
href="#" class="btn btn-primary disabled"
{% endif %}
>
<i class="fas fa-plus"></i> {% trans 'Add Profile' %} <i class="fas fa-plus"></i> {% trans 'Add Profile' %}
</a> </a>
</div> </div>